cfd405eae6
When icount is enabled and we recompile an MMIO access we end up double counting the instruction execution. To avoid this we introduce the CF_MEMI cflag which only allows memory instrumentation for the next TB (which won't yet have been counted). As this is part of the hashed compile flags we will only execute the generated TB while coming out of a cpu_io_recompile. While we are at it delete the old TODO. We might as well keep the translation handy as it's likely you will repeatedly hit it on each MMIO access. Reported-by: Aaron Lindsay <aaron@os.amperecomputing.com> Signed-off-by: Alex Bennée <alex.bennee@linaro.org> Tested-by: Aaron Lindsay <aaron@os.amperecomputing.com> Reviewed-by: Richard Henderson <richard.henderson@linaro.org> Message-Id: <20210213130325.14781-21-alex.bennee@linaro.org>
72 lines
1.6 KiB
C
72 lines
1.6 KiB
C
/*
|
|
* Copyright (C) 2017, Emilio G. Cota <cota@braap.org>
|
|
*
|
|
* License: GNU GPL, version 2 or later.
|
|
* See the COPYING file in the top-level directory.
|
|
*
|
|
* plugin-gen.h - TCG-dependent definitions for generating plugin code
|
|
*
|
|
* This header should be included only from plugin.c and C files that emit
|
|
* TCG code.
|
|
*/
|
|
#ifndef QEMU_PLUGIN_GEN_H
|
|
#define QEMU_PLUGIN_GEN_H
|
|
|
|
#include "qemu/plugin.h"
|
|
#include "tcg/tcg.h"
|
|
|
|
struct DisasContextBase;
|
|
|
|
#ifdef CONFIG_PLUGIN
|
|
|
|
bool plugin_gen_tb_start(CPUState *cpu, const TranslationBlock *tb, bool supress);
|
|
void plugin_gen_tb_end(CPUState *cpu);
|
|
void plugin_gen_insn_start(CPUState *cpu, const struct DisasContextBase *db);
|
|
void plugin_gen_insn_end(void);
|
|
|
|
void plugin_gen_disable_mem_helpers(void);
|
|
void plugin_gen_empty_mem_callback(TCGv addr, uint32_t info);
|
|
|
|
static inline void plugin_insn_append(const void *from, size_t size)
|
|
{
|
|
struct qemu_plugin_insn *insn = tcg_ctx->plugin_insn;
|
|
|
|
if (insn == NULL) {
|
|
return;
|
|
}
|
|
|
|
insn->data = g_byte_array_append(insn->data, from, size);
|
|
}
|
|
|
|
#else /* !CONFIG_PLUGIN */
|
|
|
|
static inline
|
|
bool plugin_gen_tb_start(CPUState *cpu, const TranslationBlock *tb, bool supress)
|
|
{
|
|
return false;
|
|
}
|
|
|
|
static inline
|
|
void plugin_gen_insn_start(CPUState *cpu, const struct DisasContextBase *db)
|
|
{ }
|
|
|
|
static inline void plugin_gen_insn_end(void)
|
|
{ }
|
|
|
|
static inline void plugin_gen_tb_end(CPUState *cpu)
|
|
{ }
|
|
|
|
static inline void plugin_gen_disable_mem_helpers(void)
|
|
{ }
|
|
|
|
static inline void plugin_gen_empty_mem_callback(TCGv addr, uint32_t info)
|
|
{ }
|
|
|
|
static inline void plugin_insn_append(const void *from, size_t size)
|
|
{ }
|
|
|
|
#endif /* CONFIG_PLUGIN */
|
|
|
|
#endif /* QEMU_PLUGIN_GEN_H */
|
|
|