mirrors/qemu
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity
26,923 Commits 50 Branches 394 Tags 404 MiB
C 82.6%
C++ 6.5%
Python 3.4%
Dylan 2.9%
Shell 1.6%
Other 2.8%
bd5c51ee6c
Go to file
Michael Roth bd5c51ee6c qemu-char: don't issue CHR_EVENT_OPEN in a BH 
When CHR_EVENT_OPENED was initially added, it was CHR_EVENT_RESET,
and it was issued as a bottom-half:

86e94dea5b

Which we basically used to print out a greeting/prompt for the
monitor.

AFAICT the only reason this was ever done in a BH was because in
some cases we'd modify the chr_write handler for a new chardev
backend *after* the site where we issued the reset (see:
86e94d:qemu_chr_open_stdio())

At some point this event was renamed to CHR_EVENT_OPENED, and we've
maintained the use of this BH ever since.

However, due to 9f939df955, we schedule
the BH via g_idle_add(), which is causing events to sometimes be
delivered after we've already begun processing data from backends,
leading to:

 known bugs:

  QMP:
    session negotation resets with OPENED event, in some cases this
    is causing new sessions to get sporadically reset

 potential bugs:

  hw/usb/redirect.c:
    can_read handler checks for dev->parser != NULL, which may be
    true if CLOSED BH has not been executed yet. In the past, OPENED
    quiesced outstanding CLOSED events prior to us reading client
    data. If it's delayed, our check may allow reads to occur even
    though we haven't processed the OPENED event yet, and when we
    do finally get the OPENED event, our state may get reset.

  qtest.c:
    can begin session before OPENED event is processed, leading to
    a spurious reset of the system and irq_levels

  gdbstub.c:
    may start a gdb session prior to the machine being paused

To fix these, let's just drop the BH.

Since the initial reasoning for using it still applies to an extent,
work around that by deferring the delivery of CHR_EVENT_OPENED until
after the chardevs have been fully initialized, toward the end of
qmp_chardev_add() (or some cases, qemu_chr_new_from_opts()). This
defers delivery long enough that we can be assured a CharDriverState
is fully initialized before CHR_EVENT_OPENED is sent.

Also, rather than requiring each chardev to do an explicit open, do it
automatically, and allow the small few who don't desire such behavior to
suppress the OPENED-on-init behavior by setting a 'explicit_be_open'
flag.

We additionally add missing OPENED events for stdio backends on w32,
which were previously not being issued, causing us to not recieve the
banner and initial prompts for qmp/hmp.

Reported-by: Stefan Priebe <s.priebe@profihost.ag>
Signed-off-by: Michael Roth <mdroth@linux.vnet.ibm.com>
Message-id: 1370636393-21044-1-git-send-email-mdroth@linux.vnet.ibm.com
Cc: qemu-stable@nongnu.org
Signed-off-by: Michael Roth <mdroth@linux.vnet.ibm.com>
Signed-off-by: Anthony Liguori <aliguori@us.ibm.com>
2013-06-10 11:38:37 -05:00
audio Remove OSS support for OpenBSD 2013-05-26 11:14:52 +00:00
backends qemu-char: don't issue CHR_EVENT_OPEN in a BH 2013-06-10 11:38:37 -05:00
block qmp: add ImageInfo in BlockDeviceInfo used by query-block 2013-06-07 13:37:45 +02:00
bsd-user bsd-user: OS-agnostic 64-bit SYSCTL types 2013-05-12 13:25:55 +04:00
default-configs audio: Enable all cards 2013-05-03 12:04:49 -05:00
disas tcg-arm: Implement division instructions 2013-04-27 02:16:44 +02:00
docs docs: Fix typo and update file in migration 2013-06-01 14:25:38 +04:00
dtc@bc895d6d09 dtc: add submodule 2013-04-18 13:50:53 +02:00
fpu softfloat: Fix shift128Right for shift counts 64..127 2013-06-10 11:36:12 -05:00
fsdev remove double semicolons 2013-05-12 13:25:55 +04:00
gdb-xml
hw Merge remote-tracking branch 'stefanha/net' into staging 2013-06-10 11:37:39 -05:00
include qemu-char: don't issue CHR_EVENT_OPEN in a BH 2013-06-10 11:38:37 -05:00
ldscripts build: create ldscripts/ 2012-12-19 08:29:06 +01:00
libcacard libcacard/cac: change big switch functions to single return point 2013-04-24 11:48:06 +03:00
linux-headers linux-headers: Update to kvm/queue 2013-04-26 23:02:40 +02:00
linux-user linux-user: Fix typo in comment 2013-06-01 14:25:38 +04:00
net tap: fix NULL dereference when passing invalid parameters to tap 2013-06-07 15:48:11 +02:00
pc-bios gtk: use better icon 2013-06-10 11:36:12 -05:00
pixman@97336fad32 qapi: move include files to include/qobject/ 2012-12-19 08:31:31 +01:00
po po/hu.po: Hungarian translation for the GTK+ interface 2013-06-03 08:39:11 -05:00
qapi qapi: Fix unchecked strdup() by converting to g_strdup() 2013-01-30 11:14:46 +01:00
qga qga: save state directory in ga_install_service() 2013-05-30 11:37:37 -05:00
QMP correct RTC_CHANGE_EVENT description (v2) 2013-06-07 17:01:00 -04:00
qobject json-parser: fix handling of large whole number values 2013-05-23 09:44:20 -04:00
qom qom/object: Don't poll cast cache for NULL objects 2013-05-22 07:40:09 -05:00
roms update seabios to release 1.7.2.2 2013-05-28 12:19:02 +02:00
scripts block: add block driver read only whitelist 2013-06-04 12:11:58 +02:00
slirp slirp: cleanup leftovers from misc.h 2013-06-01 14:25:39 +04:00
stubs cpu: Introduce cpu_resume(), for single CPU 2013-05-01 13:04:17 +02:00
sysconfigs/target Eliminate cpus-x86_64.conf file 2012-09-21 15:12:58 +02:00
target-alpha cpu: Replace do_interrupt() by CPUClass::do_interrupt method 2013-03-12 10:35:55 +01:00
target-arm Remove unnecessary break statements 2013-06-01 14:25:38 +04:00
target-cris target-cris: Override do_interrupt for pre-v32 CPU cores 2013-04-16 02:45:11 +02:00
target-i386 target-i386: Fix aflag logic for CODE64 and the 0x67 prefix 2013-05-31 12:51:07 -05:00
target-lm32 hw: move headers to include/ 2013-04-08 18:13:10 +02:00
target-m68k cpu: Replace do_interrupt() by CPUClass::do_interrupt method 2013-03-12 10:35:55 +01:00
target-microblaze microblaze: Add internal base vectors reg 2013-04-26 11:28:50 +02:00
target-mips linux-user: Save the correct resume address for MIPS signal handling 2013-05-20 18:16:17 +02:00
target-moxie target-moxie: replace target_phys_addr_t with hwaddr 2013-05-18 16:35:12 +04:00
target-openrisc cpu: Replace do_interrupt() by CPUClass::do_interrupt method 2013-03-12 10:35:55 +01:00
target-ppc remove some double-includes 2013-05-18 16:35:12 +04:00
target-s390x Remove unnecessary break statements 2013-06-01 14:25:38 +04:00
target-sh4 hw: move headers to include/ 2013-04-08 18:13:10 +02:00
target-sparc Remove Sun4c, Sun4d and a few CPUs 2013-05-26 11:37:58 +00:00
target-unicore32 Remove unnecessary break statements 2013-06-01 14:25:38 +04:00
target-xtensa cpu: Replace do_interrupt() by CPUClass::do_interrupt method 2013-03-12 10:35:55 +01:00
tcg tcg/optimize: fix setcond2 optimization 2013-05-09 16:14:58 +02:00
tests ide-test: Add FLUSH CACHE test case 2013-06-06 11:27:29 +02:00
trace trace: Add ftrace tracing backend 2013-05-03 13:58:09 +02:00
ui qemu-char: don't issue CHR_EVENT_OPEN in a BH 2013-06-10 11:38:37 -05:00
util qemu-io: Move qemu_strsep() to cutils.c 2013-06-06 11:27:04 +02:00
.exrc qemu: add .exrc 2012-09-07 09:02:44 +03:00
.gitignore S390: ccw firmware: Add Makefile 2013-04-26 20:18:24 +02:00
.gitmodules dtc: add submodule 2013-04-18 13:50:53 +02:00
.mailmap Add a .mailmap to map pre-git-conversion authors to friendly names 2011-12-12 17:06:21 -06:00
aio-posix.c aio: support G_IO_HUP and G_IO_ERR 2013-02-21 16:17:31 -06:00
aio-win32.c aio: Fix return value of aio_poll() 2013-01-17 10:51:42 +01:00
arch_init.c memory: make memory_global_sync_dirty_bitmap take an AddressSpace 2013-05-24 18:42:51 +02:00
async.c aio: add a ThreadPool instance to AioContext 2013-03-15 16:07:50 +01:00
balloon.c softmmu: move include files to include/sysemu/ 2012-12-19 08:32:45 +01:00
block-migration.c migration: run setup callbacks out of big lock 2013-03-11 13:32:01 +01:00
block.c blkdebug: Add BLKDBG_FLUSH_TO_OS/DISK events 2013-06-06 11:27:22 +02:00
blockdev-nbd.c hw: move headers to include/ 2013-04-08 18:13:10 +02:00
blockdev.c blockdev: reset werror/rerror on drive_del 2013-06-05 16:39:59 +02:00
blockjob.c misc: move include files to include/qemu/ 2012-12-19 08:32:39 +01:00
bt-host.c sysemu: avoid proliferation of include/ subdirectories 2013-04-15 18:19:25 +02:00
bt-vhci.c sysemu: avoid proliferation of include/ subdirectories 2013-04-15 18:19:25 +02:00
Changelog fix some common typos 2012-05-14 07:27:24 +02:00
CODING_STYLE Replace Qemu by QEMU in internal documentation 2012-04-07 13:58:25 +00:00
configure block: add block driver read only whitelist 2013-06-04 12:11:58 +02:00
COPYING
COPYING.LIB
coroutine-gthread.c block: move include files to include/block/ 2012-12-19 08:31:31 +01:00
coroutine-sigaltstack.c Merge remote-tracking branch 'kwolf/for-anthony' into staging 2013-02-26 07:44:39 -06:00
coroutine-ucontext.c Fix warnings suppressors to honor --disable-werror 2013-04-17 10:28:04 -05:00
coroutine-win32.c block: move include files to include/block/ 2012-12-19 08:31:31 +01:00
cpu-exec.c Merge branch 'mingw' of git://qemu.weilnetz.de/qemu 2013-04-13 14:31:54 +02:00
cpus.c cpus: Fix pausing TCG CPUs while in vCPU thread 2013-05-02 12:15:38 +02:00
cputlb.c memory: add address_space_translate 2013-05-29 16:26:50 +02:00
device_tree.c softmmu: move include files to include/sysemu/ 2012-12-19 08:32:45 +01:00
device-hotplug.c hw: move device-hotplug.o to toplevel, compile it once 2013-03-01 13:57:13 +01:00
disas.c disas: Disassemble all ppc insns for the guest 2013-04-26 23:02:42 +02:00
dma-helpers.c memory: add address_space_access_valid 2013-05-29 16:27:16 +02:00
dump-stub.c cpu: Move cpu_write_elfXX_note() functions to CPUState 2013-05-01 13:04:19 +02:00
dump.c cpu: Move cpu_write_elfXX_note() functions to CPUState 2013-05-01 13:04:19 +02:00
exec.c memory: add return value to address_space_rw/read/write 2013-05-29 16:27:34 +02:00
gdbstub.c gdbstub: let the debugger resume from guest panicked state 2013-06-10 11:36:11 -05:00
HACKING osdep, kvm: rename low-level RAM allocation functions 2013-05-14 08:53:31 -05:00
hmp-commands.hx Make qemu-io commands available in HMP 2013-06-06 11:27:05 +02:00
hmp.c hmp: add parameters device and -v for info block 2013-06-07 13:45:01 +02:00
hmp.h Make qemu-io commands available in HMP 2013-06-06 11:27:05 +02:00
iohandler.c iohandler: switch to GPollFD 2013-02-21 16:17:31 -06:00
ioport.c exec: move include files to include/exec/ 2012-12-19 08:31:31 +01:00
kvm-all.c fix double free the memslot in kvm_set_phys_mem 2013-06-03 15:21:27 -05:00
kvm-stub.c kvm: add kvm_readonly_mem_enabled 2013-05-29 08:15:35 -05:00
LICENSE LICENSE: There is no libqemu.a anymore 2011-12-09 11:25:22 +00:00
main-loop.c main-loop: partial revert of 5e3bc73 2013-05-16 14:18:47 -05:00
MAINTAINERS MAINTAINERS: split Monitor (QMP/HMP) entry 2013-06-07 17:00:55 -04:00
Makefile gtk: use better icon 2013-06-10 11:36:12 -05:00
Makefile.objs Make qemu-io commands available in HMP 2013-06-06 11:27:05 +02:00
Makefile.target cpu: Make kvm-stub.o available outside softmmu 2013-05-01 13:04:17 +02:00
memory_mapping-stub.c softmmu: move include files to include/sysemu/ 2012-12-19 08:32:45 +01:00
memory_mapping.c exec: change RAM list to a TAILQ 2012-12-20 23:08:47 +01:00
memory.c memory: propagate errors on I/O dispatch 2013-05-29 16:27:32 +02:00
migration-exec.c migration: eliminate s->migration_file 2013-03-11 13:32:03 +01:00
migration-fd.c migration: eliminate s->migration_file 2013-03-11 13:32:03 +01:00
migration-tcp.c migration: eliminate s->migration_file 2013-03-11 13:32:03 +01:00
migration-unix.c migration: eliminate s->migration_file 2013-03-11 13:32:03 +01:00
migration.c migration: Remove duplicate bandwidth_limit set 2013-06-01 14:25:38 +04:00
monitor.c hmp: add parameters device and -v for info block 2013-06-07 13:45:01 +02:00
nbd.c nbd: support large NBD requests 2013-05-03 13:05:49 +02:00
os-posix.c Add option to mlock qemu and guest memory 2013-04-22 08:52:23 -05:00
os-win32.c qemu-timer: move timeBeginPeriod/timeEndPeriod to os-win32 2013-04-12 18:27:16 +02:00
page_cache.c remove some double-includes 2013-05-18 16:35:12 +04:00
qapi-schema-test.json qapi: add native list coverage for QMP output visitor tests 2013-05-23 09:44:21 -04:00
qapi-schema.json qmp: add ImageInfo in BlockDeviceInfo used by query-block 2013-06-07 13:37:45 +02:00
qdev-monitor.c qdev: Let qdev_prop_parse() pass through Error 2013-05-06 19:40:44 +02:00
qdict-test-data.txt
qemu-bridge-helper.c qemu-bridge-helper: force usage of a very high MAC address for the bridge 2013-03-28 12:58:52 -05:00
qemu-char.c qemu-char: don't issue CHR_EVENT_OPEN in a BH 2013-06-10 11:38:37 -05:00
qemu-coroutine-io.c misc: move include files to include/qemu/ 2012-12-19 08:32:39 +01:00
qemu-coroutine-lock.c coroutine: stop using AioContext in CoQueue 2013-05-24 16:17:56 +02:00
qemu-coroutine-sleep.c misc: move include files to include/qemu/ 2012-12-19 08:32:39 +01:00
qemu-coroutine.c coroutine: stop using AioContext in CoQueue 2013-05-24 16:17:56 +02:00
qemu-doc.texi Remove Sun4c, Sun4d and a few CPUs 2013-05-26 11:37:58 +00:00
qemu-img-cmds.hx qemu-img: Add compare subcommand 2013-02-22 21:21:10 +01:00
qemu-img.c block: add image info query function bdrv_query_image_info() 2013-06-07 13:37:45 +02:00
qemu-img.texi qemu-img: Add compare subcommand 2013-02-22 21:21:10 +01:00
qemu-io-cmds.c qemu-io: Interface cleanup 2013-06-06 11:27:05 +02:00
qemu-io.c qemu-io: Use the qemu version for -V 2013-06-06 11:27:05 +02:00
qemu-log.c qemu-log: default to stderr for logging output 2013-02-26 13:31:47 -06:00
qemu-nbd.c Add -f FMT / --format FMT arg to qemu-nbd 2013-04-15 14:29:20 -05:00
qemu-nbd.texi Add -f FMT / --format FMT arg to qemu-nbd 2013-04-15 14:29:20 -05:00
qemu-options-wrapper.h vl.c: In qemu -h output, only print options for the arch we are running as 2011-12-19 10:27:33 -06:00
qemu-options.h vl.c: Move option generation logic into a wrapper file 2011-12-19 10:27:33 -06:00
qemu-options.hx monitor: allow to disable the default monitor 2013-05-23 09:58:45 -04:00
qemu-seccomp.c seccomp: add the asynchronous I/O syscalls to the whitelist 2013-05-30 11:46:07 -05:00
qemu-tech.texi qemu-tech.texi: update implemented xtensa features list 2012-11-29 13:00:52 -06:00
qemu-timer.c qemu-timer: move timeBeginPeriod/timeEndPeriod to os-win32 2013-04-12 18:27:16 +02:00
qemu.sasl
qmp-commands.hx qmp: add ImageInfo in BlockDeviceInfo used by query-block 2013-06-07 13:37:45 +02:00
qmp.c QMP: Add cpu-add command 2013-05-01 13:06:07 +02:00
qtest.c qtest: Handle addresses and values for {in, out}[bwl] as unsigned 2013-04-22 09:11:50 -05:00
readline.c readline: Handle xterm escape sequences for Home/End keys 2013-05-14 08:53:22 -05:00
README Update README 2011-12-11 17:50:43 -06:00
rules.mak win32: fix compilation again 2013-05-03 12:04:40 -05:00
savevm.c block: dump snapshot and image info to specified output 2013-06-04 13:56:30 +02:00
spice-qemu-char.c qemu-char: don't issue CHR_EVENT_OPEN in a BH 2013-06-10 11:38:37 -05:00
tcg-runtime.c tcg: Implement multiword multiply helpers 2013-02-23 17:25:28 +00:00
tci.c tci: Make tcg temporaries local to tcg_qemu_tb_exec 2013-04-11 19:58:21 +02:00
thread-pool.c threadpool: drop global thread pool 2013-03-15 16:07:51 +01:00
thunk.c exec: move include files to include/exec/ 2012-12-19 08:31:31 +01:00
tpm.c Move TPM passthrough specific command line options to backend structure 2013-04-23 10:40:40 -05:00
trace-events Merge remote-tracking branch 'bonzini/iommu-for-anthony' into staging 2013-05-24 13:47:42 -05:00
translate-all.c memory: add address_space_translate 2013-05-29 16:26:50 +02:00
translate-all.h cputlb: Pass CPUState to cpu_unlink_tb() 2013-02-16 14:51:00 +01:00
user-exec.c Replace all setjmp()/longjmp() with sigsetjmp()/siglongjmp() 2013-02-23 16:11:19 +00:00
VERSION Open up 1.6 development 2013-05-20 10:55:18 -05:00
version.rc
vl.c gdbstub: let the debugger resume from guest panicked state 2013-06-10 11:36:11 -05:00
xbzrle.c Move XBZRLE encoding code to a separate file to allow testing 2013-02-01 08:32:20 +01:00
xen-all.c xen: remove xen_vcpu_init 2013-06-03 15:41:27 +00:00
xen-mapcache.c hw: move headers to include/ 2013-04-08 18:13:10 +02:00
xen-stub.c hw: move headers to include/ 2013-04-08 18:13:10 +02:00

README 

Read the documentation in qemu-doc.html or on http://wiki.qemu.org

- QEMU team