qemu/block
Max Reitz 0f39ac9a07 qcow2: Correct snapshots size for overlap check
Using s->snapshots_size instead of snapshots_size for the metadata
overlap check in qcow2_write_snapshots leads to the detection of an
overlap with the main qcow2 image header when deleting the last
snapshot, since s->snapshots_size has not yet been updated and is
therefore non-zero. However, the offset returned by qcow2_alloc_clusters
will be zero since snapshots_size is zero. Therefore, an overlap is
detected albeit no such will occur.

This patch fixes this by replacing s->snapshots_size by snapshots_size
when calling qcow2_pre_write_overlap_check.

Signed-off-by: Max Reitz <mreitz@redhat.com>
Signed-off-by: Stefan Hajnoczi <stefanha@redhat.com>
2013-09-20 12:48:03 +02:00
..
backup.c block: make bdrv_co_is_allocated static 2013-09-06 15:25:08 +02:00
blkdebug.c block: Error parameter for open functions 2013-09-12 10:12:48 +02:00
blkverify.c block: Error parameter for open functions 2013-09-12 10:12:48 +02:00
bochs.c bdrv: Use "Error" for opening images 2013-09-12 10:12:47 +02:00
cloop.c bdrv: Use "Error" for opening images 2013-09-12 10:12:47 +02:00
commit.c block: remove bdrv_is_allocated_above/bdrv_co_is_allocated_above distinction 2013-09-06 15:25:09 +02:00
cow.c block: Error parameter for create functions 2013-09-12 10:12:48 +02:00
curl.c bdrv: Use "Error" for opening images 2013-09-12 10:12:47 +02:00
dmg.c bdrv: Use "Error" for opening images 2013-09-12 10:12:47 +02:00
gluster.c bdrv: Use "Error" for creating images 2013-09-12 10:12:48 +02:00
iscsi.c Merge remote-tracking branch 'kwolf/for-anthony' into staging 2013-09-17 09:51:40 -05:00
linux-aio.c aio: drop io_flush argument 2013-08-19 15:52:19 +02:00
Makefile.objs switch raw block driver from "raw.o" to "raw_bsd.o" 2013-08-30 15:28:52 +02:00
mirror.c block: Error parameter for open functions 2013-09-12 10:12:48 +02:00
nbd.c bdrv: Use "Error" for opening images 2013-09-12 10:12:47 +02:00
parallels.c bdrv: Use "Error" for opening images 2013-09-12 10:12:47 +02:00
qapi.c block: Add iops_size to do the iops accounting for a given io size. 2013-09-06 15:25:07 +02:00
qcow2-cache.c qcow2-cache: Empty cache 2013-09-12 10:12:46 +02:00
qcow2-cluster.c qcow2-cluster: Expand zero clusters 2013-09-12 10:12:46 +02:00
qcow2-refcount.c qcow2-cluster: Expand zero clusters 2013-09-12 10:12:46 +02:00
qcow2-snapshot.c qcow2: Correct snapshots size for overlap check 2013-09-20 12:48:03 +02:00
qcow2.c qcow2: Use Error parameter 2013-09-12 10:12:48 +02:00
qcow2.h snapshot: distinguish id and name in snapshot delete 2013-09-12 10:12:47 +02:00
qcow.c block: Error parameter for create functions 2013-09-12 10:12:48 +02:00
qed-check.c qed: mark image clean after repair succeeds 2012-08-10 10:25:12 +02:00
qed-cluster.c Use glib memory allocation and free functions 2011-08-20 23:01:08 -05:00
qed-gencb.c Use glib memory allocation and free functions 2011-08-20 23:01:08 -05:00
qed-l2-cache.c qed: do not evict in-use L2 table cache entries 2012-03-12 15:14:06 +01:00
qed-table.c misc: move include files to include/qemu/ 2012-12-19 08:32:39 +01:00
qed.c block: Error parameter for create functions 2013-09-12 10:12:48 +02:00
qed.h block: move include files to include/block/ 2012-12-19 08:31:31 +01:00
raw_bsd.c block: Error parameter for create functions 2013-09-12 10:12:48 +02:00
raw-aio.h block: make discard asynchronous 2013-01-15 10:03:47 +01:00
raw-posix.c bdrv: Use "Error" for creating images 2013-09-12 10:12:48 +02:00
raw-win32.c bdrv: Use "Error" for creating images 2013-09-12 10:12:48 +02:00
rbd.c bdrv: Use "Error" for creating images 2013-09-12 10:12:48 +02:00
sheepdog.c block: Error parameter for open functions 2013-09-12 10:12:48 +02:00
snapshot.c bdrv: Use "Error" for opening images 2013-09-12 10:12:47 +02:00
ssh.c bdrv: Use "Error" for creating images 2013-09-12 10:12:48 +02:00
stream.c block: expect errors from bdrv_co_is_allocated 2013-09-06 15:25:09 +02:00
vdi.c bdrv: Use "Error" for creating images 2013-09-12 10:12:48 +02:00
vhdx.c bdrv: Use "Error" for opening images 2013-09-12 10:12:47 +02:00
vhdx.h misc: Fix new typos in comments and strings 2013-07-27 11:22:54 +04:00
vmdk.c block: Error parameter for open functions 2013-09-12 10:12:48 +02:00
vpc.c bdrv: Use "Error" for creating images 2013-09-12 10:12:48 +02:00
vvfat.c block: Error parameter for create functions 2013-09-12 10:12:48 +02:00
win32-aio.c win32-aio: drop win32_aio_flush_cb() 2013-08-22 22:05:04 +02:00