mirrors/qemu
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity
baf28675da
qemu/target/ppc/translate
History
Nicholas Piggin f64f1f8704 target/ppc: Fix LQ, STQ register-pair order for big-endian 
LQ, STQ have the same register-pair ordering as LQARX/STQARX., which is
the even (lower) register contains the most significant bits. This is
not implemented correctly for big-endian.

do_ldst_quad() has variables low_addr_gpr and high_addr_gpr which is
confusing because they are low and high addresses, whereas LQARX/STQARX.
and most such things use the low and high values for lo/hi variables.
The conversion to native 128-bit memory access functions missed this
strangeness.

Fix this by changing the if condition, and change the variable names to
hi/lo to match convention.

Cc: qemu-stable@nongnu.org
Reported-by: Ivan Warren <ivan@vmfacility.fr>
Fixes: 57b38ffd0c ("target/ppc: Use tcg_gen_qemu_{ld,st}_i128 for LQARX, LQ, STQ")
Resolves: https://gitlab.com/qemu-project/qemu/-/issues/1836
Signed-off-by: Nicholas Piggin <npiggin@gmail.com>
Reviewed-by: Richard Henderson <richard.henderson@linaro.org>
Signed-off-by: Cédric Le Goater <clg@kaod.org>
(cherry picked from commit 718209358f)
Signed-off-by: Michael Tokarev <mjt@tls.msk.ru>
2023-09-21 19:35:19 +03:00
..
branch-impl.c.inc target/ppc: Inline gen_icount_io_start() 2023-06-05 12:04:29 -07:00
dfp-impl.c.inc target/ppc: Drop tcg_temp_free 2023-03-05 13:44:08 -08:00
fixedpoint-impl.c.inc target/ppc: Fix LQ, STQ register-pair order for big-endian 2023-09-21 19:35:19 +03:00
fp-impl.c.inc target/ppc: Fix fallback to MFSS for MFFS* instructions on pre 3.0 ISAs 2023-05-27 08:25:19 -03:00
fp-ops.c.inc target/ppc: Move fsqrts to decodetree 2022-09-20 10:54:06 -03:00
processor-ctrl-impl.c.inc target/ppc: move msgsync to decodetree 2022-10-28 13:15:21 -03:00
spe-impl.c.inc target/ppc: Drop tcg_temp_free 2023-03-05 13:44:08 -08:00
spe-ops.c.inc
storage-ctrl-impl.c.inc target/ppc: Drop tcg_temp_free 2023-03-05 13:44:08 -08:00
vmx-impl.c.inc tcg: ppc64: Fix mask generation for vextractdm 2023-05-05 12:34:22 -03:00
vmx-ops.c.inc target/ppc: Move VABSDU[BHW] to decodetree and use gvec 2022-10-28 13:15:22 -03:00
vsx-impl.c.inc target/ppc: Avoid tcg_const_* in vsx-impl.c.inc 2023-03-13 07:03:39 -07:00
vsx-ops.c.inc target/ppc: Moved XSTSTDC[QDS]P to decodetree 2022-10-28 13:15:22 -03:00