8b5e6caf01
When [2] was fixed it was agreed that adding and calling post_plug() callback after device_reset() was low risk approach to hotfix issue right before release. So it was merged instead of moving already existing plug() callback after device_reset() is called which would be more risky and require all plug() callbacks audit. Looking at the current plug() callbacks, it doesn't seem that moving plug() callback after device_reset() is breaking anything, so here goes agreed upon [3] proper fix which essentially reverts [1][2] and moves plug() callback after device_reset(). This way devices always comes to plug() stage, after it's been fully initialized (including being reset), which fixes race condition [2] without need for an extra post_plug() callback. 1. (25e897881"qdev: add HotplugHandler->post_plug() callback") 2. (8449bcf94"virtio-scsi: fix hotplug ->reset() vs event race") 3. https://www.mail-archive.com/qemu-devel@nongnu.org/msg549915.html Signed-off-by: Igor Mammedov <imammedo@redhat.com> Message-Id: <1539696820-273275-1-git-send-email-imammedo@redhat.com> Reviewed-by: Stefan Hajnoczi <stefanha@redhat.com> Tested-by: Pierre Morel<pmorel@linux.ibm.com> Acked-by: Pierre Morel<pmorel@linux.ibm.com> Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
103 lines
3.0 KiB
C
103 lines
3.0 KiB
C
/*
|
|
* Hotplug handler interface.
|
|
*
|
|
* Copyright (c) 2014 Red Hat Inc.
|
|
*
|
|
* Authors:
|
|
* Igor Mammedov <imammedo@redhat.com>,
|
|
*
|
|
* This work is licensed under the terms of the GNU GPL, version 2 or later.
|
|
* See the COPYING file in the top-level directory.
|
|
*/
|
|
#ifndef HOTPLUG_H
|
|
#define HOTPLUG_H
|
|
|
|
#include "qom/object.h"
|
|
|
|
#define TYPE_HOTPLUG_HANDLER "hotplug-handler"
|
|
|
|
#define HOTPLUG_HANDLER_CLASS(klass) \
|
|
OBJECT_CLASS_CHECK(HotplugHandlerClass, (klass), TYPE_HOTPLUG_HANDLER)
|
|
#define HOTPLUG_HANDLER_GET_CLASS(obj) \
|
|
OBJECT_GET_CLASS(HotplugHandlerClass, (obj), TYPE_HOTPLUG_HANDLER)
|
|
#define HOTPLUG_HANDLER(obj) \
|
|
INTERFACE_CHECK(HotplugHandler, (obj), TYPE_HOTPLUG_HANDLER)
|
|
|
|
|
|
typedef struct HotplugHandler {
|
|
/* <private> */
|
|
Object Parent;
|
|
} HotplugHandler;
|
|
|
|
/**
|
|
* hotplug_fn:
|
|
* @plug_handler: a device performing plug/uplug action
|
|
* @plugged_dev: a device that has been (un)plugged
|
|
* @errp: returns an error if this function fails
|
|
*/
|
|
typedef void (*hotplug_fn)(HotplugHandler *plug_handler,
|
|
DeviceState *plugged_dev, Error **errp);
|
|
|
|
/**
|
|
* HotplugDeviceClass:
|
|
*
|
|
* Interface to be implemented by a device performing
|
|
* hardware (un)plug functions.
|
|
*
|
|
* @parent: Opaque parent interface.
|
|
* @pre_plug: pre plug callback called at start of device.realize(true)
|
|
* @plug: plug callback called at end of device.realize(true).
|
|
* @unplug_request: unplug request callback.
|
|
* Used as a means to initiate device unplug for devices that
|
|
* require asynchronous unplug handling.
|
|
* @unplug: unplug callback.
|
|
* Used for device removal with devices that implement
|
|
* asynchronous and synchronous (surprise) removal.
|
|
*/
|
|
typedef struct HotplugHandlerClass {
|
|
/* <private> */
|
|
InterfaceClass parent;
|
|
|
|
/* <public> */
|
|
hotplug_fn pre_plug;
|
|
hotplug_fn plug;
|
|
hotplug_fn unplug_request;
|
|
hotplug_fn unplug;
|
|
} HotplugHandlerClass;
|
|
|
|
/**
|
|
* hotplug_handler_plug:
|
|
*
|
|
* Call #HotplugHandlerClass.plug callback of @plug_handler.
|
|
*/
|
|
void hotplug_handler_plug(HotplugHandler *plug_handler,
|
|
DeviceState *plugged_dev,
|
|
Error **errp);
|
|
|
|
/**
|
|
* hotplug_handler_pre_plug:
|
|
*
|
|
* Call #HotplugHandlerClass.pre_plug callback of @plug_handler.
|
|
*/
|
|
void hotplug_handler_pre_plug(HotplugHandler *plug_handler,
|
|
DeviceState *plugged_dev,
|
|
Error **errp);
|
|
|
|
/**
|
|
* hotplug_handler_unplug_request:
|
|
*
|
|
* Calls #HotplugHandlerClass.unplug_request callback of @plug_handler.
|
|
*/
|
|
void hotplug_handler_unplug_request(HotplugHandler *plug_handler,
|
|
DeviceState *plugged_dev,
|
|
Error **errp);
|
|
/**
|
|
* hotplug_handler_unplug:
|
|
*
|
|
* Calls #HotplugHandlerClass.unplug callback of @plug_handler.
|
|
*/
|
|
void hotplug_handler_unplug(HotplugHandler *plug_handler,
|
|
DeviceState *plugged_dev,
|
|
Error **errp);
|
|
#endif
|