9e6bdef224
There are variants of qemu_create_pidfile() in qemu-pr-helper and
qemu-ga. Let's have a common implementation in libqemuutil.
The code is initially based from pr-helper write_pidfile(), with
various improvements and suggestions from Daniel Berrangé:
QEMU will leave the pidfile existing on disk when it exits which
initially made me think it avoids the deletion race. The app
managing QEMU, however, may well delete the pidfile after it has
seen QEMU exit, and even if the app locks the pidfile before
deleting it, there is still a race.
eg consider the following sequence
QEMU 1 libvirtd QEMU 2
1. lock(pidfile)
2. exit()
3. open(pidfile)
4. lock(pidfile)
5. open(pidfile)
6. unlink(pidfile)
7. close(pidfile)
8. lock(pidfile)
IOW, at step 8 the new QEMU has successfully acquired the lock, but
the pidfile no longer exists on disk because it was deleted after
the original QEMU exited.
While we could just say no external app should ever delete the
pidfile, I don't think that is satisfactory as people don't read
docs, and admins don't like stale pidfiles being left around on
disk.
To make this robust, I think we might want to copy libvirt's
approach to pidfile acquisition which runs in a loop and checks that
the file on disk /after/ acquiring the lock matches the file that
was locked. Then we could in fact safely let QEMU delete its own
pidfiles on clean exit..
Signed-off-by: Marc-André Lureau <marcandre.lureau@redhat.com>
Message-Id: <20180831145314.14736-2-marcandre.lureau@redhat.com>
Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
100 lines
3.0 KiB
C
100 lines
3.0 KiB
C
/*
|
|
* os-win32.c
|
|
*
|
|
* Copyright (c) 2003-2008 Fabrice Bellard
|
|
* Copyright (c) 2010 Red Hat, Inc.
|
|
*
|
|
* Permission is hereby granted, free of charge, to any person obtaining a copy
|
|
* of this software and associated documentation files (the "Software"), to deal
|
|
* in the Software without restriction, including without limitation the rights
|
|
* to use, copy, modify, merge, publish, distribute, sublicense, and/or sell
|
|
* copies of the Software, and to permit persons to whom the Software is
|
|
* furnished to do so, subject to the following conditions:
|
|
*
|
|
* The above copyright notice and this permission notice shall be included in
|
|
* all copies or substantial portions of the Software.
|
|
*
|
|
* THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR
|
|
* IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY,
|
|
* FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT SHALL
|
|
* THE AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER
|
|
* LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING FROM,
|
|
* OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN
|
|
* THE SOFTWARE.
|
|
*/
|
|
#include "qemu/osdep.h"
|
|
#include <windows.h>
|
|
#include <mmsystem.h>
|
|
#include "sysemu/sysemu.h"
|
|
#include "qemu-options.h"
|
|
|
|
/***********************************************************/
|
|
/* Functions missing in mingw */
|
|
|
|
int setenv(const char *name, const char *value, int overwrite)
|
|
{
|
|
int result = 0;
|
|
if (overwrite || !getenv(name)) {
|
|
size_t length = strlen(name) + strlen(value) + 2;
|
|
char *string = g_malloc(length);
|
|
snprintf(string, length, "%s=%s", name, value);
|
|
result = putenv(string);
|
|
|
|
/* Windows takes a copy and does not continue to use our string.
|
|
* Therefore it can be safely freed on this platform. POSIX code
|
|
* typically has to leak the string because according to the spec it
|
|
* becomes part of the environment.
|
|
*/
|
|
g_free(string);
|
|
}
|
|
return result;
|
|
}
|
|
|
|
static BOOL WINAPI qemu_ctrl_handler(DWORD type)
|
|
{
|
|
qemu_system_shutdown_request(SHUTDOWN_CAUSE_HOST_SIGNAL);
|
|
/* Windows 7 kills application when the function returns.
|
|
Sleep here to give QEMU a try for closing.
|
|
Sleep period is 10000ms because Windows kills the program
|
|
after 10 seconds anyway. */
|
|
Sleep(10000);
|
|
|
|
return TRUE;
|
|
}
|
|
|
|
static TIMECAPS mm_tc;
|
|
|
|
static void os_undo_timer_resolution(void)
|
|
{
|
|
timeEndPeriod(mm_tc.wPeriodMin);
|
|
}
|
|
|
|
void os_setup_early_signal_handling(void)
|
|
{
|
|
SetConsoleCtrlHandler(qemu_ctrl_handler, TRUE);
|
|
timeGetDevCaps(&mm_tc, sizeof(mm_tc));
|
|
timeBeginPeriod(mm_tc.wPeriodMin);
|
|
atexit(os_undo_timer_resolution);
|
|
}
|
|
|
|
/* Look for support files in the same directory as the executable. */
|
|
char *os_find_datadir(void)
|
|
{
|
|
return qemu_get_exec_dir();
|
|
}
|
|
|
|
void os_set_line_buffering(void)
|
|
{
|
|
setbuf(stdout, NULL);
|
|
setbuf(stderr, NULL);
|
|
}
|
|
|
|
/*
|
|
* Parse OS specific command line options.
|
|
* return 0 if option handled, -1 otherwise
|
|
*/
|
|
int os_parse_cmd_args(int index, const char *optarg)
|
|
{
|
|
return -1;
|
|
}
|