Stefan Reiter b660a84bbb job: take each job's lock individually in job_txn_apply ... All callers of job_txn_apply hold a single job's lock, but different jobs within a transaction can have different contexts, thus we need to lock each one individually before applying the callback function. Similar to job_completed_txn_abort this also requires releasing the caller's context before and reacquiring it after to avoid recursive locks which might break AIO_WAIT_WHILE in the callback. This is safe, since existing code would already have to take this into account, lest job_completed_txn_abort might have broken. This also brings to light a different issue: When a callback function in job_txn_apply moves it's job to a different AIO context, callers will try to release the wrong lock (now that we re-acquire the lock correctly, previously it would just continue with the old lock, leaving the job unlocked for the rest of the return path). Fix this by not caching the job's context. This is only necessary for qmp_block_job_finalize, qmp_job_finalize and job_exit, since everyone else calls through job_exit. One test needed adapting, since it calls job_finalize directly, so it manually needs to acquire the correct context. Signed-off-by: Stefan Reiter <s.reiter@proxmox.com> Message-Id: <20200407115651.69472-2-s.reiter@proxmox.com> Signed-off-by: Kevin Wolf <kwolf@redhat.com>		2020-04-07 14:34:47 +02:00
..
acceptance	Acceptance test: add "boot_linux" tests	2020-03-17 18:55:52 -04:00
data	rebuild-expected-aml.sh: remind about the process	2020-02-25 08:23:18 -05:00
decode
docker	tests/docker: Add libepoxy and libudev packages to the Fedora image	2020-03-27 13:43:20 +00:00
fp	testing: don't nest build for fp-test	2020-01-09 11:41:29 +00:00
guest-debug	tests/guest-debug: add a simple test runner	2020-03-17 17:38:47 +00:00
image-fuzzer	image-fuzzer: Use OSerror.strerror instead of tuple subscript	2019-11-05 16:36:11 +01:00
keys
migration	drop "from __future__ import print_function"	2020-02-07 15:15:16 +01:00
multiboot
perf/block/qcow2
plugin	tests/plugins: make howvec clean-up after itself.	2020-02-25 20:20:23 +00:00
qapi-schema	qapi: New special feature flag "deprecated"	2020-03-17 21:42:47 +01:00
qemu-iotests	iotests/138: Test leaks/corruptions fixed report	2020-03-26 14:52:43 +01:00
qtest	qtest: add tulip test case	2020-03-31 21:14:35 +08:00
rocker
tcg	tests/tcg/aarch64: add test-sve-ioctl guest-debug test	2020-03-17 17:38:47 +00:00
uefi-test-tools
vm	tests/vm: fix basevm config	2020-03-27 13:43:20 +00:00
vmstate-static-checker-data
.gitignore	tests/tcg/aarch64: add a gdbstub testcase for SVE registers	2020-03-17 17:38:47 +00:00
atomic64-bench.c
atomic_add-bench.c
benchmark-crypto-cipher.c	tests: benchmark crypto with fixed data size, not time period	2019-10-28 13:32:21 +01:00
benchmark-crypto-hash.c	tests: benchmark crypto with fixed data size, not time period	2019-10-28 13:32:21 +01:00
benchmark-crypto-hmac.c
check-block-qdict.c
check-block.sh	build: move TARGET_GPROF to config-host.mak	2020-02-12 16:29:27 +01:00
check-qdict.c
check-qjson.c
check-qlist.c
check-qlit.c
check-qnull.c
check-qnum.c
check-qobject.c
check-qom-interface.c
check-qom-proplist.c
check-qstring.c
crypto-tls-psk-helpers.c
crypto-tls-psk-helpers.h
crypto-tls-x509-helpers.c
crypto-tls-x509-helpers.h
dbus-vmstate-daemon.sh	tests: add dbus-vmstate-test	2020-01-06 18:41:32 +04:00
io-channel-helpers.c
io-channel-helpers.h
iothread.c	tests/iothread: Always connect iothread GSource to a GMainContext	2020-01-07 14:32:57 +00:00
iothread.h
Makefile.include	Python and tests (mostly acceptance) patches 2020-03-17	2020-03-19 12:33:50 +00:00
pkix_asn1_tab.c
ptimer-test-stubs.c
ptimer-test.c	tests/ptimer: Remove unnecessary inclusion of libqtest.h	2020-01-12 11:42:40 +01:00
ptimer-test.h
qht-bench.c
rcutorture.c	tests/rcutorture: mild documenting refactor of update thread	2020-02-25 17:42:59 +00:00
requirements.txt	Acceptance test: add "boot_linux" tests	2020-03-17 18:55:52 -04:00
socket-helpers.c
socket-helpers.h
test-aio-multithread.c
test-aio.c	util/async: make bh_aio_poll() O(1)	2020-02-22 08:26:47 +00:00
test-authz-list.c
test-authz-listfile.c
test-authz-pam.c
test-authz-simple.c
test-base64.c
test-bdrv-drain.c
test-bdrv-graph-mod.c
test-bitcnt.c
test-bitmap.c	tests: use g_test_rand_int	2019-12-17 09:05:23 +01:00
test-bitops.c
test-block-backend.c
test-block-iothread.c	block: Add @exact parameter to bdrv_co_truncate()	2019-10-28 12:00:07 +01:00
test-blockjob-txn.c
test-blockjob.c	job: take each job's lock individually in job_txn_apply	2020-04-07 14:34:47 +02:00
test-bufferiszero.c
test-char.c	chardev: Use QEMUChrEvent enum in IOEventHandler typedef	2020-01-08 11:15:35 +01:00
test-clone-visitor.c
test-coroutine.c
test-crypto-afsplit.c
test-crypto-block.c
test-crypto-cipher.c
test-crypto-hash.c
test-crypto-hmac.c
test-crypto-ivgen.c
test-crypto-pbkdf.c
test-crypto-secret.c
test-crypto-tlscredsx509.c	glib: use portable g_setenv()	2019-12-17 09:05:23 +01:00
test-crypto-tlssession.c	glib: use portable g_setenv()	2019-12-17 09:05:23 +01:00
test-crypto-xts.c
test-cutils.c
test-hbitmap.c	block/dirty-bitmap: improve _next_dirty_area API	2020-03-18 14:03:46 -04:00
test-image-locking.c
test-int128.c
test-io-channel-buffer.c
test-io-channel-command.c
test-io-channel-file.c
test-io-channel-socket.c
test-io-channel-tls.c	glib: use portable g_setenv()	2019-12-17 09:05:23 +01:00
test-io-task.c
test-iov.c
test-keyval.c	test-keyval: Tighten test of trailing crap after size	2019-12-18 12:28:44 +01:00
test-logging.c	test-logging: Fix -Werror=maybe-uninitialized warning	2020-02-04 09:00:57 +01:00
test-mul64.c
test-opts-visitor.c
test-qapi-util.c
test-qdev-global-props.c	qdev: set properties with device_class_set_props()	2020-01-24 20:59:15 +01:00
test-qdist.c
test-qemu-opts.c
test-qga.c	tests: use g_test_rand_int	2019-12-17 09:05:23 +01:00
test-qgraph.c
test-qht-par.c
test-qht.c
test-qmp-cmds.c	qapi: Add feature flags to remaining definitions	2020-03-17 19:58:34 +01:00
test-qmp-event.c	tests/test-qmp-event: Check event is actually emitted	2020-03-17 19:58:34 +01:00
test-qobject-input-visitor.c
test-qobject-output-visitor.c	tests: Clean up initialization of Error *err variables	2019-12-18 08:36:15 +01:00
test-rcu-list.c	tests: Fix a bug with count variables	2020-03-06 10:35:15 +00:00
test-rcu-simpleq.c
test-rcu-slist.c	rcu_queue: add QSLIST functions	2020-02-22 08:26:47 +00:00
test-rcu-tailq.c
test-replication.c	tests/test-replication.c: Add test for for secondary node continuing replication	2020-03-03 18:04:47 +08:00
test-shift128.c
test-string-input-visitor.c
test-string-output-visitor.c	tests: Clean up initialization of Error *err variables	2019-12-18 08:36:15 +01:00
test-thread-pool.c
test-throttle.c
test-timed-average.c
test-util-filemonitor.c	tests/test-util-filemonitor: Skip test on non-x86 Travis containers	2019-12-18 20:17:45 +00:00
test-util-sockets.c	hmp: Fail gracefully if chardev is already in use	2020-03-06 17:21:28 +01:00
test-uuid.c
test-visitor-serialization.c
test-vmstate.c	test-vmstate: Fix memleaks in test_load_qlist	2020-02-28 09:25:49 +01:00
test-write-threshold.c
test-x86-cpuid.c	hw/i386: Update structures to save the number of nodes per package	2020-03-17 19:48:10 -04:00
test-xbzrle.c
vhost-user-bridge.c	core: replace getpagesize() with qemu_real_host_page_size	2019-10-26 15:38:06 +02:00