5d72c68b49
It's useful to know how much space can be occupied by qcow2 persistent
bitmaps, even though such metadata is unrelated to the guest-visible
data. Report this value as an additional QMP field, present when
measuring an existing image and output format that both support
bitmaps. Update iotest 178 and 190 to updated output, as well as new
coverage in 190 demonstrating non-zero values made possible with the
recently-added qemu-img bitmap command (see 3b51ab4b).
The new 'bitmaps size:' field is displayed automatically as part of
'qemu-img measure' any time it is present in QMP (that is, any time
both the source image being measured and destination format support
bitmaps, even if the measurement is 0 because there are no bitmaps
present). If the field is absent, it means that no bitmaps can be
copied (source, destination, or both lack bitmaps, including when
measuring based on size rather than on a source image). This behavior
is compatible with an upcoming patch adding 'qemu-img convert
--bitmaps': that command will fail in the same situations where this
patch omits the field.
The addition of a new field demonstrates why we should always
zero-initialize qapi C structs; while the qcow2 driver still fully
populates all fields, the raw and crypto drivers had to be tweaked to
avoid uninitialized data.
Consideration was also given towards having a 'qemu-img measure
--bitmaps' which errors out when bitmaps are not possible, and
otherwise sums the bitmaps into the existing allocation totals rather
than displaying as a separate field, as a potential convenience
factor. But this was ultimately decided to be more complexity than
necessary when the QMP interface was sufficient enough with bitmaps
remaining a separate field.
See also: https://bugzilla.redhat.com/1779904
Reported-by: Nir Soffer <nsoffer@redhat.com>
Signed-off-by: Eric Blake <eblake@redhat.com>
Message-Id: <20200521192137.1120211-3-eblake@redhat.com>
Reviewed-by: Vladimir Sementsov-Ogievskiy <vsementsov@virtuozzo.com>
327 lines
7.9 KiB
Plaintext
327 lines
7.9 KiB
Plaintext
QA output created by 178
|
|
== Input validation ==
|
|
|
|
Formatting 'TEST_DIR/t.IMGFMT', fmt=IMGFMT size=1073741824
|
|
qemu-img: Either --size N or one filename must be specified.
|
|
qemu-img: --size N cannot be used together with a filename.
|
|
qemu-img: At most one filename argument is allowed.
|
|
qemu-img: Either --size N or one filename must be specified.
|
|
qemu-img: --image-opts, -f, and -l require a filename argument.
|
|
qemu-img: --image-opts, -f, and -l require a filename argument.
|
|
qemu-img: --image-opts, -f, and -l require a filename argument.
|
|
qemu-img: Invalid option list: ,
|
|
qemu-img: Invalid parameter 'snapshot.foo'
|
|
qemu-img: Failed in parsing snapshot param 'snapshot.foo'
|
|
qemu-img: --output must be used with human or json as argument.
|
|
qemu-img: Invalid image size specified. Must be between 0 and 9223372036854775807.
|
|
qemu-img: Unknown file format 'foo'
|
|
|
|
== Size calculation for a new file (human) ==
|
|
|
|
required size: 196608
|
|
fully allocated size: 196608
|
|
required size: 589824
|
|
fully allocated size: 2148073472
|
|
required size: 10747904
|
|
fully allocated size: 68730224640
|
|
required size: 42205184
|
|
fully allocated size: 274920112128
|
|
required size: 168034304
|
|
fully allocated size: 1099679662080
|
|
required size: 343650009088
|
|
fully allocated size: 2252143463694336
|
|
qemu-img: The image size is too large (try using a larger cluster size)
|
|
|
|
== Empty qcow2 input image (human) ==
|
|
|
|
Formatting 'TEST_DIR/t.IMGFMT', fmt=IMGFMT size=0
|
|
required size: 196608
|
|
fully allocated size: 196608
|
|
bitmaps size: 0
|
|
|
|
converted image file size in bytes: 196608
|
|
|
|
== qcow2 input image with data (human) ==
|
|
|
|
Formatting 'TEST_DIR/t.IMGFMT', fmt=IMGFMT size=1073741824
|
|
required size: 393216
|
|
fully allocated size: 1074135040
|
|
bitmaps size: 0
|
|
wrote 512/512 bytes at offset 512
|
|
512 bytes, X ops; XX:XX:XX.X (XXX YYY/sec and XXX ops/sec)
|
|
wrote 65536/65536 bytes at offset 65536
|
|
64 KiB, X ops; XX:XX:XX.X (XXX YYY/sec and XXX ops/sec)
|
|
wrote 64512/64512 bytes at offset 134217728
|
|
63 KiB, X ops; XX:XX:XX.X (XXX YYY/sec and XXX ops/sec)
|
|
required size: 589824
|
|
fully allocated size: 1074135040
|
|
bitmaps size: 0
|
|
|
|
converted image file size in bytes: 524288
|
|
|
|
== qcow2 input image with internal snapshot (human) ==
|
|
|
|
required size: 524288
|
|
fully allocated size: 1074135040
|
|
bitmaps size: 0
|
|
|
|
converted image file size in bytes: 458752
|
|
|
|
== qcow2 input image and a backing file (human) ==
|
|
|
|
required size: 1074135040
|
|
fully allocated size: 1074135040
|
|
bitmaps size: 0
|
|
|
|
== qcow2 input image and LUKS encryption ==
|
|
|
|
required size: 2686976
|
|
fully allocated size: 1076232192
|
|
bitmaps size: 0
|
|
|
|
== qcow2 input image and preallocation (human) ==
|
|
|
|
required size: 1074135040
|
|
fully allocated size: 1074135040
|
|
bitmaps size: 0
|
|
|
|
converted image file size in bytes: 1074135040
|
|
|
|
== Fully-allocated qcow2 input image (human) ==
|
|
|
|
Formatting 'TEST_DIR/t.IMGFMT', fmt=IMGFMT size=8388608
|
|
wrote 8388608/8388608 bytes at offset 0
|
|
8 MiB, X ops; XX:XX:XX.X (XXX YYY/sec and XXX ops/sec)
|
|
required size: 8716288
|
|
fully allocated size: 8716288
|
|
bitmaps size: 0
|
|
|
|
converted image file size in bytes: 8716288
|
|
|
|
== Empty raw input image (human) ==
|
|
|
|
Formatting 'TEST_DIR/t.qcow2', fmt=IMGFMT size=0
|
|
required size: 196608
|
|
fully allocated size: 196608
|
|
|
|
converted image file size in bytes: 196608
|
|
|
|
== raw input image with data (human) ==
|
|
|
|
Formatting 'TEST_DIR/t.qcow2', fmt=IMGFMT size=1073741824
|
|
required size: 458752
|
|
fully allocated size: 1074135040
|
|
wrote 512/512 bytes at offset 512
|
|
512 bytes, X ops; XX:XX:XX.X (XXX YYY/sec and XXX ops/sec)
|
|
wrote 65536/65536 bytes at offset 65536
|
|
64 KiB, X ops; XX:XX:XX.X (XXX YYY/sec and XXX ops/sec)
|
|
wrote 64512/64512 bytes at offset 134217728
|
|
63 KiB, X ops; XX:XX:XX.X (XXX YYY/sec and XXX ops/sec)
|
|
required size: 589824
|
|
fully allocated size: 1074135040
|
|
|
|
converted image file size in bytes: 524288
|
|
|
|
== raw input image and a backing file (human) ==
|
|
|
|
required size: 1074135040
|
|
fully allocated size: 1074135040
|
|
|
|
== raw input image and LUKS encryption ==
|
|
|
|
required size: 2686976
|
|
fully allocated size: 1076232192
|
|
|
|
== raw input image and preallocation (human) ==
|
|
|
|
required size: 1074135040
|
|
fully allocated size: 1074135040
|
|
|
|
converted image file size in bytes: 1074135040
|
|
|
|
== Fully-allocated raw input image (human) ==
|
|
|
|
Formatting 'TEST_DIR/t.qcow2', fmt=IMGFMT size=8388608
|
|
wrote 8388608/8388608 bytes at offset 0
|
|
8 MiB, X ops; XX:XX:XX.X (XXX YYY/sec and XXX ops/sec)
|
|
required size: 8716288
|
|
fully allocated size: 8716288
|
|
|
|
converted image file size in bytes: 8716288
|
|
|
|
== Size calculation for a new file (json) ==
|
|
|
|
{
|
|
"required": 196608,
|
|
"fully-allocated": 196608
|
|
}
|
|
{
|
|
"required": 589824,
|
|
"fully-allocated": 2148073472
|
|
}
|
|
{
|
|
"required": 10747904,
|
|
"fully-allocated": 68730224640
|
|
}
|
|
{
|
|
"required": 42205184,
|
|
"fully-allocated": 274920112128
|
|
}
|
|
{
|
|
"required": 168034304,
|
|
"fully-allocated": 1099679662080
|
|
}
|
|
{
|
|
"required": 343650009088,
|
|
"fully-allocated": 2252143463694336
|
|
}
|
|
qemu-img: The image size is too large (try using a larger cluster size)
|
|
|
|
== Empty qcow2 input image (json) ==
|
|
|
|
Formatting 'TEST_DIR/t.IMGFMT', fmt=IMGFMT size=0
|
|
{
|
|
"bitmaps": 0,
|
|
"required": 196608,
|
|
"fully-allocated": 196608
|
|
}
|
|
|
|
converted image file size in bytes: 196608
|
|
|
|
== qcow2 input image with data (json) ==
|
|
|
|
Formatting 'TEST_DIR/t.IMGFMT', fmt=IMGFMT size=1073741824
|
|
{
|
|
"bitmaps": 0,
|
|
"required": 393216,
|
|
"fully-allocated": 1074135040
|
|
}
|
|
wrote 512/512 bytes at offset 512
|
|
512 bytes, X ops; XX:XX:XX.X (XXX YYY/sec and XXX ops/sec)
|
|
wrote 65536/65536 bytes at offset 65536
|
|
64 KiB, X ops; XX:XX:XX.X (XXX YYY/sec and XXX ops/sec)
|
|
wrote 64512/64512 bytes at offset 134217728
|
|
63 KiB, X ops; XX:XX:XX.X (XXX YYY/sec and XXX ops/sec)
|
|
{
|
|
"bitmaps": 0,
|
|
"required": 589824,
|
|
"fully-allocated": 1074135040
|
|
}
|
|
|
|
converted image file size in bytes: 524288
|
|
|
|
== qcow2 input image with internal snapshot (json) ==
|
|
|
|
{
|
|
"bitmaps": 0,
|
|
"required": 524288,
|
|
"fully-allocated": 1074135040
|
|
}
|
|
|
|
converted image file size in bytes: 458752
|
|
|
|
== qcow2 input image and a backing file (json) ==
|
|
|
|
{
|
|
"bitmaps": 0,
|
|
"required": 1074135040,
|
|
"fully-allocated": 1074135040
|
|
}
|
|
|
|
== qcow2 input image and LUKS encryption ==
|
|
|
|
{
|
|
"bitmaps": 0,
|
|
"required": 2686976,
|
|
"fully-allocated": 1076232192
|
|
}
|
|
|
|
== qcow2 input image and preallocation (json) ==
|
|
|
|
{
|
|
"bitmaps": 0,
|
|
"required": 1074135040,
|
|
"fully-allocated": 1074135040
|
|
}
|
|
|
|
converted image file size in bytes: 1074135040
|
|
|
|
== Fully-allocated qcow2 input image (json) ==
|
|
|
|
Formatting 'TEST_DIR/t.IMGFMT', fmt=IMGFMT size=8388608
|
|
wrote 8388608/8388608 bytes at offset 0
|
|
8 MiB, X ops; XX:XX:XX.X (XXX YYY/sec and XXX ops/sec)
|
|
{
|
|
"bitmaps": 0,
|
|
"required": 8716288,
|
|
"fully-allocated": 8716288
|
|
}
|
|
|
|
converted image file size in bytes: 8716288
|
|
|
|
== Empty raw input image (json) ==
|
|
|
|
Formatting 'TEST_DIR/t.qcow2', fmt=IMGFMT size=0
|
|
{
|
|
"required": 196608,
|
|
"fully-allocated": 196608
|
|
}
|
|
|
|
converted image file size in bytes: 196608
|
|
|
|
== raw input image with data (json) ==
|
|
|
|
Formatting 'TEST_DIR/t.qcow2', fmt=IMGFMT size=1073741824
|
|
{
|
|
"required": 458752,
|
|
"fully-allocated": 1074135040
|
|
}
|
|
wrote 512/512 bytes at offset 512
|
|
512 bytes, X ops; XX:XX:XX.X (XXX YYY/sec and XXX ops/sec)
|
|
wrote 65536/65536 bytes at offset 65536
|
|
64 KiB, X ops; XX:XX:XX.X (XXX YYY/sec and XXX ops/sec)
|
|
wrote 64512/64512 bytes at offset 134217728
|
|
63 KiB, X ops; XX:XX:XX.X (XXX YYY/sec and XXX ops/sec)
|
|
{
|
|
"required": 589824,
|
|
"fully-allocated": 1074135040
|
|
}
|
|
|
|
converted image file size in bytes: 524288
|
|
|
|
== raw input image and a backing file (json) ==
|
|
|
|
{
|
|
"required": 1074135040,
|
|
"fully-allocated": 1074135040
|
|
}
|
|
|
|
== raw input image and LUKS encryption ==
|
|
|
|
{
|
|
"required": 2686976,
|
|
"fully-allocated": 1076232192
|
|
}
|
|
|
|
== raw input image and preallocation (json) ==
|
|
|
|
{
|
|
"required": 1074135040,
|
|
"fully-allocated": 1074135040
|
|
}
|
|
|
|
converted image file size in bytes: 1074135040
|
|
|
|
== Fully-allocated raw input image (json) ==
|
|
|
|
Formatting 'TEST_DIR/t.qcow2', fmt=IMGFMT size=8388608
|
|
wrote 8388608/8388608 bytes at offset 0
|
|
8 MiB, X ops; XX:XX:XX.X (XXX YYY/sec and XXX ops/sec)
|
|
{
|
|
"required": 8716288,
|
|
"fully-allocated": 8716288
|
|
}
|
|
|
|
converted image file size in bytes: 8716288
|
|
*** done
|