5325cc34a2
The object_property_set_FOO() setters take property name and value in
an unusual order:
void object_property_set_FOO(Object *obj, FOO_TYPE value,
const char *name, Error **errp)
Having to pass value before name feels grating. Swap them.
Same for object_property_set(), object_property_get(), and
object_property_parse().
Convert callers with this Coccinelle script:
@@
identifier fun = {
object_property_get, object_property_parse, object_property_set_str,
object_property_set_link, object_property_set_bool,
object_property_set_int, object_property_set_uint, object_property_set,
object_property_set_qobject
};
expression obj, v, name, errp;
@@
- fun(obj, v, name, errp)
+ fun(obj, name, v, errp)
Chokes on hw/arm/musicpal.c's lcd_refresh() with the unhelpful error
message "no position information". Convert that one manually.
Fails to convert hw/arm/armsse.c, because Coccinelle gets confused by
ARMSSE being used both as typedef and function-like macro there.
Convert manually.
Fails to convert hw/rx/rx-gdbsim.c, because Coccinelle gets confused
by RXCPU being used both as typedef and function-like macro there.
Convert manually. The other files using RXCPU that way don't need
conversion.
Signed-off-by: Markus Armbruster <armbru@redhat.com>
Reviewed-by: Eric Blake <eblake@redhat.com>
Reviewed-by: Vladimir Sementsov-Ogievskiy <vsementsov@virtuozzo.com>
Message-Id: <20200707160613.848843-27-armbru@redhat.com>
[Straightforwad conflict with commit 2336172d9b "audio: set default
value for pcspk.iobase property" resolved]
96 lines
2.8 KiB
C
96 lines
2.8 KiB
C
/*
|
|
* Virtio crypto device
|
|
*
|
|
* Copyright (c) 2016 HUAWEI TECHNOLOGIES CO., LTD.
|
|
*
|
|
* Authors:
|
|
* Gonglei <arei.gonglei@huawei.com>
|
|
*
|
|
* This work is licensed under the terms of the GNU GPL, version 2 or
|
|
* (at your option) any later version. See the COPYING file in the
|
|
* top-level directory.
|
|
*
|
|
*/
|
|
|
|
#include "qemu/osdep.h"
|
|
#include "hw/pci/pci.h"
|
|
#include "hw/qdev-properties.h"
|
|
#include "hw/virtio/virtio.h"
|
|
#include "hw/virtio/virtio-bus.h"
|
|
#include "hw/virtio/virtio-pci.h"
|
|
#include "hw/virtio/virtio-crypto.h"
|
|
#include "qapi/error.h"
|
|
#include "qemu/module.h"
|
|
|
|
typedef struct VirtIOCryptoPCI VirtIOCryptoPCI;
|
|
|
|
/*
|
|
* virtio-crypto-pci: This extends VirtioPCIProxy.
|
|
*/
|
|
#define TYPE_VIRTIO_CRYPTO_PCI "virtio-crypto-pci"
|
|
#define VIRTIO_CRYPTO_PCI(obj) \
|
|
OBJECT_CHECK(VirtIOCryptoPCI, (obj), TYPE_VIRTIO_CRYPTO_PCI)
|
|
|
|
struct VirtIOCryptoPCI {
|
|
VirtIOPCIProxy parent_obj;
|
|
VirtIOCrypto vdev;
|
|
};
|
|
|
|
static Property virtio_crypto_pci_properties[] = {
|
|
DEFINE_PROP_BIT("ioeventfd", VirtIOPCIProxy, flags,
|
|
VIRTIO_PCI_FLAG_USE_IOEVENTFD_BIT, true),
|
|
DEFINE_PROP_UINT32("vectors", VirtIOPCIProxy, nvectors, 2),
|
|
DEFINE_PROP_END_OF_LIST(),
|
|
};
|
|
|
|
static void virtio_crypto_pci_realize(VirtIOPCIProxy *vpci_dev, Error **errp)
|
|
{
|
|
VirtIOCryptoPCI *vcrypto = VIRTIO_CRYPTO_PCI(vpci_dev);
|
|
DeviceState *vdev = DEVICE(&vcrypto->vdev);
|
|
|
|
if (vcrypto->vdev.conf.cryptodev == NULL) {
|
|
error_setg(errp, "'cryptodev' parameter expects a valid object");
|
|
return;
|
|
}
|
|
|
|
virtio_pci_force_virtio_1(vpci_dev);
|
|
if (!qdev_realize(vdev, BUS(&vpci_dev->bus), errp)) {
|
|
return;
|
|
}
|
|
object_property_set_link(OBJECT(vcrypto), "cryptodev",
|
|
OBJECT(vcrypto->vdev.conf.cryptodev), NULL);
|
|
}
|
|
|
|
static void virtio_crypto_pci_class_init(ObjectClass *klass, void *data)
|
|
{
|
|
DeviceClass *dc = DEVICE_CLASS(klass);
|
|
VirtioPCIClass *k = VIRTIO_PCI_CLASS(klass);
|
|
PCIDeviceClass *pcidev_k = PCI_DEVICE_CLASS(klass);
|
|
|
|
k->realize = virtio_crypto_pci_realize;
|
|
set_bit(DEVICE_CATEGORY_MISC, dc->categories);
|
|
device_class_set_props(dc, virtio_crypto_pci_properties);
|
|
pcidev_k->class_id = PCI_CLASS_OTHERS;
|
|
}
|
|
|
|
static void virtio_crypto_initfn(Object *obj)
|
|
{
|
|
VirtIOCryptoPCI *dev = VIRTIO_CRYPTO_PCI(obj);
|
|
|
|
virtio_instance_init_common(obj, &dev->vdev, sizeof(dev->vdev),
|
|
TYPE_VIRTIO_CRYPTO);
|
|
}
|
|
|
|
static const VirtioPCIDeviceTypeInfo virtio_crypto_pci_info = {
|
|
.generic_name = TYPE_VIRTIO_CRYPTO_PCI,
|
|
.instance_size = sizeof(VirtIOCryptoPCI),
|
|
.instance_init = virtio_crypto_initfn,
|
|
.class_init = virtio_crypto_pci_class_init,
|
|
};
|
|
|
|
static void virtio_crypto_pci_register_types(void)
|
|
{
|
|
virtio_pci_types_register(&virtio_crypto_pci_info);
|
|
}
|
|
type_init(virtio_crypto_pci_register_types)
|