bd4480b0d0
This reverts commitdecdc76772in full and also the relevant migration-tests from7a09f09283. After the addition of the new QAPI-based migration address API in 8.2 we've been converting an "fd:" URI into a SocketAddress, missing the fact that the "fd:" syntax could also be used for a plain file instead of a socket. This is a problem because the SocketAddress is part of the API, so we're effectively asking users to create a "socket" channel to pass in a plain file. The easiest way to fix this situation is to deprecate the usage of both SocketAddress and "fd:" when used with a plain file for migration. Since this has been possible since 8.2, we can wait until 9.1 to deprecate it. For 9.0, however, we should avoid adding further support to migration to a plain file using the old "fd:" syntax or the new SocketAddress API, and instead require the usage of either the old-style "file:" URI or the FileMigrationArgs::filename field of the new API with the "/dev/fdset/NN" syntax, both of which are already supported. Signed-off-by: Fabiano Rosas <farosas@suse.de> Link: https://lore.kernel.org/r/20240319210941.1907-1-farosas@suse.de Signed-off-by: Peter Xu <peterx@redhat.com>
78 lines
2.0 KiB
C
78 lines
2.0 KiB
C
/*
|
|
* QEMU live migration via generic fd
|
|
*
|
|
* Copyright Red Hat, Inc. 2009-2016
|
|
*
|
|
* Authors:
|
|
* Chris Lalancette <clalance@redhat.com>
|
|
* Daniel P. Berrange <berrange@redhat.com>
|
|
*
|
|
* This work is licensed under the terms of the GNU GPL, version 2. See
|
|
* the COPYING file in the top-level directory.
|
|
*
|
|
* Contributions after 2012-01-13 are licensed under the terms of the
|
|
* GNU GPL, version 2 or (at your option) any later version.
|
|
*/
|
|
|
|
#include "qemu/osdep.h"
|
|
#include "channel.h"
|
|
#include "fd.h"
|
|
#include "file.h"
|
|
#include "migration.h"
|
|
#include "monitor/monitor.h"
|
|
#include "io/channel-util.h"
|
|
#include "trace.h"
|
|
|
|
|
|
void fd_start_outgoing_migration(MigrationState *s, const char *fdname, Error **errp)
|
|
{
|
|
QIOChannel *ioc;
|
|
int fd = monitor_get_fd(monitor_cur(), fdname, errp);
|
|
if (fd == -1) {
|
|
return;
|
|
}
|
|
|
|
trace_migration_fd_outgoing(fd);
|
|
ioc = qio_channel_new_fd(fd, errp);
|
|
if (!ioc) {
|
|
close(fd);
|
|
return;
|
|
}
|
|
|
|
qio_channel_set_name(ioc, "migration-fd-outgoing");
|
|
migration_channel_connect(s, ioc, NULL, NULL);
|
|
object_unref(OBJECT(ioc));
|
|
}
|
|
|
|
static gboolean fd_accept_incoming_migration(QIOChannel *ioc,
|
|
GIOCondition condition,
|
|
gpointer opaque)
|
|
{
|
|
migration_channel_process_incoming(ioc);
|
|
object_unref(OBJECT(ioc));
|
|
return G_SOURCE_REMOVE;
|
|
}
|
|
|
|
void fd_start_incoming_migration(const char *fdname, Error **errp)
|
|
{
|
|
QIOChannel *ioc;
|
|
int fd = monitor_fd_param(monitor_cur(), fdname, errp);
|
|
if (fd == -1) {
|
|
return;
|
|
}
|
|
|
|
trace_migration_fd_incoming(fd);
|
|
|
|
ioc = qio_channel_new_fd(fd, errp);
|
|
if (!ioc) {
|
|
close(fd);
|
|
return;
|
|
}
|
|
|
|
qio_channel_set_name(ioc, "migration-fd-incoming");
|
|
qio_channel_add_watch_full(ioc, G_IO_IN,
|
|
fd_accept_incoming_migration,
|
|
NULL, NULL,
|
|
g_main_context_get_thread_default());
|
|
}
|