mirrors/qemu
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity
qemu/util
History
Emilio Cota 68f7b2be53 util/qht: use striped locks under TSAN 
Fixes this tsan crash, easy to reproduce with any large enough program:

$ tests/unit/test-qht
1..2
ThreadSanitizer: CHECK failed: sanitizer_deadlock_detector.h:67 "((n_all_locks_)) < (((sizeof(all_locks_with_contexts_)/sizeof((all_locks_with_contexts_)[0]))))" (0x40, 0x40) (tid=1821568)
    #0 __tsan::CheckUnwind() ../../../../src/libsanitizer/tsan/tsan_rtl.cpp:353 (libtsan.so.2+0x90034)
    #1 __sanitizer::CheckFailed(char const*, int, char const*, unsigned long long, unsigned long long) ../../../../src/libsanitizer/sanitizer_common/sanitizer_termination.cpp:86 (libtsan.so.2+0xca555)
    #2 __sanitizer::DeadlockDetectorTLS<__sanitizer::TwoLevelBitVector<1ul, __sanitizer::BasicBitVector<unsigned long> > >::addLock(unsigned long, unsigned long, unsigned int) ../../../../src/libsanitizer/sanitizer_common/sanitizer_deadlock_detector.h:67 (libtsan.so.2+0xb3616)
    #3 __sanitizer::DeadlockDetectorTLS<__sanitizer::TwoLevelBitVector<1ul, __sanitizer::BasicBitVector<unsigned long> > >::addLock(unsigned long, unsigned long, unsigned int) ../../../../src/libsanitizer/sanitizer_common/sanitizer_deadlock_detector.h:59 (libtsan.so.2+0xb3616)
    #4 __sanitizer::DeadlockDetector<__sanitizer::TwoLevelBitVector<1ul, __sanitizer::BasicBitVector<unsigned long> > >::onLockAfter(__sanitizer::DeadlockDetectorTLS<__sanitizer::TwoLevelBitVector<1ul, __sanitizer::BasicBitVector<unsigned long> > >*, unsigned long, unsigned int) ../../../../src/libsanitizer/sanitizer_common/sanitizer_deadlock_detector.h:216 (libtsan.so.2+0xb3616)
    #5 __sanitizer::DD::MutexAfterLock(__sanitizer::DDCallback*, __sanitizer::DDMutex*, bool, bool) ../../../../src/libsanitizer/sanitizer_common/sanitizer_deadlock_detector1.cpp:169 (libtsan.so.2+0xb3616)
    #6 __tsan::MutexPostLock(__tsan::ThreadState*, unsigned long, unsigned long, unsigned int, int) ../../../../src/libsanitizer/tsan/tsan_rtl_mutex.cpp:200 (libtsan.so.2+0xa3382)
    #7 __tsan_mutex_post_lock ../../../../src/libsanitizer/tsan/tsan_interface_ann.cpp:384 (libtsan.so.2+0x76bc3)
    #8 qemu_spin_lock /home/cota/src/qemu/include/qemu/thread.h:259 (test-qht+0x44a97)
    #9 qht_map_lock_buckets ../util/qht.c:253 (test-qht+0x44a97)
    #10 do_qht_iter ../util/qht.c:809 (test-qht+0x45f33)
    #11 qht_iter ../util/qht.c:821 (test-qht+0x45f33)
    #12 iter_check ../tests/unit/test-qht.c:121 (test-qht+0xe473)
    #13 qht_do_test ../tests/unit/test-qht.c:202 (test-qht+0xe473)
    #14 qht_test ../tests/unit/test-qht.c:240 (test-qht+0xe7c1)
    #15 test_default ../tests/unit/test-qht.c:246 (test-qht+0xe828)
    #16 <null> <null> (libglib-2.0.so.0+0x7daed)
    #17 <null> <null> (libglib-2.0.so.0+0x7d80a)
    #18 <null> <null> (libglib-2.0.so.0+0x7d80a)
    #19 g_test_run_suite <null> (libglib-2.0.so.0+0x7dfe9)
    #20 g_test_run <null> (libglib-2.0.so.0+0x7e055)
    #21 main ../tests/unit/test-qht.c:259 (test-qht+0xd2c6)
    #22 __libc_start_call_main ../sysdeps/nptl/libc_start_call_main.h:58 (libc.so.6+0x29d8f)
    #23 __libc_start_main_impl ../csu/libc-start.c:392 (libc.so.6+0x29e3f)
    #24 _start <null> (test-qht+0xdb44)

Signed-off-by: Emilio Cota <cota@braap.org>
Reviewed-by: Richard Henderson <richard.henderson@linaro.org>
Message-Id: <20230111151628.320011-5-cota@braap.org>
Signed-off-by: Alex Bennée <alex.bennee@linaro.org>
Message-Id: <20230124180127.1881110-30-alex.bennee@linaro.org>
2023-02-02 11:48:20 +00:00
..
aio-posix.c
util/aio: Defer disabling poll mode as long as possible
2023-01-23 15:01:22 -05:00
aio-posix.h
…
aio-wait.c
aio_wait_kick: add missing memory barrier
2022-06-24 17:07:06 +02:00
aio-win32.c
util/aio-win32: Correct the event array size in aio_poll()
2022-11-06 09:48:26 +01:00
aiocb.c
…
async-teardown.c
os-posix: asynchronous teardown for shutdown on Linux
2022-10-31 09:46:34 +01:00
async.c
coroutine: Use Coroutine typedef name instead of structure tag
2023-01-20 07:23:45 +01:00
atomic64.c
…
base64.c
…
bitmap.c
migration: Use non-atomic ops for clear log bitmap
2022-11-21 11:58:10 +01:00
bitops.c
…
block-helpers.c
…
block-helpers.h
…
buffer.c
…
bufferiszero.c
util/bufferiszero: Use __attribute__((target)) for avx2/avx512
2023-01-16 10:14:12 -10:00
cacheflush.c
util/cacheflush: Optimize flushing when ppc host has coherent icache
2022-06-21 09:28:41 -07:00
compatfd.c
…
coroutine-sigaltstack.c
…
coroutine-ucontext.c
…
coroutine-win32.c
…
crc32c.c
…
crc-ccitt.c
…
cutils.c
util: remove support for hex numbers with a scaling suffix
2023-01-06 00:51:02 +01:00
dbus.c
…
drm.c
…
envlist.c
…
error-report.c
util/error: add G_GNUC_PRINTF for various functions
2023-01-11 10:44:34 +01:00
error.c
util/error: add G_GNUC_PRINTF for various functions
2023-01-11 10:44:34 +01:00
event_notifier-posix.c
…
event_notifier-win32.c
…
fdmon-epoll.c
…
fdmon-io_uring.c
…
fdmon-poll.c
…
fifo8.c
…
filemonitor-inotify.c
…
filemonitor-stub.c
…
getauxval.c
…
guest-random.c
…
hbitmap.c
block: simplify handling of try to merge different sized bitmaps
2022-06-24 17:07:06 +02:00
hexdump.c
…
host-utils.c
host-utils: Implemented signed 256-by-128 division
2022-06-20 08:38:58 -03:00
id.c
…
int128.c
…
interval-tree.c
util: Add interval-tree.c
2022-12-20 17:09:41 -08:00
iov.c
util: make do_send_recv work with partial send/recv
2022-10-12 19:22:01 +04:00
iova-tree.c
util: accept iova_tree_remove_parameter by value
2022-09-02 10:22:39 +08:00
keyval.c
…
lockcnt.c
…
log.c
util/log: Always send errors to logfile when daemonized
2023-01-06 00:50:32 +01:00
main-loop.c
error handling: Use RETRY_ON_EINTR() macro where applicable
2023-01-09 13:50:47 +01:00
memalign.c
…
memfd.c
…
meson.build
accel: introduce accelerator blocker API
2023-01-11 09:59:39 +01:00
mmap-alloc.c
util/mmap-alloc: Remove qemu_mempath_getpagesize()
2022-08-26 13:34:21 +02:00
module.c
module: add Error arguments to module_load and module_load_qom
2022-11-06 09:48:50 +01:00
notify.c
…
nvdimm-utils.c
…
osdep.c
error handling: Use RETRY_ON_EINTR() macro where applicable
2023-01-09 13:50:47 +01:00
oslib-posix.c
util: Make qemu_prealloc_mem() optionally consume a ThreadContext
2022-10-27 11:00:56 +02:00
oslib-win32.c
util/oslib-win32: Remove obsolete reference to g_poll code
2022-12-15 15:19:24 +01:00
path.c
…
qdist.c
…
qemu-co-shared-resource.c
…
qemu-co-timeout.c
util: add qemu-co-timeout
2022-06-29 10:56:12 +03:00
qemu-config.c
util/qemu-config: Fix "query-command-line-options" to provide the right values
2022-12-15 15:19:23 +01:00
qemu-coroutine-io.c
…
qemu-coroutine-lock.c
coroutine: Clean up superfluous inclusion of qemu/coroutine.h
2023-01-19 10:18:28 +01:00
qemu-coroutine-sleep.c
coroutine: Clean up superfluous inclusion of qemu/coroutine.h
2023-01-19 10:18:28 +01:00
qemu-coroutine.c
coroutine: Clean up superfluous inclusion of qemu/coroutine.h
2023-01-19 10:18:28 +01:00
qemu-option.c
…
qemu-print.c
…
qemu-progress.c
…
qemu-sockets.c
sockets: Use ERRP_GUARD() where obviously appropriate
2022-12-14 16:19:35 +01:00
qemu-thread-common.h
…
qemu-thread-posix.c
util: Introduce qemu_thread_set_affinity() and qemu_thread_get_affinity()
2022-10-27 11:00:36 +02:00
qemu-thread-win32.c
util: Introduce qemu_thread_set_affinity() and qemu_thread_get_affinity()
2022-10-27 11:00:36 +02:00
qemu-timer-common.c
…
qemu-timer.c
qemu-timer: Skip empty timer lists before locking in qemu_clock_deadline_ns_all
2022-06-21 09:24:34 -07:00
qht.c
util/qht: use striped locks under TSAN
2023-02-02 11:48:20 +00:00
qsp.c
…
range.c
…
rcu.c
…
readline.c
…
selfmap.c
…
stats64.c
…
sys_membarrier.c
…
systemd.c
…
thread-context.c
qapi: Use returned bool to check for failure (again)
2022-12-14 16:19:35 +01:00
thread-pool.c
thread-pool: remove stopping variable
2022-05-25 21:26:26 +02:00
throttle.c
…
timed-average.c
…
trace-events
…
trace.h
…
transactions.c
…
unicode.c
…
uri.c
…
userfaultfd.c
…
uuid.c
…
vfio-helpers.c
error handling: Use RETRY_ON_EINTR() macro where applicable
2023-01-09 13:50:47 +01:00
vhost-user-server.c
…
yank.c
…