qemu/hw/scsi
Markus Armbruster 9b3d111ad9 hw: Propagate errors through qdev_prop_set_drive()
Three kinds of callers:

1. On failure, report the error and abort

   Passing &error_abort does the job.  No functional change.

2. On failure, report the error and exit()

   This is qdev_prop_set_drive_nofail().  Error reporting moves from
   qdev_prop_set_drive() to its caller.  Because hiding away the error
   in the monitor right before exit() isn't helpful, replace
   qerror_report_err() by error_report_err().  Shouldn't make a
   difference, because qdev_prop_set_drive_nofail() should never be
   used in QMP context.

3. On failure, report the error and recover

   This is usb_msd_init() and scsi_bus_legacy_add_drive().  Error
   reporting and freeing the error object moves from
   qdev_prop_set_drive() to its callers.

   Because usb_msd_init() can't run in QMP context, replace
   qerror_report_err() by error_report_err() there.

   No functional change.

   scsi_bus_legacy_add_drive() calling qerror_report_err() is of
   course inappropriate, but this commit merely makes it more obvious.
   The next one will clean it up.

Signed-off-by: Markus Armbruster <armbru@redhat.com>
Reviewed-by: Peter Crosthwaite <peter.crosthwaite@xilinx.com>
Message-Id: <1425925048-15482-3-git-send-email-armbru@redhat.com>
Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
2015-03-10 11:18:23 +01:00
..
esp-pci.c scsi: Clean up duplicated error in legacy if=scsi code 2015-03-10 11:18:23 +01:00
esp.c esp: Do not overwrite ESP_TCHI after reset 2014-11-12 10:27:03 +01:00
lsi53c895a.c scsi: Clean up duplicated error in legacy if=scsi code 2015-03-10 11:18:23 +01:00
Makefile.objs virtio-scsi-dataplane: Code to run virtio-scsi on iothread 2014-09-30 11:11:20 +02:00
megasas.c scsi: Clean up duplicated error in legacy if=scsi code 2015-03-10 11:18:23 +01:00
mfi.h megasas: add MegaRAID SAS 2108 emulation 2014-10-31 11:29:00 +01:00
scsi-bus.c hw: Propagate errors through qdev_prop_set_drive() 2015-03-10 11:18:23 +01:00
scsi-disk.c scsi-disk: provide maximum transfer length 2014-12-15 12:21:02 +01:00
scsi-generic.c scsi: Drop superfluous conditionals around g_free() 2014-12-15 12:21:02 +01:00
spapr_vscsi.c spapr_vio: Convert to realize() 2015-03-09 15:00:07 +01:00
srp.h spapr-vscsi: add task management 2013-09-12 08:46:21 +02:00
vhost-scsi.c Clean up around error_get_pretty(), qerror_report_err() 2015-02-26 07:01:08 +00:00
viosrp.h hw: move private headers to hw/ subdirectories. 2013-04-08 18:13:16 +02:00
virtio-scsi-dataplane.c virtio-scsi: Allocate op blocker reason before blocking 2015-03-02 10:57:07 +01:00
virtio-scsi.c pci, pc, virtio fixes and cleanups 2015-03-09 09:14:28 +00:00
vmw_pvscsi.c scsi: Convert pvscsi HBA to hotplug handler API 2014-10-15 05:03:14 +02:00
vmw_pvscsi.h scsi: VMWare PVSCSI paravirtual device implementation 2013-04-19 10:44:17 +02:00