Go to file
Daniel P. Berrangé 950c4e6c94 opts: don't silently truncate long option values
The existing QemuOpts parsing code uses a fixed size 1024 byte buffer
for storing the option values. If a value exceeded this size it was
silently truncated and no error reported to the user. Long option values
is not a common scenario, but it is conceivable that they will happen.
eg if the user has a very deeply nested filesystem it would be possible
to come up with a disk path that was > 1024 bytes. Most of the time if
such data was silently truncated, the user would get an error about
opening a non-existant disk. If they're unlucky though, QEMU might use a
completely different disk image from another VM, which could be
considered a security issue. Another example program was in using the
-smbios command line arg with very large data blobs. In this case the
silent truncation will be providing semantically incorrect data to the
guest OS for SMBIOS tables.

If the operating system didn't limit the user's argv when spawning QEMU,
the code should honour whatever length arguments were given without
imposing its own length restrictions. This patch thus changes the code
to use a heap allocated buffer for storing the values during parsing,
lifting the arbitrary length restriction.

Signed-off-by: Daniel P. Berrangé <berrange@redhat.com>
Message-Id: <20180416111743.8473-4-berrange@redhat.com>
Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
Signed-off-by: Daniel P. Berrangé <berrange@redhat.com>
2018-05-09 00:13:39 +02:00
accel accel: use g_strsplit for parsing accelerator names 2018-05-09 00:13:38 +02:00
audio audio/sdl: build as module 2018-03-12 11:18:27 +01:00
backends memdev: remove "id" property 2018-05-09 00:13:37 +02:00
block nbd patches for 2018-05-04 2018-05-04 14:42:46 +01:00
bsd-user Use cpu_create(type) instead of cpu_init(cpu_model) 2018-03-19 14:10:36 -03:00
capstone@22ead3e0bf disas: Add capstone as submodule 2017-10-26 11:56:20 +02:00
chardev Revert "mux: fix ctrl-a b again" 2018-04-17 21:11:30 +01:00
contrib contrib/libvhost-user: add the protocol feature used for SET/GET message 2018-04-09 17:35:46 +03:00
crypto Include less of the generated modular QAPI headers 2018-03-02 13:45:50 -06:00
default-configs hw/arm/smmu-common: smmu base device and datatypes 2018-05-04 18:05:51 +01:00
disas RISC-V: Fix missing break statement in disassembler 2018-05-06 10:39:38 +12:00
docs qobject: Replace qobject_incref/QINCREF qobject_decref/QDECREF 2018-05-04 08:27:53 +02:00
dtc@e54388015a Update dtc to fix compilation problem on Mac OS 10.6 2018-01-10 12:53:00 +11:00
fpu fpu: Bound increment for scalbn 2018-04-17 14:52:38 +01:00
fsdev use g_path_get_basename instead of basename 2018-03-06 14:01:29 +01:00
gdb-xml s390x/gdb: add gs registers 2017-07-14 12:29:49 +02:00
hw opts: don't silently truncate long option values 2018-05-09 00:13:39 +02:00
include opts: don't silently truncate long option values 2018-05-09 00:13:39 +02:00
io error: Remove NULL checks on error_propagate() calls 2018-03-27 10:17:32 -05:00
libdecnumber build: remove CONFIG_LIBDECNUMBER 2017-10-16 18:03:52 +02:00
linux-headers include: add psp-sev.h header file 2018-03-13 12:04:03 +01:00
linux-user linux-user: remove useless padding in flock64 structure 2018-05-03 18:40:19 +02:00
migration nbd patches for 2018-05-04 2018-05-04 14:42:46 +01:00
nbd nbd/client: Fix error messages during NBD_INFO_BLOCK_SIZE 2018-05-04 08:23:37 -05:00
net net/vde: print error on vde_open() failure 2018-03-26 14:52:43 +08:00
pc-bios pc-bios/s390: Update firmware images 2018-05-02 15:42:57 +02:00
po po: add missing translations in de, fr, it, zh 2016-12-14 18:47:19 +00:00
qapi qapi: deprecate CpuInfoFast.arch 2018-05-04 08:27:53 +02:00
qga qobject: Replace qobject_incref/QINCREF qobject_decref/QDECREF 2018-05-04 08:27:53 +02:00
qobject qobject: Modify qobject_ref() to return obj 2018-05-04 08:27:53 +02:00
qom memdev: remove "id" property 2018-05-09 00:13:37 +02:00
replay replay: save vmstate of the asynchronous events 2018-03-12 17:10:38 +01:00
roms roms/u-boot-sam460ex: Change to qemu git mirror and update 2018-04-10 10:05:38 +10:00
scripts update-linux-headers: drop hyperv.h 2018-05-09 00:13:38 +02:00
scsi qemu-pr-helper: Write pidfile more often 2018-04-09 16:36:40 +02:00
slirp slirp: add in6_dhcp_multicast() 2018-01-14 18:16:13 +01:00
stubs pc-dimm: factor out MemoryDevice interface 2018-05-07 10:00:02 -03:00
target RISC-V: QEMU 2.13 Privileged ISA emulation updates 2018-05-08 13:34:03 +01:00
tcg tcg: workaround branch instruction overflow in tcg_out_qemu_ld/st 2018-05-01 11:56:55 -07:00
tests opts: don't silently truncate long parameter keys 2018-05-09 00:13:39 +02:00
trace Include less of the generated modular QAPI headers 2018-03-02 13:45:50 -06:00
ui console: introduce dpy_gfx_update_full 2018-04-27 11:36:34 +02:00
util opts: don't silently truncate long option values 2018-05-09 00:13:39 +02:00
.dir-locals.el Add .dir-locals.el file to configure emacs coding style 2015-10-08 19:46:01 +03:00
.editorconfig add editorconfig 2017-07-20 09:56:56 +02:00
.exrc
.gdbinit .gdbinit: load QEMU sub-commands when gdb starts 2017-06-07 14:38:45 +01:00
.gitignore qapi: Don't create useless directory qapi-generated 2018-03-02 13:48:26 -06:00
.gitmodules roms/u-boot-sam460ex: Change to qemu git mirror and update 2018-04-10 10:05:38 +10:00
.gitpublish Add a git-publish configuration file 2018-03-05 09:03:17 +00:00
.mailmap maint: Add .mailmap entries for patches claiming list authorship 2018-04-09 16:36:40 +02:00
.shippable.yml .shippable.yml: disable powerpc-cross image 2018-03-08 14:34:41 +00:00
.travis.yml .travis.yml: add --disable-user with the rest of the disables 2018-03-13 16:22:23 +00:00
arch_init.c qapi: change the type of TargetInfo.arch from string to enum SysEmuTarget 2018-05-04 08:27:53 +02:00
balloon.c qapi: Empty out qapi-schema.json 2018-03-02 13:45:50 -06:00
block.c qobject: Modify qobject_ref() to return obj 2018-05-04 08:27:53 +02:00
blockdev-nbd.c Include less of the generated modular QAPI headers 2018-03-02 13:45:50 -06:00
blockdev.c qobject: Replace qobject_incref/QINCREF qobject_decref/QDECREF 2018-05-04 08:27:53 +02:00
blockjob.c blockjob: use qapi enum helpers 2018-04-03 09:56:55 -04:00
bootdevice.c Makefile: Move bootdevice.o to common-obj-y 2017-07-04 14:39:27 +02:00
bt-host.c all: Clean up includes 2016-02-04 17:41:30 +00:00
bt-vhci.c all: Clean up includes 2016-02-04 17:41:30 +00:00
Changelog Use HTTPS for qemu.org and other domains 2017-11-21 13:34:13 +00:00
CODING_STYLE coding_style: add point about 0x in trace-events 2017-08-01 12:13:07 +01:00
configure configure: recognize more rpmbuild macros 2018-05-09 00:13:35 +02:00
COPYING
COPYING.LIB
COPYING.PYTHON scripts: add argparse module for Python 2.6 compatibility 2017-08-30 12:02:11 +01:00
cpus-common.c *_run_on_cpu: introduce run_on_cpu_data type 2016-10-31 15:00:25 +01:00
cpus.c cpus: tcg: fix never exiting loop on unplug 2018-05-09 00:13:37 +02:00
device_tree.c device_tree: Increase FDT_MAX_SIZE to 1 MiB 2018-04-26 11:04:38 +01:00
device-hotplug.c Move include qemu/option.h from qemu-common.h to actual users 2018-02-09 13:52:16 +01:00
disas.c RISC-V Disassembler 2018-03-07 08:30:28 +13:00
dma-helpers.c block: explicitly acquire aiocontext in bottom halves that need it 2017-02-21 11:39:39 +00:00
dump.c dump: Fix build with newer gcc 2018-04-09 16:36:40 +02:00
exec.c exec: reintroduce MemoryRegion caching 2018-05-09 00:13:38 +02:00
gdbstub.c gdbstub: fix off-by-one in gdb_handle_packet() 2018-04-09 14:18:39 +01:00
HACKING HACKING: document #include order 2017-01-03 16:38:47 +00:00
hmp-commands-info.hx sev/i386: hmp: add 'info sev' command 2018-03-13 17:36:05 +01:00
hmp-commands.hx block/mirror: change the semantic of 'force' of block-job-cancel 2018-03-19 12:01:39 +01:00
hmp.c migration: add postcopy total blocktime into query-migrate 2018-04-25 18:02:17 +01:00
hmp.h sev/i386: hmp: add 'info sev' command 2018-03-13 17:36:05 +01:00
ioport.c trace: switch to modular code generation for sub-directories 2017-01-31 17:11:18 +00:00
iothread.c iothread: workaround glib bug which hangs qmp-test 2018-04-10 07:43:52 -05:00
LICENSE
MAINTAINERS MAINTAINERS: update Marcel Apfelbaum email 2018-05-03 20:52:29 +03:00
Makefile Makefile: install gtk message catalogs if CONFIG_GTK=y too, not only =m 2018-04-16 16:25:24 +01:00
Makefile.objs build: enable audio modules 2018-03-12 11:18:27 +01:00
Makefile.target make: switch from -I to -iquote 2018-03-23 18:38:55 +03:00
memory_ldst.inc.c exec: move memory access declarations to a common header, inline *_phys functions 2018-05-09 00:13:38 +02:00
memory_mapping.c Replace all occurances of __FUNCTION__ with __func__ 2018-01-22 09:46:18 +01:00
memory.c exec: reintroduce MemoryRegion caching 2018-05-09 00:13:38 +02:00
module-common.c all: Clean up includes 2016-02-04 17:41:30 +00:00
monitor.c qobject: Modify qobject_ref() to return obj 2018-05-04 08:27:53 +02:00
numa.c memdev: remove "id" property 2018-05-09 00:13:37 +02:00
os-posix.c os-posix: cleanup: Replace perror with error_report 2018-04-26 16:29:51 +01:00
os-win32.c shutdown: Add source information to SHUTDOWN and RESET 2017-05-23 13:28:17 +02:00
qdev-monitor.c qom: introduce object_class_get_list_sorted 2018-03-12 15:21:10 +01:00
qdict-test-data.txt
qemu-bridge-helper.c all: Remove unnecessary glib.h includes 2016-06-07 18:19:24 +03:00
qemu-doc.texi qapi: deprecate CpuInfoFast.arch 2018-05-04 08:27:53 +02:00
qemu-ga.texi qemu-ga: Remove stray 'q' in documentation 2016-10-28 18:17:23 +03:00
qemu-img-cmds.hx qemu-img: add --shrink flag for resize 2017-09-26 15:00:32 +02:00
qemu-img.c qobject: Replace qobject_incref/QINCREF qobject_decref/QDECREF 2018-05-04 08:27:53 +02:00
qemu-img.texi qemu-img: Document --force-share / -U 2018-02-13 12:27:17 +01:00
qemu-io-cmds.c Move include qemu/option.h from qemu-common.h to actual users 2018-02-09 13:52:16 +01:00
qemu-io.c qobject: Replace qobject_incref/QINCREF qobject_decref/QDECREF 2018-05-04 08:27:53 +02:00
qemu-keymap.c Drop superfluous includes of qapi-types.h and test-qapi-types.h 2018-02-09 05:05:11 +01:00
qemu-nbd.c Polish the version strings containing the package version 2018-03-12 16:12:47 +01:00
qemu-nbd.texi nbd: Add qemu-nbd -D for human-readable description 2016-11-02 09:28:55 +01:00
qemu-option-trace.texi docs: update manpage for stderr->log rename 2017-02-13 13:38:31 +00:00
qemu-options-wrapper.h qemu-options: Remove stray colons from output of --help 2017-12-20 09:04:27 +01:00
qemu-options.h Clean up ill-advised or unusual header guards 2016-07-12 16:20:46 +02:00
qemu-options.hx vnc: fix use-after-free. 2018-04-27 11:39:31 +01:00
qemu-seccomp.c seccomp: add resourcecontrol argument to command line 2017-09-15 10:15:06 +02:00
qemu-tech.texi qemu-doc: merge qemu-tech and qemu-doc 2016-10-07 10:05:54 +02:00
qemu.nsi Use HTTPS for qemu.org and other domains 2017-11-21 13:34:13 +00:00
qemu.sasl Default to GSSAPI (Kerberos) instead of DIGEST-MD5 for SASL 2017-05-09 14:41:47 +01:00
qmp.c pc-dimm: factor out MemoryDevice interface 2018-05-07 10:00:02 -03:00
qtest.c qtest: Don't perform side effects inside assertion 2017-09-15 09:05:19 +02:00
README README: Fix typo 'git-publish' 2018-03-08 15:45:14 +00:00
replication.c replication: Introduce new APIs to do replication operation 2016-09-13 11:00:56 +01:00
replication.h block/replication: Remove protocol_name field 2018-03-26 12:16:00 +02:00
rules.mak make: switch from -I to -iquote 2018-03-23 18:38:55 +03:00
thunk.c thunk: assert nb_fields is valid 2017-07-31 13:06:39 +03:00
tpm.c qapi: Move qapi-schema.json to qapi/, rename generated files 2018-03-02 13:45:57 -06:00
trace-events virtio,vhost,pci,pc: features, cleanups 2018-03-20 15:48:34 +00:00
VERSION Open 2.13 development tree 2018-04-26 11:48:27 +01:00
version.rc Use HTTPS for qemu.org and other domains 2017-11-21 13:34:13 +00:00
vl.c vl: allow 'maxmem' without 'slot' 2018-05-07 10:00:02 -03:00

         QEMU README
         ===========

QEMU is a generic and open source machine & userspace emulator and
virtualizer.

QEMU is capable of emulating a complete machine in software without any
need for hardware virtualization support. By using dynamic translation,
it achieves very good performance. QEMU can also integrate with the Xen
and KVM hypervisors to provide emulated hardware while allowing the
hypervisor to manage the CPU. With hypervisor support, QEMU can achieve
near native performance for CPUs. When QEMU emulates CPUs directly it is
capable of running operating systems made for one machine (e.g. an ARMv7
board) on a different machine (e.g. an x86_64 PC board).

QEMU is also capable of providing userspace API virtualization for Linux
and BSD kernel interfaces. This allows binaries compiled against one
architecture ABI (e.g. the Linux PPC64 ABI) to be run on a host using a
different architecture ABI (e.g. the Linux x86_64 ABI). This does not
involve any hardware emulation, simply CPU and syscall emulation.

QEMU aims to fit into a variety of use cases. It can be invoked directly
by users wishing to have full control over its behaviour and settings.
It also aims to facilitate integration into higher level management
layers, by providing a stable command line interface and monitor API.
It is commonly invoked indirectly via the libvirt library when using
open source applications such as oVirt, OpenStack and virt-manager.

QEMU as a whole is released under the GNU General Public License,
version 2. For full licensing details, consult the LICENSE file.


Building
========

QEMU is multi-platform software intended to be buildable on all modern
Linux platforms, OS-X, Win32 (via the Mingw64 toolchain) and a variety
of other UNIX targets. The simple steps to build QEMU are:

  mkdir build
  cd build
  ../configure
  make

Additional information can also be found online via the QEMU website:

  https://qemu.org/Hosts/Linux
  https://qemu.org/Hosts/Mac
  https://qemu.org/Hosts/W32


Submitting patches
==================

The QEMU source code is maintained under the GIT version control system.

   git clone git://git.qemu.org/qemu.git

When submitting patches, one common approach is to use 'git
format-patch' and/or 'git send-email' to format & send the mail to the
qemu-devel@nongnu.org mailing list. All patches submitted must contain
a 'Signed-off-by' line from the author. Patches should follow the
guidelines set out in the HACKING and CODING_STYLE files.

Additional information on submitting patches can be found online via
the QEMU website

  https://qemu.org/Contribute/SubmitAPatch
  https://qemu.org/Contribute/TrivialPatches

The QEMU website is also maintained under source control.

  git clone git://git.qemu.org/qemu-web.git
  https://www.qemu.org/2017/02/04/the-new-qemu-website-is-up/

A 'git-publish' utility was created to make above process less
cumbersome, and is highly recommended for making regular contributions,
or even just for sending consecutive patch series revisions. It also
requires a working 'git send-email' setup, and by default doesn't
automate everything, so you may want to go through the above steps
manually for once.

For installation instructions, please go to

  https://github.com/stefanha/git-publish

The workflow with 'git-publish' is:

  $ git checkout master -b my-feature
  $ # work on new commits, add your 'Signed-off-by' lines to each
  $ git publish

Your patch series will be sent and tagged as my-feature-v1 if you need to refer
back to it in the future.

Sending v2:

  $ git checkout my-feature # same topic branch
  $ # making changes to the commits (using 'git rebase', for example)
  $ git publish

Your patch series will be sent with 'v2' tag in the subject and the git tip
will be tagged as my-feature-v2.

Bug reporting
=============

The QEMU project uses Launchpad as its primary upstream bug tracker. Bugs
found when running code built from QEMU git or upstream released sources
should be reported via:

  https://bugs.launchpad.net/qemu/

If using QEMU via an operating system vendor pre-built binary package, it
is preferable to report bugs to the vendor's own bug tracker first. If
the bug is also known to affect latest upstream code, it can also be
reported via launchpad.

For additional information on bug reporting consult:

  https://qemu.org/Contribute/ReportABug


Contact
=======

The QEMU community can be contacted in a number of ways, with the two
main methods being email and IRC

 - qemu-devel@nongnu.org
   https://lists.nongnu.org/mailman/listinfo/qemu-devel
 - #qemu on irc.oftc.net

Information on additional methods of contacting the community can be
found online via the QEMU website:

  https://qemu.org/Contribute/StartHere

-- End