75e972dab5
As a rule, CPU internal state should never be updated when !cpu->kvm_vcpu_dirty (or the HAX equivalent). If that is done, then subsequent calls to cpu_synchronize_state() - usually safe and idempotent - will clobber state. However, we routinely do this during a loadvm or incoming migration. Usually this is called shortly after a reset, which will clear all the cpu dirty flags with cpu_synchronize_all_post_reset(). Nothing is expected to set the dirty flags again before the cpu state is loaded from the incoming stream. This means that it isn't safe to call cpu_synchronize_state() from a post_load handler, which is non-obvious and potentially inconvenient. We could cpu_synchronize_all_state() before the loadvm, but that would be overkill since a) we expect the state to already be synchronized from the reset and b) we expect to completely rewrite the state with a call to cpu_synchronize_all_post_init() at the end of qemu_loadvm_state(). To clear this up, this patch introduces cpu_synchronize_pre_loadvm() and associated helpers, which simply marks the cpu state as dirty without actually changing anything. i.e. it says we want to discard any existing KVM (or HAX) state and replace it with what we're going to load. Cc: Juan Quintela <quintela@redhat.com> Cc: Dave Gilbert <dgilbert@redhat.com> Signed-off-by: David Gibson <david@gibson.dropbear.id.au> Reviewed-by: Juan Quintela <quintela@redhat.com>
58 lines
1.3 KiB
C
58 lines
1.3 KiB
C
/*
|
|
* QEMU HAXM support
|
|
*
|
|
* Copyright IBM, Corp. 2008
|
|
*
|
|
* Authors:
|
|
* Anthony Liguori <aliguori@us.ibm.com>
|
|
*
|
|
* Copyright (c) 2011 Intel Corporation
|
|
* Written by:
|
|
* Jiang Yunhong<yunhong.jiang@intel.com>
|
|
* Xin Xiaohui<xiaohui.xin@intel.com>
|
|
* Zhang Xiantao<xiantao.zhang@intel.com>
|
|
*
|
|
* Copyright 2016 Google, Inc.
|
|
*
|
|
* This work is licensed under the terms of the GNU GPL, version 2 or later.
|
|
* See the COPYING file in the top-level directory.
|
|
*
|
|
*/
|
|
|
|
#ifndef QEMU_HAX_H
|
|
#define QEMU_HAX_H
|
|
|
|
#include "config-host.h"
|
|
#include "qemu-common.h"
|
|
|
|
int hax_sync_vcpus(void);
|
|
int hax_init_vcpu(CPUState *cpu);
|
|
int hax_smp_cpu_exec(CPUState *cpu);
|
|
int hax_populate_ram(uint64_t va, uint32_t size);
|
|
|
|
void hax_cpu_synchronize_state(CPUState *cpu);
|
|
void hax_cpu_synchronize_post_reset(CPUState *cpu);
|
|
void hax_cpu_synchronize_post_init(CPUState *cpu);
|
|
void hax_cpu_synchronize_pre_loadvm(CPUState *cpu);
|
|
|
|
#ifdef CONFIG_HAX
|
|
|
|
int hax_enabled(void);
|
|
|
|
#include "hw/hw.h"
|
|
#include "qemu/bitops.h"
|
|
#include "exec/memory.h"
|
|
int hax_vcpu_destroy(CPUState *cpu);
|
|
void hax_raise_event(CPUState *cpu);
|
|
void hax_reset_vcpu_state(void *opaque);
|
|
#include "target/i386/hax-interface.h"
|
|
#include "target/i386/hax-i386.h"
|
|
|
|
#else /* CONFIG_HAX */
|
|
|
|
#define hax_enabled() (0)
|
|
|
|
#endif /* CONFIG_HAX */
|
|
|
|
#endif /* QEMU_HAX_H */
|