Go to file
Kevin Wolf 90042c6aac test-replication: Lock AioContext around blk_unref()
Recently, the test case has started failing because some job related
functions want to drop the AioContext lock even though it hasn't been
taken:

    (gdb) bt
    #0  0x00007f51c067c9fb in raise () from /lib64/libc.so.6
    #1  0x00007f51c067e77d in abort () from /lib64/libc.so.6
    #2  0x0000558c9d5dde7b in error_exit (err=<optimized out>, msg=msg@entry=0x558c9d6fe120 <__func__.18373> "qemu_mutex_unlock_impl") at util/qemu-thread-posix.c:36
    #3  0x0000558c9d6b5263 in qemu_mutex_unlock_impl (mutex=mutex@entry=0x558c9f3999a0, file=file@entry=0x558c9d6fd36f "util/async.c", line=line@entry=516) at util/qemu-thread-posix.c:96
    #4  0x0000558c9d6b0565 in aio_context_release (ctx=ctx@entry=0x558c9f399940) at util/async.c:516
    #5  0x0000558c9d5eb3da in job_completed_txn_abort (job=0x558c9f68e640) at job.c:738
    #6  0x0000558c9d5eb227 in job_finish_sync (job=0x558c9f68e640, finish=finish@entry=0x558c9d5eb8d0 <job_cancel_err>, errp=errp@entry=0x0) at job.c:986
    #7  0x0000558c9d5eb8ee in job_cancel_sync (job=<optimized out>) at job.c:941
    #8  0x0000558c9d64d853 in replication_close (bs=<optimized out>) at block/replication.c:148
    #9  0x0000558c9d5e5c9f in bdrv_close (bs=0x558c9f41b020) at block.c:3420
    #10 bdrv_delete (bs=0x558c9f41b020) at block.c:3629
    #11 bdrv_unref (bs=0x558c9f41b020) at block.c:4685
    #12 0x0000558c9d62a3f3 in blk_remove_bs (blk=blk@entry=0x558c9f42a7c0) at block/block-backend.c:783
    #13 0x0000558c9d62a667 in blk_delete (blk=0x558c9f42a7c0) at block/block-backend.c:402
    #14 blk_unref (blk=0x558c9f42a7c0) at block/block-backend.c:457
    #15 0x0000558c9d5dfcea in test_secondary_stop () at tests/test-replication.c:478
    #16 0x00007f51c1f13178 in g_test_run_suite_internal () from /lib64/libglib-2.0.so.0
    #17 0x00007f51c1f1337b in g_test_run_suite_internal () from /lib64/libglib-2.0.so.0
    #18 0x00007f51c1f1337b in g_test_run_suite_internal () from /lib64/libglib-2.0.so.0
    #19 0x00007f51c1f13552 in g_test_run_suite () from /lib64/libglib-2.0.so.0
    #20 0x00007f51c1f13571 in g_test_run () from /lib64/libglib-2.0.so.0
    #21 0x0000558c9d5de31f in main (argc=<optimized out>, argv=<optimized out>) at tests/test-replication.c:581

It is yet unclear whether this should really be considered a bug in the
test case or whether blk_unref() should work for callers that haven't
taken the AioContext lock, but in order to fix the build tests quickly,
just take the AioContext lock around blk_unref().

Signed-off-by: Kevin Wolf <kwolf@redhat.com>
2018-10-01 19:13:55 +02:00
accel qht: drop ht argument from qht iterators 2018-09-26 08:55:54 -07:00
audio audio: add audio timer trace points 2018-07-03 11:46:47 +02:00
backends hostmem-file: add the 'pmem' option 2018-08-10 13:29:39 +03:00
block block-backend: Set werror/rerror defaults in blk_new() 2018-10-01 19:13:46 +02:00
bsd-user bsd-user: Use the IEC binary prefix definitions 2018-07-02 15:41:18 +02:00
capstone@22ead3e0bf disas: Add capstone as submodule 2017-10-26 11:56:20 +02:00
chardev qemu-char: check errno together with ret < 0 2018-07-06 18:39:19 +02:00
contrib vhost-blk: turn on pre-defined RO feature bit 2018-06-01 19:20:38 +03:00
crypto crypto: Implement TLS Pre-Shared Keys (PSK). 2018-07-03 13:04:38 +01:00
default-configs arm: Add Nordic Semiconductor nRF51 SoC 2018-09-25 14:14:07 +01:00
disas fix "Missing break in switch" coverity reports 2018-08-23 13:32:50 +02:00
docs qcow2: Fix cache-clean-interval documentation 2018-10-01 19:13:55 +02:00
dtc@e54388015a Update dtc to fix compilation problem on Mac OS 10.6 2018-01-10 12:53:00 +11:00
fpu softfloat: Add scaling float-to-int routines 2018-08-24 13:17:30 +01:00
fsdev fsdev: fix compilation with VIRTIO but not VIRTIO_9P 2018-08-22 12:21:13 +02:00
gdb-xml s390x/gdb: add gs registers 2017-07-14 12:29:49 +02:00
hw - Deprecate the usage of a network backend via "name" instead of "id" 2018-09-25 18:09:52 +01:00
include include: Add a lookup table of sizes 2018-10-01 12:51:12 +02:00
io Delete AF_UNIX socket after close 2018-06-28 13:36:59 +01:00
libdecnumber build: remove CONFIG_LIBDECNUMBER 2017-10-16 18:03:52 +02:00
linux-headers linux-headers: update 2018-08-20 14:18:49 +02:00
linux-user - some fixes for setrlimit() and write() 2018-09-28 11:22:36 +01:00
migration migration/ram.c: Avoid taking address of fields in packed MultiFDInit_t struct 2018-09-26 17:29:01 +01:00
nbd nbd/server: fix nbd_co_send_block_status 2018-07-07 20:30:09 -05:00
net net/slirp: Deprecate the [hub_id name] parameter tuple 2018-09-25 17:26:17 +02:00
pc-bios trivial: Make bios files and source files non-executable 2018-09-25 17:26:18 +02:00
po po: Don't include comments with location 2018-07-23 10:50:54 +01:00
qapi qcow2: Fix cache-clean-interval documentation 2018-10-01 19:13:55 +02:00
qga json: Clean up headers 2018-08-24 20:26:37 +02:00
qobject json: Eliminate lexer state IN_WHITESPACE, pseudo-token JSON_SKIP 2018-09-24 18:08:07 +02:00
qom qom/object: Add a new function object_initialize_child() 2018-07-17 13:12:49 +01:00
replay trivial: Make bios files and source files non-executable 2018-09-25 17:26:18 +02:00
roms Update OpenBIOS images to a1280807 built from submodule. 2018-08-31 12:19:30 +01:00
scripts qapi: Add comments to aid debugging generated introspection 2018-08-28 18:21:38 +02:00
scsi qapi: Drop qapi_event_send_FOO()'s Error ** argument 2018-08-28 18:21:38 +02:00
slirp slirp: Correct size check in m_inc() 2018-08-07 14:13:22 +01:00
stubs qsp: track BQL callers explicitly 2018-08-23 18:46:25 +02:00
target target/arm: Start AArch32 CPUs with EL2 but not EL3 in Hyp mode 2018-09-25 15:13:24 +01:00
tcg tcg/i386: fix vector operations on 32-bit hosts 2018-09-26 09:02:51 -07:00
tests test-replication: Lock AioContext around blk_unref() 2018-10-01 19:13:55 +02:00
trace tracing: Use double-dash spelling for trace option 2018-07-19 13:09:04 +01:00
ui qapi: Drop qapi_event_send_FOO()'s Error ** argument 2018-08-28 18:21:38 +02:00
util Queued tcg patches 2018-09-28 18:56:09 +01:00
.dir-locals.el
.editorconfig add editorconfig 2017-07-20 09:56:56 +02:00
.exrc
.gdbinit .gdbinit: load QEMU sub-commands when gdb starts 2017-06-07 14:38:45 +01:00
.gitignore .gitignore: add .gcov files 2018-07-05 15:59:41 +01:00
.gitmodules vgabios: remove submodule and build rules. 2018-07-02 17:20:54 +02:00
.gitpublish Add a git-publish configuration file 2018-03-05 09:03:17 +00:00
.mailmap MAINTAINERS: Update target/mips maintainer's email addresses 2018-08-16 19:18:45 +02:00
.shippable.yml shippable: Remove Debian 8 libfdt kludge 2018-05-11 14:33:40 +02:00
.travis.yml travis: add gcovr summary for GCOV build 2018-07-05 15:59:41 +01:00
arch_init.c arch_init: sort architectures 2018-06-01 19:20:38 +03:00
balloon.c balloon: Allow multiple inhibit users 2018-08-17 09:27:15 -06:00
block.c block: Allow changing 'detect-zeroes' on reopen 2018-10-01 12:51:12 +02:00
blockdev-nbd.c qapi: new qmp command nbd-server-add-bitmap 2018-06-21 09:23:59 -05:00
blockdev.c commit: Add top-node/base-node options 2018-09-25 15:50:15 +02:00
blockjob.c block: Use a single global AioWait 2018-09-25 15:50:15 +02:00
bootdevice.c fw_cfg: ignore suffixes in the bootdevice list dependent on machine class 2018-08-16 22:27:43 -03:00
bt-host.c
bt-vhci.c
Changelog Use HTTPS for qemu.org and other domains 2017-11-21 13:34:13 +00:00
CODING_STYLE CODING_STYLE: Define our preferred form for multiline comments 2018-06-15 15:23:34 +01:00
configure ppc: Remove deprecated ppcemb target 2018-08-28 11:31:23 +10:00
COPYING
COPYING.LIB
cpus-common.c qom: convert the CPU list to RCU 2018-08-23 18:46:25 +02:00
cpus.c ppc patch queue 2018-09-07 2018-09-24 17:14:10 +01:00
device_tree.c device_tree: Add qemu_fdt_node_unit_path 2018-06-29 15:11:01 +01:00
device-hotplug.c block: Remove deprecated -drive option addr 2018-08-15 12:50:39 +02:00
disas.c RISC-V Disassembler 2018-03-07 08:30:28 +13:00
dma-helpers.c block: explicitly acquire aiocontext in bottom halves that need it 2017-02-21 11:39:39 +00:00
dump.c qapi: Drop qapi_event_send_FOO()'s Error ** argument 2018-08-28 18:21:38 +02:00
exec.c pc: fixes 2018-08-21 10:23:53 +01:00
gdbstub.c gdbstub: Prevent fd leakage 2018-06-01 15:14:31 +02:00
HACKING HACKING: document preference for g_new instead of g_malloc 2018-05-20 08:32:09 +03:00
hmp-commands-info.hx hmp-commands-info: add sync-profile 2018-08-23 18:46:25 +02:00
hmp-commands.hx hmp-commands: add sync-profile 2018-08-23 18:46:25 +02:00
hmp.c migration: show the statistics of compression 2018-09-26 12:27:27 +01:00
hmp.h hmp-commands: add sync-profile 2018-08-23 18:46:25 +02:00
ioport.c
iothread.c iothread: workaround glib bug which hangs qmp-test 2018-04-10 07:43:52 -05:00
job-qmp.c jobs: canonize Error object 2018-08-31 16:28:33 +02:00
job.c block: Use a single global AioWait 2018-09-25 15:50:15 +02:00
LICENSE
MAINTAINERS MAINTAINERS: Add NRF51 entry 2018-09-25 14:14:07 +01:00
Makefile Makefile: Add missing dependency for qemu-deprecated.texi 2018-09-25 17:26:17 +02:00
Makefile.objs hw/watchdog/cmsdk_apb_watchdog: Implement CMSDK APB watchdog module 2018-08-20 11:24:33 +01:00
Makefile.target dump: add Windows dump format to dump-guest-memory 2018-06-29 13:02:48 +02:00
memory_ldst.inc.c exec: Fix MAP_RAM for cached access 2018-06-28 19:05:30 +02:00
memory_mapping.c Replace all occurances of __FUNCTION__ with __func__ 2018-01-22 09:46:18 +01:00
memory.c pc: fixes 2018-08-21 10:23:53 +01:00
module-common.c
monitor.c monitor: print message when using 'help' with an unknown command 2018-09-25 14:48:44 +01:00
numa.c memory, exec: switch file ram allocation functions to 'flags' parameters 2018-08-10 13:29:39 +03:00
os-posix.c net: Remove the deprecated -tftp, -bootp, -redir and -smb options 2018-08-31 09:53:03 +02:00
os-win32.c qemu-options: Bail out on unsupported options instead of silently ignoring them 2018-05-09 00:13:39 +02:00
qdev-monitor.c qom: introduce object_class_get_list_sorted 2018-03-12 15:21:10 +01:00
qdict-test-data.txt
qemu-bridge-helper.c
qemu-deprecated.texi hw/core/machine: Officially deprecate the enforce-config-section parameter 2018-09-25 17:26:17 +02:00
qemu-doc.texi doc: switch to modern syntax for VNC TLS setup 2018-08-24 08:40:11 +02:00
qemu-ga.texi
qemu-img-cmds.hx qemu-img: Add -C option for convert with copy offloading 2018-07-30 15:35:37 +02:00
qemu-img.c qemu-img: fix regression copying secrets during convert 2018-08-15 12:50:39 +02:00
qemu-img.texi qemu-img: Add -C option for convert with copy offloading 2018-07-30 15:35:37 +02:00
qemu-io-cmds.c qemu-io: Fix writethrough check in reopen 2018-10-01 12:51:11 +02:00
qemu-io.c qemu-io: Exit with error when a command failed 2018-06-11 16:18:45 +02:00
qemu-keymap.c ui: use enum to string helpers 2018-08-24 08:40:10 +02:00
qemu-nbd.c block: Cancel job in bdrv_close_all() callers 2018-05-23 14:30:51 +02:00
qemu-nbd.texi
qemu-option-trace.texi qemu-option-trace: -trace enable= is a pattern, not a file 2018-05-20 08:29:01 +03:00
qemu-options-wrapper.h qemu-img: remove references to GEN_DOCS 2018-05-20 08:35:54 +03:00
qemu-options.h
qemu-options.hx qcow2: Fix cache-clean-interval documentation 2018-10-01 19:13:55 +02:00
qemu-seccomp.c seccomp: check TSYNC host capability 2018-09-26 15:07:35 +02:00
qemu-tech.texi cli qmp: Mark --preconfig, exit-preconfig experimental 2018-07-16 15:38:19 +02:00
qemu.nsi Use HTTPS for qemu.org and other domains 2017-11-21 13:34:13 +00:00
qemu.sasl Default to GSSAPI (Kerberos) instead of DIGEST-MD5 for SASL 2017-05-09 14:41:47 +01:00
qmp.c cli qmp: Mark --preconfig, exit-preconfig experimental 2018-07-16 15:38:19 +02:00
qtest.c qtest: Use cpu address space instead of system memory 2018-07-06 18:39:19 +02:00
README README: Fix typo 'git-publish' 2018-03-08 15:45:14 +00:00
replication.c
replication.h block/replication: Remove protocol_name field 2018-03-26 12:16:00 +02:00
rules.mak tests/docker/Makefile.include: handle empty TARGET_LIST 2018-06-04 14:39:18 +08:00
thunk.c thunk: assert nb_fields is valid 2017-07-31 13:06:39 +03:00
tpm.c qapi: Move qapi-schema.json to qapi/, rename generated files 2018-03-02 13:45:57 -06:00
trace-events jobs: remove ret argument to job_completed; privatize it 2018-08-31 16:28:33 +02:00
VERSION Open 3.1 development tree 2018-08-14 17:10:49 +01:00
version.rc Use HTTPS for qemu.org and other domains 2017-11-21 13:34:13 +00:00
vl.c Migration pull 2018-09-26 2018-09-28 17:07:23 +01:00
win_dump.c dump: add Windows live system dump 2018-06-29 13:02:50 +02:00
win_dump.h dump: add Windows live system dump 2018-06-29 13:02:50 +02:00

         QEMU README
         ===========

QEMU is a generic and open source machine & userspace emulator and
virtualizer.

QEMU is capable of emulating a complete machine in software without any
need for hardware virtualization support. By using dynamic translation,
it achieves very good performance. QEMU can also integrate with the Xen
and KVM hypervisors to provide emulated hardware while allowing the
hypervisor to manage the CPU. With hypervisor support, QEMU can achieve
near native performance for CPUs. When QEMU emulates CPUs directly it is
capable of running operating systems made for one machine (e.g. an ARMv7
board) on a different machine (e.g. an x86_64 PC board).

QEMU is also capable of providing userspace API virtualization for Linux
and BSD kernel interfaces. This allows binaries compiled against one
architecture ABI (e.g. the Linux PPC64 ABI) to be run on a host using a
different architecture ABI (e.g. the Linux x86_64 ABI). This does not
involve any hardware emulation, simply CPU and syscall emulation.

QEMU aims to fit into a variety of use cases. It can be invoked directly
by users wishing to have full control over its behaviour and settings.
It also aims to facilitate integration into higher level management
layers, by providing a stable command line interface and monitor API.
It is commonly invoked indirectly via the libvirt library when using
open source applications such as oVirt, OpenStack and virt-manager.

QEMU as a whole is released under the GNU General Public License,
version 2. For full licensing details, consult the LICENSE file.


Building
========

QEMU is multi-platform software intended to be buildable on all modern
Linux platforms, OS-X, Win32 (via the Mingw64 toolchain) and a variety
of other UNIX targets. The simple steps to build QEMU are:

  mkdir build
  cd build
  ../configure
  make

Additional information can also be found online via the QEMU website:

  https://qemu.org/Hosts/Linux
  https://qemu.org/Hosts/Mac
  https://qemu.org/Hosts/W32


Submitting patches
==================

The QEMU source code is maintained under the GIT version control system.

   git clone git://git.qemu.org/qemu.git

When submitting patches, one common approach is to use 'git
format-patch' and/or 'git send-email' to format & send the mail to the
qemu-devel@nongnu.org mailing list. All patches submitted must contain
a 'Signed-off-by' line from the author. Patches should follow the
guidelines set out in the HACKING and CODING_STYLE files.

Additional information on submitting patches can be found online via
the QEMU website

  https://qemu.org/Contribute/SubmitAPatch
  https://qemu.org/Contribute/TrivialPatches

The QEMU website is also maintained under source control.

  git clone git://git.qemu.org/qemu-web.git
  https://www.qemu.org/2017/02/04/the-new-qemu-website-is-up/

A 'git-publish' utility was created to make above process less
cumbersome, and is highly recommended for making regular contributions,
or even just for sending consecutive patch series revisions. It also
requires a working 'git send-email' setup, and by default doesn't
automate everything, so you may want to go through the above steps
manually for once.

For installation instructions, please go to

  https://github.com/stefanha/git-publish

The workflow with 'git-publish' is:

  $ git checkout master -b my-feature
  $ # work on new commits, add your 'Signed-off-by' lines to each
  $ git publish

Your patch series will be sent and tagged as my-feature-v1 if you need to refer
back to it in the future.

Sending v2:

  $ git checkout my-feature # same topic branch
  $ # making changes to the commits (using 'git rebase', for example)
  $ git publish

Your patch series will be sent with 'v2' tag in the subject and the git tip
will be tagged as my-feature-v2.

Bug reporting
=============

The QEMU project uses Launchpad as its primary upstream bug tracker. Bugs
found when running code built from QEMU git or upstream released sources
should be reported via:

  https://bugs.launchpad.net/qemu/

If using QEMU via an operating system vendor pre-built binary package, it
is preferable to report bugs to the vendor's own bug tracker first. If
the bug is also known to affect latest upstream code, it can also be
reported via launchpad.

For additional information on bug reporting consult:

  https://qemu.org/Contribute/ReportABug


Contact
=======

The QEMU community can be contacted in a number of ways, with the two
main methods being email and IRC

 - qemu-devel@nongnu.org
   https://lists.nongnu.org/mailman/listinfo/qemu-devel
 - #qemu on irc.oftc.net

Information on additional methods of contacting the community can be
found online via the QEMU website:

  https://qemu.org/Contribute/StartHere

-- End