qemu/crypto
Markus Armbruster d2623129a7 qom: Drop parameter @errp of object_property_add() & friends
The only way object_property_add() can fail is when a property with
the same name already exists.  Since our property names are all
hardcoded, failure is a programming error, and the appropriate way to
handle it is passing &error_abort.

Same for its variants, except for object_property_add_child(), which
additionally fails when the child already has a parent.  Parentage is
also under program control, so this is a programming error, too.

We have a bit over 500 callers.  Almost half of them pass
&error_abort, slightly fewer ignore errors, one test case handles
errors, and the remaining few callers pass them to their own callers.

The previous few commits demonstrated once again that ignoring
programming errors is a bad idea.

Of the few ones that pass on errors, several violate the Error API.
The Error ** argument must be NULL, &error_abort, &error_fatal, or a
pointer to a variable containing NULL.  Passing an argument of the
latter kind twice without clearing it in between is wrong: if the
first call sets an error, it no longer points to NULL for the second
call.  ich9_pm_add_properties(), sparc32_ledma_realize(),
sparc32_dma_realize(), xilinx_axidma_realize(), xilinx_enet_realize()
are wrong that way.

When the one appropriate choice of argument is &error_abort, letting
users pick the argument is a bad idea.

Drop parameter @errp and assert the preconditions instead.

There's one exception to "duplicate property name is a programming
error": the way object_property_add() implements the magic (and
undocumented) "automatic arrayification".  Don't drop @errp there.
Instead, rename object_property_add() to object_property_try_add(),
and add the obvious wrapper object_property_add().

Signed-off-by: Markus Armbruster <armbru@redhat.com>
Reviewed-by: Eric Blake <eblake@redhat.com>
Reviewed-by: Paolo Bonzini <pbonzini@redhat.com>
Message-Id: <20200505152926.18877-15-armbru@redhat.com>
[Two semantic rebase conflicts resolved]
2020-05-15 07:07:58 +02:00
..
Makefile.objs stubs: replace stubs with lnot if applicable 2019-12-17 19:32:48 +01:00
aes.c Include qemu-common.h exactly where needed 2019-06-12 13:20:20 +02:00
afalg.c crypto: introduce some common functions for af_alg backend 2017-07-19 10:11:05 +01:00
afalgpriv.h crypto: hash: add afalg-backend hash support 2017-07-19 10:11:05 +01:00
afsplit.c crypto: use auto cleanup for many stack variables 2019-08-22 10:56:57 +01:00
block-luks.c qcrypto-luks: more rigorous header checking 2019-09-26 16:34:02 +01:00
block-luks.h crypto: Fix LGPL information in the file headers 2019-07-19 14:21:25 +01:00
block-qcow.c crypto: Fix LGPL information in the file headers 2019-07-19 14:21:25 +01:00
block-qcow.h crypto: Fix LGPL information in the file headers 2019-07-19 14:21:25 +01:00
block.c luks: extract qcrypto_block_calculate_payload_offset() 2020-03-11 12:42:29 +01:00
blockpriv.h crypto: Fix LGPL information in the file headers 2019-07-19 14:21:25 +01:00
cipher-afalg.c qapi: Mechanically convert FOO_lookup[...] to FOO_str(...) 2017-09-04 13:09:13 +02:00
cipher-builtin.c crypto: Redundant type conversion for AES_KEY pointer 2020-05-07 12:48:41 +01:00
cipher-gcrypt.c crypto: add support for gcrypt's native XTS impl 2019-10-28 16:20:28 +01:00
cipher-nettle.c crypto: add support for nettle's native XTS impl 2019-10-28 16:45:07 +01:00
cipher.c crypto: Fix LGPL information in the file headers 2019-07-19 14:21:25 +01:00
cipherpriv.h Include less of the generated modular QAPI headers 2018-03-02 13:45:50 -06:00
desrfb.c crypto: finish removing TABs 2019-02-05 16:50:18 +01:00
hash-afalg.c crypto: hmac: add af_alg-backend hmac support 2017-07-19 10:11:05 +01:00
hash-gcrypt.c crypto: Fix LGPL information in the file headers 2019-07-19 14:21:25 +01:00
hash-glib.c crypto: Fix LGPL information in the file headers 2019-07-19 14:21:25 +01:00
hash-nettle.c crypto: Fix LGPL information in the file headers 2019-07-19 14:21:25 +01:00
hash.c crypto: Fix LGPL information in the file headers 2019-07-19 14:21:25 +01:00
hashpriv.h crypto: hash: add afalg-backend hash support 2017-07-19 10:11:05 +01:00
hmac-gcrypt.c qapi: Mechanically convert FOO_lookup[...] to FOO_str(...) 2017-09-04 13:09:13 +02:00
hmac-glib.c glib: bump min required glib library version to 2.48 2019-08-22 10:46:34 +01:00
hmac-nettle.c crypto: fix function signatures for nettle 2.7 vs 3 2019-07-19 12:48:22 +01:00
hmac.c Include qapi/error.h exactly where needed 2018-02-09 13:50:17 +01:00
hmacpriv.h crypto: hmac: add af_alg-backend hmac support 2017-07-19 10:11:05 +01:00
init.c crypto: Fix LGPL information in the file headers 2019-07-19 14:21:25 +01:00
ivgen-essiv.c crypto: Fix LGPL information in the file headers 2019-07-19 14:21:25 +01:00
ivgen-essiv.h crypto: Fix LGPL information in the file headers 2019-07-19 14:21:25 +01:00
ivgen-plain.c crypto: Fix LGPL information in the file headers 2019-07-19 14:21:25 +01:00
ivgen-plain.h crypto: Fix LGPL information in the file headers 2019-07-19 14:21:25 +01:00
ivgen-plain64.c crypto: Fix LGPL information in the file headers 2019-07-19 14:21:25 +01:00
ivgen-plain64.h crypto: Fix LGPL information in the file headers 2019-07-19 14:21:25 +01:00
ivgen.c crypto: Fix LGPL information in the file headers 2019-07-19 14:21:25 +01:00
ivgenpriv.h crypto: Fix LGPL information in the file headers 2019-07-19 14:21:25 +01:00
pbkdf-gcrypt.c crypto: Fix LGPL information in the file headers 2019-07-19 14:21:25 +01:00
pbkdf-nettle.c crypto: Fix LGPL information in the file headers 2019-07-19 14:21:25 +01:00
pbkdf-stub.c crypto: Fix LGPL information in the file headers 2019-07-19 14:21:25 +01:00
pbkdf.c crypto: use auto cleanup for many stack variables 2019-08-22 10:56:57 +01:00
random-gcrypt.c crypto: Fix LGPL information in the file headers 2019-07-19 14:21:25 +01:00
random-gnutls.c crypto: Fix LGPL information in the file headers 2019-07-19 14:21:25 +01:00
random-platform.c crypto: Fix LGPL information in the file headers 2019-07-19 14:21:25 +01:00
secret.c qom: Drop parameter @errp of object_property_add() & friends 2020-05-15 07:07:58 +02:00
tlscreds.c qom: Drop parameter @errp of object_property_add() & friends 2020-05-15 07:07:58 +02:00
tlscredsanon.c qom: Drop parameter @errp of object_property_add() & friends 2020-05-15 07:07:58 +02:00
tlscredspriv.h crypto: Fix LGPL information in the file headers 2019-07-19 14:21:25 +01:00
tlscredspsk.c qom: Drop parameter @errp of object_property_add() & friends 2020-05-15 07:07:58 +02:00
tlscredsx509.c qom: Drop parameter @errp of object_property_add() & friends 2020-05-15 07:07:58 +02:00
tlssession.c crypto: Fix LGPL information in the file headers 2019-07-19 14:21:25 +01:00
trace-events trace-events: Shorten file names in comments 2019-03-22 16:18:07 +00:00
xts.c crypto: Fix LGPL information in the file headers 2019-07-19 14:21:25 +01:00