Fabiano Rosas 61dec06082 migration/multifd: Don't fsync when closing QIOChannelFile ... Commit bc38feddeb ("io: fsync before closing a file channel") added a fsync/fdatasync at the closing point of the QIOChannelFile to ensure integrity of the migration stream in case of QEMU crash. The decision to do the sync at qio_channel_close() was not the best since that function runs in the main thread and the fsync can cause QEMU to hang for several minutes, depending on the migration size and disk speed. To fix the hang, remove the fsync from qio_channel_file_close(). At this moment, the migration code is the only user of the fsync and we're taking the tradeoff of not having a sync at all, leaving the responsibility to the upper layers. Fixes: bc38feddeb ("io: fsync before closing a file channel") Reviewed-by: "Daniel P. Berrangé" <berrange@redhat.com> Signed-off-by: Fabiano Rosas <farosas@suse.de> Link: https://lore.kernel.org/r/20240305195629.9922-1-farosas@suse.de Link: https://lore.kernel.org/r/20240305174332.2553-1-farosas@suse.de [peterx: add more comment to the qio_channel_close()] Signed-off-by: Peter Xu <peterx@redhat.com>		2024-03-11 14:41:40 -04:00
..
migration	migration/multifd: Don't fsync when closing QIOChannelFile	2024-03-11 14:41:40 -04:00
acpi-bits.rst	docs/acpi/bits: add some clarity and details while also improving formating	2024-03-09 18:56:37 +03:00
atomics.rst	atomics: eliminate mb_read/mb_set	2023-06-06 09:42:14 +02:00
bitops.rst	docs: Create bitops.rst as example of kernel-docs	2019-12-17 19:36:57 +01:00
blkdebug.txt	docs/: fix some comment spelling errors	2020-09-17 20:37:13 +02:00
blkverify.txt	meson: link emulators without Makefile.target	2020-08-21 06:30:40 -04:00
block-coroutine-wrapper.rst	block-coroutine-wrapper.py: introduce co_wrapper	2022-12-15 16:07:43 +01:00
build-system.rst	meson: remove CONFIG_ALL	2023-12-31 09:11:28 +01:00
ci-definitions.rst.inc	tests/acceptance: rename tests acceptance to tests avocado	2021-11-08 17:00:22 +01:00
ci-jobs.rst.inc	docs: correct typos	2024-02-20 22:20:48 +03:00
ci-runners.rst.inc	docs: name included files ".rst.inc"	2021-10-01 19:04:45 +02:00
ci.rst	docs/devel: clean-up the CI links in the docs	2022-06-01 18:55:04 +01:00
clocks.rst	docs: Constify VMstate in examples	2023-12-30 07:38:06 +11:00
code-of-conduct.rst	docs/devel: add a maintainers section to development process	2022-11-22 09:49:07 +00:00
conflict-resolution.rst	docs: Add a QEMU Code of Conduct and Conflict Resolution Policy document	2021-04-01 13:21:02 +02:00
control-flow-integrity.rst	Fix typo in CFI build documentation	2021-05-02 17:24:50 +02:00
decodetree.rst	docs: Document decodetree named field syntax	2023-05-30 10:55:39 -07:00
docs.rst	docs: correct typos	2024-02-20 22:20:48 +03:00
ebpf_rss.rst	docs/devel/ebpf_rss.rst: Format literals correctly	2021-08-02 11:42:38 +01:00
fuzzing.rst	docs/fuzz: remove mentions of fork-based fuzzing	2023-02-16 23:02:46 -05:00
index-api.rst	hw/pci: modify pci_setup_iommu() to set PCIIOMMUOps	2023-11-03 09:20:31 +01:00
index-build.rst	docs/devel/docs: Document .hx file syntax	2024-01-15 17:12:22 +00:00
index-internals.rst	docs/migration: Create index page	2024-01-16 11:16:10 +08:00
index-process.rst	docs/devel: add some front matter to the devel index	2023-07-03 12:52:08 +01:00
index-tcg.rst	docs/devel: add some front matter to the devel index	2023-07-03 12:52:08 +01:00
index.rst	docs/devel: add some front matter to the devel index	2023-07-03 12:52:08 +01:00
kconfig.rst	configure, meson: rename targetos to host_os	2023-12-31 09:11:29 +01:00
loads-stores.rst	docs/devel/loads-stores: Fix git grep regexes	2023-09-21 14:45:57 +01:00
lockcnt.txt	docs: fix references to docs/devel/atomics.rst	2021-06-02 06:51:09 +02:00
maintainers.rst	docs/devel: add a maintainers section to development process	2022-11-22 09:49:07 +00:00
memory.rst	docs/devel: add some clarifying text for aliases	2022-01-18 12:56:29 +01:00
modules.rst	docs: Spell QEMU all caps	2021-11-19 10:16:58 +01:00
multi-process.rst	docs: Don't mention "-mem-path" in multi-process.rst	2023-09-19 10:23:21 +02:00
multi-thread-tcg.rst	docs/devel: plugins can trigger a tb flush	2024-02-28 09:11:42 +00:00
multiple-iothreads.txt	Rename "QEMU global mutex" to "BQL" in comments and docs	2024-01-08 10:45:43 -05:00
pci.rst	hw/pci: modify pci_setup_iommu() to set PCIIOMMUOps	2023-11-03 09:20:31 +01:00
qapi-code-gen.rst	qapi: New documentation section tag "Errors"	2024-03-04 07:12:40 +01:00
qdev-api.rst	docs/devel: split qom-api reference into new file	2023-07-03 12:52:22 +01:00
qgraph.rst	Fix some typos in documentation (found by codespell)	2021-11-22 15:02:38 +01:00
qom-api.rst	docs/devel: split qom-api reference into new file	2023-07-03 12:52:22 +01:00
qom.rst	include/qom/object.h: New OBJECT_DEFINE_SIMPLE_TYPE{, _WITH_INTERFACES} macros	2024-02-27 13:01:42 +00:00
qtest.rst	system: Rename softmmu/ directory as system/	2023-10-08 21:08:08 +02:00
rcu.txt	Docs/RCU: Correct sample code of qatomic_rcu_set	2021-01-12 12:38:03 +01:00
replay.rst	Rename "QEMU global mutex" to "BQL" in comments and docs	2024-01-08 10:45:43 -05:00
reset.rst	docs/devel/reset: Update to discuss system reset	2024-02-27 13:01:42 +00:00
s390-cpu-topology.rst	docs/s390: Fix wrong command example in s390-cpu-topology.rst	2023-11-28 14:27:18 +01:00
s390-dasd-ipl.rst	docs: rstfy s390 dasd ipl documentation	2020-02-26 18:57:07 +01:00
secure-coding-practices.rst	docs/secure-coding-practices: Describe how to use 'null-co' block driver	2021-06-02 14:29:14 +02:00
stable-process.rst	docs: Fix botched rST conversion of 'submitting-a-patch.rst'	2021-11-22 15:02:38 +01:00
style.rst	docs/style: permit inline loop variables	2023-08-30 14:57:44 +01:00
submitting-a-patch.rst	docs/devel: try and improve the language around patch review	2022-11-22 09:52:23 +00:00
submitting-a-pull-request.rst	docs/devel: add a maintainers section to development process	2022-11-22 09:49:07 +00:00
tcg-icount.rst	accel/tcg: Remove CF_LAST_IO	2023-11-14 10:40:54 -08:00
tcg-ops.rst	tcg: Introduce TCG_COND_TST{EQ,NE}	2024-02-03 23:43:47 +00:00
tcg-plugins.rst	docs/devel: document some plugin assumptions	2024-02-28 09:11:42 +00:00
tcg.rst	docs/devel: add some front matter to the devel index	2023-07-03 12:52:08 +01:00
testing.rst	tests/avocado: mark boot_linux.py long runtime instead of flaky	2024-02-23 23:16:34 +10:00
tracing.rst	docs: trace-events-all is installed without renaming	2022-04-21 17:03:51 +04:00
trivial-patches.rst	docs: Fix botched rST conversion of 'submitting-a-patch.rst'	2021-11-22 15:02:38 +01:00
ui.rst	docs: Spell QEMU all caps	2021-11-19 10:16:58 +01:00
vfio-iommufd.rst	docs/devel: Add VFIO iommufd backend documentation	2023-12-19 19:03:38 +01:00
virtio-backends.rst	docs/devel: start documenting writing VirtIO devices	2022-05-16 04:38:40 -04:00
writing-monitor-commands.rst	docs/devel/writing-monitor-commands: Minor improvements	2024-03-04 07:12:40 +01:00
zoned-storage.rst	docs/zoned-storage:add zoned emulation use case	2023-05-15 08:19:04 -04:00