5bfce0b74f
The alternate signal stack set up by the sigaltstack syscall is supposed to be per-thread. We were incorrectly implementing it as process-wide. This causes problems for guest binaries that rely on this. Notably the Go runtime does, and so we were seeing crashes caused by races where two guest threads might incorrectly both execute on the same stack simultaneously. Replace the global target_sigaltstack_used with a field sigaltstack_used in the TaskState, and make all the references to the old global instead get a pointer to the TaskState and use the field. Fixes: https://bugs.launchpad.net/qemu/+bug/1696773 Signed-off-by: Peter Maydell <peter.maydell@linaro.org> Reviewed-by: Richard Henderson <richard.henderson@linaro.org> Tested-by: Laurent Vivier <laurent@vivier.eu> Reviewed-by: Laurent Vivier <laurent@vivier.eu> Message-Id: <20190725131645.19501-1-peter.maydell@linaro.org> Signed-off-by: Laurent Vivier <laurent@vivier.eu>
50 lines
1.8 KiB
C
50 lines
1.8 KiB
C
/*
|
|
* Emulation of Linux signals
|
|
*
|
|
* Copyright (c) 2003 Fabrice Bellard
|
|
*
|
|
* This program is free software; you can redistribute it and/or modify
|
|
* it under the terms of the GNU General Public License as published by
|
|
* the Free Software Foundation; either version 2 of the License, or
|
|
* (at your option) any later version.
|
|
*
|
|
* This program is distributed in the hope that it will be useful,
|
|
* but WITHOUT ANY WARRANTY; without even the implied warranty of
|
|
* MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
|
|
* GNU General Public License for more details.
|
|
*
|
|
* You should have received a copy of the GNU General Public License
|
|
* along with this program; if not, see <http://www.gnu.org/licenses/>.
|
|
*/
|
|
|
|
#ifndef SIGNAL_COMMON_H
|
|
#define SIGNAL_COMMON_H
|
|
|
|
int on_sig_stack(unsigned long sp);
|
|
int sas_ss_flags(unsigned long sp);
|
|
abi_ulong target_sigsp(abi_ulong sp, struct target_sigaction *ka);
|
|
void target_save_altstack(target_stack_t *uss, CPUArchState *env);
|
|
|
|
static inline void target_sigemptyset(target_sigset_t *set)
|
|
{
|
|
memset(set, 0, sizeof(*set));
|
|
}
|
|
|
|
void host_to_target_sigset_internal(target_sigset_t *d,
|
|
const sigset_t *s);
|
|
void target_to_host_sigset_internal(sigset_t *d,
|
|
const target_sigset_t *s);
|
|
void tswap_siginfo(target_siginfo_t *tinfo,
|
|
const target_siginfo_t *info);
|
|
void set_sigmask(const sigset_t *set);
|
|
void force_sig(int sig);
|
|
void force_sigsegv(int oldsig);
|
|
#if defined(TARGET_ARCH_HAS_SETUP_FRAME)
|
|
void setup_frame(int sig, struct target_sigaction *ka,
|
|
target_sigset_t *set, CPUArchState *env);
|
|
#endif
|
|
void setup_rt_frame(int sig, struct target_sigaction *ka,
|
|
target_siginfo_t *info,
|
|
target_sigset_t *set, CPUArchState *env);
|
|
#endif
|