![Marc-André Lureau](/assets/img/avatar_default.png)
Since commit d52c454aadcdae74506f315ebf8b58bb79a05573 ("contrib: add vhost-user-gpu"), qemu-ga is linking with pixman. This is because the Make-based build-system use a global namespace for variables, and we rely on "main.o-libs" for different linking targets. Note: this kind of variable clashing is hard to fix or prevent currently. meson should help, as declarations have a linear dependency and doesn't rely so much on variables and clever tricks. Note2: we have a lot of main.c (or other duplicated names!) in tree. Imho, it would be annoying and a bad workaroud to rename all those to avoid conflicts like I did here. Fixes: https://bugzilla.redhat.com/show_bug.cgi?id=1811670 Signed-off-by: Marc-André Lureau <marcandre.lureau@redhat.com> Message-Id: <20200311160923.882474-1-marcandre.lureau@redhat.com> Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
11 lines
295 B
Makefile
11 lines
295 B
Makefile
vhost-user-gpu-obj-y = vhost-user-gpu.o virgl.o vugbm.o
|
|
|
|
vhost-user-gpu.o-cflags := $(PIXMAN_CFLAGS) $(GBM_CFLAGS)
|
|
vhost-user-gpu.o-libs := $(PIXMAN_LIBS)
|
|
|
|
virgl.o-cflags := $(VIRGL_CFLAGS) $(GBM_CFLAGS)
|
|
virgl.o-libs := $(VIRGL_LIBS)
|
|
|
|
vugbm.o-cflags := $(GBM_CFLAGS)
|
|
vugbm.o-libs := $(GBM_LIBS)
|