ec150c7e09
Back in 2016, we discussed[1] rules for headers, and these were
generally liked:
1. Have a carefully curated header that's included everywhere first. We
got that already thanks to Peter: osdep.h.
2. Headers should normally include everything they need beyond osdep.h.
If exceptions are needed for some reason, they must be documented in
the header. If all that's needed from a header is typedefs, put
those into qemu/typedefs.h instead of including the header.
3. Cyclic inclusion is forbidden.
This patch gets include/ closer to obeying 2.
It's actually extracted from my "[RFC] Baby steps towards saner
headers" series[2], which demonstrates a possible path towards
checking 2 automatically. It passes the RFC test there.
[1] Message-ID: <87h9g8j57d.fsf@blackfin.pond.sub.org>
https://lists.nongnu.org/archive/html/qemu-devel/2016-03/msg03345.html
[2] Message-Id: <20190711122827.18970-1-armbru@redhat.com>
https://lists.nongnu.org/archive/html/qemu-devel/2019-07/msg02715.html
Signed-off-by: Markus Armbruster <armbru@redhat.com>
Reviewed-by: Alistair Francis <alistair.francis@wdc.com>
Message-Id: <20190812052359.30071-2-armbru@redhat.com>
Tested-by: Philippe Mathieu-Daudé <philmd@redhat.com>
102 lines
2.8 KiB
C
102 lines
2.8 KiB
C
/*
|
|
* Helper routines to provide target memory access for semihosting
|
|
* syscalls in system emulation mode.
|
|
*
|
|
* Copyright (c) 2007 CodeSourcery.
|
|
*
|
|
* This code is licensed under the GPL
|
|
*/
|
|
|
|
#ifndef SOFTMMU_SEMI_H
|
|
#define SOFTMMU_SEMI_H
|
|
|
|
#include "cpu.h"
|
|
|
|
static inline uint64_t softmmu_tget64(CPUArchState *env, target_ulong addr)
|
|
{
|
|
uint64_t val;
|
|
|
|
cpu_memory_rw_debug(env_cpu(env), addr, (uint8_t *)&val, 8, 0);
|
|
return tswap64(val);
|
|
}
|
|
|
|
static inline uint32_t softmmu_tget32(CPUArchState *env, target_ulong addr)
|
|
{
|
|
uint32_t val;
|
|
|
|
cpu_memory_rw_debug(env_cpu(env), addr, (uint8_t *)&val, 4, 0);
|
|
return tswap32(val);
|
|
}
|
|
|
|
static inline uint32_t softmmu_tget8(CPUArchState *env, target_ulong addr)
|
|
{
|
|
uint8_t val;
|
|
|
|
cpu_memory_rw_debug(env_cpu(env), addr, &val, 1, 0);
|
|
return val;
|
|
}
|
|
|
|
#define get_user_u64(arg, p) ({ arg = softmmu_tget64(env, p); 0; })
|
|
#define get_user_u32(arg, p) ({ arg = softmmu_tget32(env, p) ; 0; })
|
|
#define get_user_u8(arg, p) ({ arg = softmmu_tget8(env, p) ; 0; })
|
|
#define get_user_ual(arg, p) get_user_u32(arg, p)
|
|
|
|
static inline void softmmu_tput64(CPUArchState *env,
|
|
target_ulong addr, uint64_t val)
|
|
{
|
|
val = tswap64(val);
|
|
cpu_memory_rw_debug(env_cpu(env), addr, (uint8_t *)&val, 8, 1);
|
|
}
|
|
|
|
static inline void softmmu_tput32(CPUArchState *env,
|
|
target_ulong addr, uint32_t val)
|
|
{
|
|
val = tswap32(val);
|
|
cpu_memory_rw_debug(env_cpu(env), addr, (uint8_t *)&val, 4, 1);
|
|
}
|
|
#define put_user_u64(arg, p) ({ softmmu_tput64(env, p, arg) ; 0; })
|
|
#define put_user_u32(arg, p) ({ softmmu_tput32(env, p, arg) ; 0; })
|
|
#define put_user_ual(arg, p) put_user_u32(arg, p)
|
|
|
|
static void *softmmu_lock_user(CPUArchState *env,
|
|
target_ulong addr, target_ulong len, int copy)
|
|
{
|
|
uint8_t *p;
|
|
/* TODO: Make this something that isn't fixed size. */
|
|
p = malloc(len);
|
|
if (p && copy) {
|
|
cpu_memory_rw_debug(env_cpu(env), addr, p, len, 0);
|
|
}
|
|
return p;
|
|
}
|
|
#define lock_user(type, p, len, copy) softmmu_lock_user(env, p, len, copy)
|
|
static char *softmmu_lock_user_string(CPUArchState *env, target_ulong addr)
|
|
{
|
|
char *p;
|
|
char *s;
|
|
uint8_t c;
|
|
/* TODO: Make this something that isn't fixed size. */
|
|
s = p = malloc(1024);
|
|
if (!s) {
|
|
return NULL;
|
|
}
|
|
do {
|
|
cpu_memory_rw_debug(env_cpu(env), addr, &c, 1, 0);
|
|
addr++;
|
|
*(p++) = c;
|
|
} while (c);
|
|
return s;
|
|
}
|
|
#define lock_user_string(p) softmmu_lock_user_string(env, p)
|
|
static void softmmu_unlock_user(CPUArchState *env, void *p, target_ulong addr,
|
|
target_ulong len)
|
|
{
|
|
if (len) {
|
|
cpu_memory_rw_debug(env_cpu(env), addr, p, len, 1);
|
|
}
|
|
free(p);
|
|
}
|
|
#define unlock_user(s, args, len) softmmu_unlock_user(env, s, args, len)
|
|
|
|
#endif
|