efaa7c4eeb
Before this patch, blk_new() automatically assigned a name to the new BlockBackend and considered it referenced by the monitor. This patch removes the implicit monitor_add_blk() call from blk_new() (and consequently the monitor_remove_blk() call from blk_delete(), too) and thus blk_new() (and related functions) no longer take a BB name argument. In fact, there is only a single point where blk_new()/blk_new_open() is called and the new BB is monitor-owned, and that is in blockdev_init(). Besides thus relieving us from having to invent names for all of the BBs we use in qemu-img, this fixes a bug where qemu cannot create a new image if there already is a monitor-owned BB named "image". If a BB and its BDS tree are created in a single operation, as of this patch the BDS tree will be created before the BB is given a name (whereas it was the other way around before). This results in minor change to the output of iotest 087, whose reference output is amended accordingly. Signed-off-by: Max Reitz <mreitz@redhat.com> Signed-off-by: Kevin Wolf <kwolf@redhat.com>
86 lines
3.1 KiB
Plaintext
86 lines
3.1 KiB
Plaintext
QA output created by 087
|
|
Formatting 'TEST_DIR/t.IMGFMT', fmt=IMGFMT size=134217728
|
|
|
|
=== Missing ID and node-name ===
|
|
|
|
Testing:
|
|
QMP_VERSION
|
|
{"return": {}}
|
|
{"error": {"class": "GenericError", "desc": "'id' and/or 'node-name' need to be specified for the root node"}}
|
|
{"return": {}}
|
|
{"timestamp": {"seconds": TIMESTAMP, "microseconds": TIMESTAMP}, "event": "SHUTDOWN"}
|
|
|
|
|
|
=== Duplicate ID ===
|
|
|
|
Testing:
|
|
QMP_VERSION
|
|
{"return": {}}
|
|
{"return": {}}
|
|
{"error": {"class": "GenericError", "desc": "Device with id 'disk' already exists"}}
|
|
{"error": {"class": "GenericError", "desc": "Device name 'test-node' conflicts with an existing node name"}}
|
|
{"error": {"class": "GenericError", "desc": "node-name=disk is conflicting with a device id"}}
|
|
{"error": {"class": "GenericError", "desc": "Duplicate node name"}}
|
|
{"error": {"class": "GenericError", "desc": "Device name 'disk3' conflicts with an existing node name"}}
|
|
{"return": {}}
|
|
{"timestamp": {"seconds": TIMESTAMP, "microseconds": TIMESTAMP}, "event": "SHUTDOWN"}
|
|
|
|
|
|
=== aio=native without O_DIRECT ===
|
|
|
|
Testing:
|
|
QMP_VERSION
|
|
{"return": {}}
|
|
{"error": {"class": "GenericError", "desc": "aio=native requires cache.direct=true"}}
|
|
{"return": {}}
|
|
{"timestamp": {"seconds": TIMESTAMP, "microseconds": TIMESTAMP}, "event": "SHUTDOWN"}
|
|
|
|
|
|
=== Encrypted image ===
|
|
|
|
qemu-img: Encrypted images are deprecated
|
|
Support for them will be removed in a future release.
|
|
You can use 'qemu-img convert' to convert your image to an unencrypted one.
|
|
qemu-img: Encrypted images are deprecated
|
|
Support for them will be removed in a future release.
|
|
You can use 'qemu-img convert' to convert your image to an unencrypted one.
|
|
Formatting 'TEST_DIR/t.IMGFMT', fmt=IMGFMT size=134217728 encryption=on
|
|
Testing: -S
|
|
QMP_VERSION
|
|
{"return": {}}
|
|
Encrypted images are deprecated
|
|
Support for them will be removed in a future release.
|
|
You can use 'qemu-img convert' to convert your image to an unencrypted one.
|
|
{"error": {"class": "GenericError", "desc": "blockdev-add doesn't support encrypted devices"}}
|
|
{"return": {}}
|
|
{"timestamp": {"seconds": TIMESTAMP, "microseconds": TIMESTAMP}, "event": "SHUTDOWN"}
|
|
|
|
Testing:
|
|
QMP_VERSION
|
|
{"return": {}}
|
|
Encrypted images are deprecated
|
|
Support for them will be removed in a future release.
|
|
You can use 'qemu-img convert' to convert your image to an unencrypted one.
|
|
{"error": {"class": "GenericError", "desc": "Guest must be stopped for opening of encrypted image"}}
|
|
{"return": {}}
|
|
{"timestamp": {"seconds": TIMESTAMP, "microseconds": TIMESTAMP}, "event": "SHUTDOWN"}
|
|
|
|
|
|
=== Missing driver ===
|
|
|
|
qemu-img: Encrypted images are deprecated
|
|
Support for them will be removed in a future release.
|
|
You can use 'qemu-img convert' to convert your image to an unencrypted one.
|
|
qemu-img: Encrypted images are deprecated
|
|
Support for them will be removed in a future release.
|
|
You can use 'qemu-img convert' to convert your image to an unencrypted one.
|
|
Formatting 'TEST_DIR/t.IMGFMT', fmt=IMGFMT size=134217728 encryption=on
|
|
Testing: -S
|
|
QMP_VERSION
|
|
{"return": {}}
|
|
{"error": {"class": "GenericError", "desc": "Invalid parameter type for 'driver', expected: string"}}
|
|
{"return": {}}
|
|
{"timestamp": {"seconds": TIMESTAMP, "microseconds": TIMESTAMP}, "event": "SHUTDOWN"}
|
|
|
|
*** done
|