b8d1fc55b5
There's one commit, tagged v7.2.2, without Signed-off-by line. Due to this, check-dco test always fail on 7.2. Since this is a stable branch with almost all commits coming from master already with S-o-b (except of the version bumps and very rare stable-specific commits), and v7.2.2 is already cast in stone, let's base the check on stable-7.2 branch (with its last version) instead of master branch. This way, staging-7.2 will be checked against stable-7.2, but stable-7.2 itself will not be checked anymore, - so we can catch errors during stable preparations. Note: this is a change specific to stable-7.2 branch/series, it is not supposed to be in master. Signed-off-by: Michael Tokarev <mjt@tls.msk.ru> Reviewed-by: Thomas Huth <thuth@redhat.com>
95 lines
2.5 KiB
Python
Executable File
95 lines
2.5 KiB
Python
Executable File
#!/usr/bin/env python3
|
|
#
|
|
# check-dco.py: validate all commits are signed off
|
|
#
|
|
# Copyright (C) 2020 Red Hat, Inc.
|
|
#
|
|
# SPDX-License-Identifier: GPL-2.0-or-later
|
|
|
|
import os
|
|
import os.path
|
|
import sys
|
|
import subprocess
|
|
|
|
namespace = "qemu-project"
|
|
if len(sys.argv) >= 2:
|
|
namespace = sys.argv[1]
|
|
|
|
cwd = os.getcwd()
|
|
reponame = os.path.basename(cwd)
|
|
repourl = "https://gitlab.com/%s/%s.git" % (namespace, reponame)
|
|
|
|
subprocess.check_call(["git", "remote", "add", "check-dco", repourl])
|
|
subprocess.check_call(["git", "fetch", "check-dco", "stable-7.2"],
|
|
stdout=subprocess.DEVNULL,
|
|
stderr=subprocess.DEVNULL)
|
|
|
|
ancestor = subprocess.check_output(["git", "merge-base",
|
|
"check-dco/stable-7.2", "HEAD"],
|
|
universal_newlines=True)
|
|
|
|
ancestor = ancestor.strip()
|
|
|
|
subprocess.check_call(["git", "remote", "rm", "check-dco"])
|
|
|
|
errors = False
|
|
|
|
print("\nChecking for 'Signed-off-by: NAME <EMAIL>' " +
|
|
"on all commits since %s...\n" % ancestor)
|
|
|
|
log = subprocess.check_output(["git", "log", "--format=%H %s",
|
|
ancestor + "..."],
|
|
universal_newlines=True)
|
|
|
|
if log == "":
|
|
commits = []
|
|
else:
|
|
commits = [[c[0:40], c[41:]] for c in log.strip().split("\n")]
|
|
|
|
for sha, subject in commits:
|
|
|
|
msg = subprocess.check_output(["git", "show", "-s", sha],
|
|
universal_newlines=True)
|
|
lines = msg.strip().split("\n")
|
|
|
|
print("🔍 %s %s" % (sha, subject))
|
|
sob = False
|
|
for line in lines:
|
|
if "Signed-off-by:" in line:
|
|
sob = True
|
|
if "localhost" in line:
|
|
print(" ❌ FAIL: bad email in %s" % line)
|
|
errors = True
|
|
|
|
if not sob:
|
|
print(" ❌ FAIL missing Signed-off-by tag")
|
|
errors = True
|
|
|
|
if errors:
|
|
print("""
|
|
|
|
❌ ERROR: One or more commits are missing a valid Signed-off-By tag.
|
|
|
|
|
|
This project requires all contributors to assert that their contributions
|
|
are provided in compliance with the terms of the Developer's Certificate
|
|
of Origin 1.1 (DCO):
|
|
|
|
https://developercertificate.org/
|
|
|
|
To indicate acceptance of the DCO every commit must have a tag
|
|
|
|
Signed-off-by: REAL NAME <EMAIL>
|
|
|
|
This can be achieved by passing the "-s" flag to the "git commit" command.
|
|
|
|
To bulk update all commits on current branch "git rebase" can be used:
|
|
|
|
git rebase -i stable-7.2 -x 'git commit --amend --no-edit -s'
|
|
|
|
""")
|
|
|
|
sys.exit(1)
|
|
|
|
sys.exit(0)
|