![Avihai Horon](/assets/img/avatar_default.png)
Currently, VFIO bytes_transferred is not reset properly: 1. bytes_transferred is not reset after a VM snapshot (so a migration following a snapshot will report incorrect value). 2. bytes_transferred is a single counter for all VFIO devices, however upon migration failure it is reset multiple times, by each VFIO device. Fix it by introducing a new function vfio_reset_bytes_transferred() and calling it during migration and snapshot start. Remove existing bytes_transferred reset in VFIO migration state notifier, which is not needed anymore. Fixes: 3710586caa5d ("qapi: Add VFIO devices migration stats in Migration stats") Signed-off-by: Avihai Horon <avihaih@nvidia.com> Reviewed-by: Cédric Le Goater <clg@redhat.com> Reviewed-by: Alex Williamson <alex.williamson@redhat.com> Signed-off-by: Cédric Le Goater <clg@redhat.com>
39 lines
775 B
C
39 lines
775 B
C
/*
|
|
* QEMU live migration - functions that need to be compiled target-specific
|
|
*
|
|
* This work is licensed under the terms of the GNU GPL, version 2
|
|
* or (at your option) any later version.
|
|
*/
|
|
|
|
#include "qemu/osdep.h"
|
|
#include "qapi/qapi-types-migration.h"
|
|
#include "migration.h"
|
|
#include CONFIG_DEVICES
|
|
|
|
#ifdef CONFIG_VFIO
|
|
#include "hw/vfio/vfio-common.h"
|
|
#endif
|
|
|
|
#ifdef CONFIG_VFIO
|
|
void populate_vfio_info(MigrationInfo *info)
|
|
{
|
|
if (vfio_mig_active()) {
|
|
info->vfio = g_malloc0(sizeof(*info->vfio));
|
|
info->vfio->transferred = vfio_mig_bytes_transferred();
|
|
}
|
|
}
|
|
|
|
void reset_vfio_bytes_transferred(void)
|
|
{
|
|
vfio_reset_bytes_transferred();
|
|
}
|
|
#else
|
|
void populate_vfio_info(MigrationInfo *info)
|
|
{
|
|
}
|
|
|
|
void reset_vfio_bytes_transferred(void)
|
|
{
|
|
}
|
|
#endif
|