mirrors/qemu
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity
65b70fc7de
qemu/crypto
History
Longpeng f1710638ed crypto: afalg: fix a NULL pointer dereference 
Test-crypto-hash calls qcrypto_hash_bytesv/digest/base64 with
errp=NULL, this will cause a NULL pointer dereference if afalg_driver
doesn't support requested algos:

    ret = qcrypto_hash_afalg_driver.hash_bytesv(alg, iov, niov,
                                                result, resultlen,
                                                errp);
    if (ret == 0) {
        return ret;
    }

    error_free(*errp);  // <--- here

Because the error message is thrown away immediately, we should
just pass NULL to hash_bytesv(). There is also the same problem in
afalg-backend cipher & hmac, let's fix them together.

Reviewed-by: Eric Blake <eblake@redhat.com>
Reported-by: Paolo Bonzini <pbonzini@redhat.com>
Signed-off-by: Longpeng <longpeng2@huawei.com>
Signed-off-by: Daniel P. Berrange <berrange@redhat.com>
2017-11-08 11:05:09 +00:00
..
aes.c
afalg.c crypto: introduce some common functions for af_alg backend 2017-07-19 10:11:05 +01:00
afalgpriv.h crypto: hash: add afalg-backend hash support 2017-07-19 10:11:05 +01:00
afsplit.c qemu-common: stop including qemu/bswap.h from qemu-common.h 2016-05-19 16:42:28 +02:00
block-luks.c block: convert qcrypto_block_encrypt|decrypt to take bytes offset 2017-10-06 16:30:47 +02:00
block-luks.h Clean up ill-advised or unusual header guards 2016-07-12 16:20:46 +02:00
block-qcow.c block: convert qcrypto_block_encrypt|decrypt to take bytes offset 2017-10-06 16:30:47 +02:00
block-qcow.h Clean up ill-advised or unusual header guards 2016-07-12 16:20:46 +02:00
block.c block: convert qcrypto_block_encrypt|decrypt to take bytes offset 2017-10-06 16:30:47 +02:00
blockpriv.h block: convert qcrypto_block_encrypt|decrypt to take bytes offset 2017-10-06 16:30:47 +02:00
cipher-afalg.c qapi: Mechanically convert FOO_lookup[...] to FOO_str(...) 2017-09-04 13:09:13 +02:00
cipher-builtin.c qapi: Mechanically convert FOO_lookup[...] to FOO_str(...) 2017-09-04 13:09:13 +02:00
cipher-gcrypt.c qapi: Mechanically convert FOO_lookup[...] to FOO_str(...) 2017-09-04 13:09:13 +02:00
cipher-nettle.c qapi: Mechanically convert FOO_lookup[...] to FOO_str(...) 2017-09-04 13:09:13 +02:00
cipher.c crypto: afalg: fix a NULL pointer dereference 2017-11-08 11:05:09 +00:00
cipherpriv.h crypto: cipher: add afalg-backend cipher support 2017-07-19 10:11:05 +01:00
desrfb.c
hash-afalg.c crypto: hmac: add af_alg-backend hmac support 2017-07-19 10:11:05 +01:00
hash-gcrypt.c crypto: hash: add hash driver framework 2017-07-19 10:11:04 +01:00
hash-glib.c crypto: hash: add hash driver framework 2017-07-19 10:11:04 +01:00
hash-nettle.c crypto: hash: add hash driver framework 2017-07-19 10:11:04 +01:00
hash.c crypto: afalg: fix a NULL pointer dereference 2017-11-08 11:05:09 +00:00
hashpriv.h crypto: hash: add afalg-backend hash support 2017-07-19 10:11:05 +01:00
hmac-gcrypt.c qapi: Mechanically convert FOO_lookup[...] to FOO_str(...) 2017-09-04 13:09:13 +02:00
hmac-glib.c qapi: Mechanically convert FOO_lookup[...] to FOO_str(...) 2017-09-04 13:09:13 +02:00
hmac-nettle.c qapi: Mechanically convert FOO_lookup[...] to FOO_str(...) 2017-09-04 13:09:13 +02:00
hmac.c crypto: afalg: fix a NULL pointer dereference 2017-11-08 11:05:09 +00:00
hmacpriv.h crypto: hmac: add af_alg-backend hmac support 2017-07-19 10:11:05 +01:00
init.c crypto: qcrypto_random_bytes() now works on windows w/o any other crypto libs 2017-05-09 14:41:47 +01:00
ivgen-essiv.c crypto: fix leak in ivgen essiv init 2017-02-27 13:37:14 +00:00
ivgen-essiv.h
ivgen-plain64.c include/crypto: Include qapi-types.h or qemu/bswap.h instead of qemu-common.h 2016-03-22 22:20:16 +01:00
ivgen-plain64.h
ivgen-plain.c include/crypto: Include qapi-types.h or qemu/bswap.h instead of qemu-common.h 2016-03-22 22:20:16 +01:00
ivgen-plain.h
ivgen.c include/qemu/osdep.h: Don't include qapi/error.h 2016-03-22 22:20:15 +01:00
ivgenpriv.h Clean up header guards that don't match their file name 2016-07-12 16:19:16 +02:00
Makefile.objs crypto: hash: add afalg-backend hash support 2017-07-19 10:11:05 +01:00
pbkdf-gcrypt.c qapi: Mechanically convert FOO_lookup[...] to FOO_str(...) 2017-09-04 13:09:13 +02:00
pbkdf-nettle.c qapi: Mechanically convert FOO_lookup[...] to FOO_str(...) 2017-09-04 13:09:13 +02:00
pbkdf-stub.c crypto: use uint64_t for pbkdf iteration count parameters 2016-09-19 16:30:42 +01:00
pbkdf.c crypto: use correct derived key size when timing pbkdf 2016-09-19 16:30:45 +01:00
random-gcrypt.c crypto: qcrypto_random_bytes() now works on windows w/o any other crypto libs 2017-05-09 14:41:47 +01:00
random-gnutls.c crypto: qcrypto_random_bytes() now works on windows w/o any other crypto libs 2017-05-09 14:41:47 +01:00
random-platform.c fix mingw build failure 2017-05-16 15:33:25 +01:00
secret.c qapi: Change data type of the FOO_lookup generated for enum FOO 2017-09-04 13:09:13 +02:00
tlscreds.c qapi: Change data type of the FOO_lookup generated for enum FOO 2017-09-04 13:09:13 +02:00
tlscredsanon.c include/qemu/osdep.h: Don't include qapi/error.h 2016-03-22 22:20:15 +01:00
tlscredspriv.h Clean up header guards that don't match their file name 2016-07-12 16:19:16 +02:00
tlscredsx509.c crypto: fix building complaint 2016-09-12 12:00:52 +01:00
tlssession.c crypto: add trace points for TLS cert verification 2016-09-19 16:30:46 +01:00
trace-events docs: fix broken paths to docs/devel/tracing.txt 2017-07-31 13:12:53 +03:00
xts.c crypto: import an implementation of the XTS cipher mode 2016-03-17 14:41:15 +00:00