ec150c7e09
Back in 2016, we discussed[1] rules for headers, and these were
generally liked:
1. Have a carefully curated header that's included everywhere first. We
got that already thanks to Peter: osdep.h.
2. Headers should normally include everything they need beyond osdep.h.
If exceptions are needed for some reason, they must be documented in
the header. If all that's needed from a header is typedefs, put
those into qemu/typedefs.h instead of including the header.
3. Cyclic inclusion is forbidden.
This patch gets include/ closer to obeying 2.
It's actually extracted from my "[RFC] Baby steps towards saner
headers" series[2], which demonstrates a possible path towards
checking 2 automatically. It passes the RFC test there.
[1] Message-ID: <87h9g8j57d.fsf@blackfin.pond.sub.org>
https://lists.nongnu.org/archive/html/qemu-devel/2016-03/msg03345.html
[2] Message-Id: <20190711122827.18970-1-armbru@redhat.com>
https://lists.nongnu.org/archive/html/qemu-devel/2019-07/msg02715.html
Signed-off-by: Markus Armbruster <armbru@redhat.com>
Reviewed-by: Alistair Francis <alistair.francis@wdc.com>
Message-Id: <20190812052359.30071-2-armbru@redhat.com>
Tested-by: Philippe Mathieu-Daudé <philmd@redhat.com>
56 lines
1.4 KiB
C
56 lines
1.4 KiB
C
/*
|
|
* Raspberry Pi emulation (c) 2012 Gregory Estrade
|
|
* Upstreaming code cleanup [including bcm2835_*] (c) 2013 Jan Petrous
|
|
*
|
|
* Rasperry Pi 2 emulation and refactoring Copyright (c) 2015, Microsoft
|
|
* Written by Andrew Baumann
|
|
*
|
|
* This code is licensed under the GNU GPLv2 and later.
|
|
*/
|
|
|
|
#ifndef BCM2836_H
|
|
#define BCM2836_H
|
|
|
|
#include "hw/arm/bcm2835_peripherals.h"
|
|
#include "hw/intc/bcm2836_control.h"
|
|
#include "target/arm/cpu.h"
|
|
|
|
#define TYPE_BCM283X "bcm283x"
|
|
#define BCM283X(obj) OBJECT_CHECK(BCM283XState, (obj), TYPE_BCM283X)
|
|
|
|
#define BCM283X_NCPUS 4
|
|
|
|
/* These type names are for specific SoCs; other than instantiating
|
|
* them, code using these devices should always handle them via the
|
|
* BCM283x base class, so they have no BCM2836(obj) etc macros.
|
|
*/
|
|
#define TYPE_BCM2836 "bcm2836"
|
|
#define TYPE_BCM2837 "bcm2837"
|
|
|
|
typedef struct BCM283XState {
|
|
/*< private >*/
|
|
DeviceState parent_obj;
|
|
/*< public >*/
|
|
|
|
char *cpu_type;
|
|
uint32_t enabled_cpus;
|
|
|
|
ARMCPU cpus[BCM283X_NCPUS];
|
|
BCM2836ControlState control;
|
|
BCM2835PeripheralState peripherals;
|
|
} BCM283XState;
|
|
|
|
typedef struct BCM283XInfo BCM283XInfo;
|
|
|
|
typedef struct BCM283XClass {
|
|
DeviceClass parent_class;
|
|
const BCM283XInfo *info;
|
|
} BCM283XClass;
|
|
|
|
#define BCM283X_CLASS(klass) \
|
|
OBJECT_CLASS_CHECK(BCM283XClass, (klass), TYPE_BCM283X)
|
|
#define BCM283X_GET_CLASS(obj) \
|
|
OBJECT_GET_CLASS(BCM283XClass, (obj), TYPE_BCM283X)
|
|
|
|
#endif /* BCM2836_H */
|