ec150c7e09
Back in 2016, we discussed[1] rules for headers, and these were
generally liked:
1. Have a carefully curated header that's included everywhere first. We
got that already thanks to Peter: osdep.h.
2. Headers should normally include everything they need beyond osdep.h.
If exceptions are needed for some reason, they must be documented in
the header. If all that's needed from a header is typedefs, put
those into qemu/typedefs.h instead of including the header.
3. Cyclic inclusion is forbidden.
This patch gets include/ closer to obeying 2.
It's actually extracted from my "[RFC] Baby steps towards saner
headers" series[2], which demonstrates a possible path towards
checking 2 automatically. It passes the RFC test there.
[1] Message-ID: <87h9g8j57d.fsf@blackfin.pond.sub.org>
https://lists.nongnu.org/archive/html/qemu-devel/2016-03/msg03345.html
[2] Message-Id: <20190711122827.18970-1-armbru@redhat.com>
https://lists.nongnu.org/archive/html/qemu-devel/2019-07/msg02715.html
Signed-off-by: Markus Armbruster <armbru@redhat.com>
Reviewed-by: Alistair Francis <alistair.francis@wdc.com>
Message-Id: <20190812052359.30071-2-armbru@redhat.com>
Tested-by: Philippe Mathieu-Daudé <philmd@redhat.com>
65 lines
1.6 KiB
C
65 lines
1.6 KiB
C
/*
|
|
* ASPEED AST2400 I2C Controller
|
|
*
|
|
* Copyright (C) 2016 IBM Corp.
|
|
*
|
|
* This program is free software; you can redistribute it and/or modify
|
|
* it under the terms of the GNU General Public License as published by
|
|
* the Free Software Foundation; either version 2 of the License, or
|
|
* (at your option) any later version.
|
|
*
|
|
* This program is distributed in the hope that it will be useful,
|
|
* but WITHOUT ANY WARRANTY; without even the implied warranty of
|
|
* MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
|
|
* GNU General Public License for more details.
|
|
*
|
|
* You should have received a copy of the GNU General Public License along
|
|
* with this program; if not, write to the Free Software Foundation, Inc.,
|
|
* 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA.
|
|
*/
|
|
|
|
#ifndef ASPEED_I2C_H
|
|
#define ASPEED_I2C_H
|
|
|
|
#include "hw/i2c/i2c.h"
|
|
#include "hw/sysbus.h"
|
|
|
|
#define TYPE_ASPEED_I2C "aspeed.i2c"
|
|
#define ASPEED_I2C(obj) \
|
|
OBJECT_CHECK(AspeedI2CState, (obj), TYPE_ASPEED_I2C)
|
|
|
|
#define ASPEED_I2C_NR_BUSSES 14
|
|
|
|
struct AspeedI2CState;
|
|
|
|
typedef struct AspeedI2CBus {
|
|
struct AspeedI2CState *controller;
|
|
|
|
MemoryRegion mr;
|
|
|
|
I2CBus *bus;
|
|
uint8_t id;
|
|
|
|
uint32_t ctrl;
|
|
uint32_t timing[2];
|
|
uint32_t intr_ctrl;
|
|
uint32_t intr_status;
|
|
uint32_t cmd;
|
|
uint32_t buf;
|
|
} AspeedI2CBus;
|
|
|
|
typedef struct AspeedI2CState {
|
|
SysBusDevice parent_obj;
|
|
|
|
MemoryRegion iomem;
|
|
qemu_irq irq;
|
|
|
|
uint32_t intr_status;
|
|
|
|
AspeedI2CBus busses[ASPEED_I2C_NR_BUSSES];
|
|
} AspeedI2CState;
|
|
|
|
I2CBus *aspeed_i2c_get_bus(DeviceState *dev, int busnr);
|
|
|
|
#endif /* ASPEED_I2C_H */
|