Yajun Wu bd437c960f vhost-user: Fix out of order vring host notification handling ... vhost backend sends host notification for every VQ. If backend creates VQs in parallel, the VHOST_USER_SLAVE_VRING_HOST_NOTIFIER_MSG may arrive to QEMU in different order than incremental queue index order. For example VQ 1's message arrive earlier than VQ 0's: After alloc VhostUserHostNotifier for VQ 1. GPtrArray becomes [ nil, VQ1 pointer ] After alloc VhostUserHostNotifier for VQ 0. GPtrArray becomes [ VQ0 pointer, nil, VQ1 pointer ] This is wrong. fetch_notifier will return NULL for VQ 1 in vhost_user_get_vring_base, causes host notifier miss removal(leak). The fix is to remove current element from GPtrArray, make the right position for element to insert. Fixes: 503e355465 ("virtio/vhost-user: dynamically assign VhostUserHostNotifiers") Signed-off-by: Yajun Wu <yajunw@nvidia.com> Acked-by: Parav Pandit <parav@nvidia.com> Message-Id: <20221018023651.1359420-1-yajunw@nvidia.com> Reviewed-by: Alex Bennée <alex.bennee@linaro.org> Reviewed-by: Michael S. Tsirkin <mst@redhat.com> Signed-off-by: Michael S. Tsirkin <mst@redhat.com>		2022-11-07 13:12:20 -05:00
..
Kconfig
meson.build
trace-events
trace.h
vhost-backend.c
vhost-iova-tree.c
vhost-iova-tree.h
vhost-scsi-pci.c
vhost-shadow-virtqueue.c	vhost: Accept event idx flag	2022-10-28 13:28:52 +08:00
vhost-shadow-virtqueue.h
vhost-stub.c
vhost-user-blk-pci.c
vhost-user-fs-pci.c
vhost-user-fs.c
vhost-user-gpio-pci.c
vhost-user-gpio.c
vhost-user-i2c-pci.c
vhost-user-i2c.c
vhost-user-input-pci.c
vhost-user-rng-pci.c
vhost-user-rng.c
vhost-user-scsi-pci.c
vhost-user-vsock-pci.c
vhost-user-vsock.c
vhost-user.c	vhost-user: Fix out of order vring host notification handling	2022-11-07 13:12:20 -05:00
vhost-vdpa.c
vhost-vsock-common.c
vhost-vsock-pci.c
vhost-vsock.c
vhost.c	vhost: expose vhost_virtqueue_stop()	2022-11-07 13:12:20 -05:00
virtio-9p-pci.c
virtio-balloon-pci.c
virtio-balloon.c
virtio-blk-pci.c
virtio-bus.c
virtio-crypto-pci.c
virtio-crypto.c	virtio-crypto: Support asynchronous mode	2022-11-02 06:56:32 -04:00
virtio-input-host-pci.c
virtio-input-pci.c
virtio-iommu-pci.c	hw/virtio/virtio-iommu-pci: Enforce the device is plugged on the root bus	2022-11-07 13:12:19 -05:00
virtio-iommu.c
virtio-mem-pci.c	pci-ids: drop PCI_DEVICE_ID_VIRTIO_MEM	2022-10-12 12:01:11 +02:00
virtio-mem-pci.h
virtio-mem.c	util: Make qemu_prealloc_mem() optionally consume a ThreadContext	2022-10-27 11:00:56 +02:00
virtio-mmio.c
virtio-net-pci.c
virtio-pci.c	virtio-pci: support queue enable	2022-11-07 13:12:20 -05:00
virtio-pmem-pci.c	pci-ids: drop PCI_DEVICE_ID_VIRTIO_PMEM	2022-10-12 12:01:11 +02:00
virtio-pmem-pci.h
virtio-pmem.c
virtio-rng-pci.c	virtio-rng-pci: Allow setting nvectors, so we can use MSI-X	2022-11-07 13:12:20 -05:00
virtio-rng.c
virtio-scsi-pci.c
virtio-serial-pci.c
virtio-stub.c	qmp: add QMP command x-query-virtio-queue-element	2022-10-09 16:38:45 -04:00
virtio.c	virtio: introduce virtio_queue_enable()	2022-11-07 13:12:20 -05:00