qemu/qobject at 57b7bdf426445d8356171135308dfe6d7d5fb612 - qemu

History

Markus Armbruster 00382fa851 json: Fix to reject duplicate object member names

The JSON parser happily accepts duplicate object member names.  The
last value wins.  Reproducer #1:

    $ qemu-system-x86_64 -qmp stdio
    {"QMP": {"version": {"qemu": {"micro": 93, "minor": 0, "major": 3},
    "package": "v3.1.0-rc3-7-g87a45d86ed"}, "capabilities": []}}
    {'execute':'qmp_capabilities'}
    {"return": {}}
    {'execute':'blockdev-add','arguments':{'driver':'null-co',
     'node-name':'foo','node-name':'bar'}}
    {"return": {}}
    {'execute':'query-named-block-nodes'}
    {"return": [{ [...] "node-name": "bar" [...] }]}

Reproducer #2 is iotest 229.

Fix the parser to reject duplicates, and fix iotest 229 not to use
them.

Reported-by: Max Reitz <mreitz@redhat.com>
Signed-off-by: Markus Armbruster <armbru@redhat.com>
Message-Id: <20181206121743.20762-1-armbru@redhat.com>
Reviewed-by: Daniel P. Berrangé <berrange@redhat.com>
Reviewed-by: Philippe Mathieu-Daudé <philmd@redhat.com>
[Trailing whitespace tidied up]
Signed-off-by: Markus Armbruster <armbru@redhat.com>

2018-12-13 19:20:11 +01:00

block-qdict.c

qobject: Catch another straggler for use of qdict_put_str()

2018-10-26 17:17:32 +02:00

json-lexer.c

json: Eliminate lexer state IN_WHITESPACE, pseudo-token JSON_SKIP

2018-09-24 18:08:07 +02:00

json-parser-int.h

json: Eliminate lexer state IN_WHITESPACE, pseudo-token JSON_SKIP

2018-09-24 18:08:07 +02:00

json-parser.c

json: Fix to reject duplicate object member names