6c2be133a7
Depending on the host abi, float16, aka uint16_t, values are passed and returned either zero-extended in the host register or with garbage at the top of the host register. The tcg code generator has so far been assuming garbage, as that matches the x86 abi, but this is incorrect for other host abis. Further, target/arm has so far been assuming zero-extended results, so that it may store the 16-bit value into a 32-bit slot with the high 16-bits already clear. Rectify both problems by mapping "f16" in the helper definition to uint32_t instead of (a typedef for) uint16_t. This forces the host compiler to assume garbage in the upper 16 bits on input and to zero-extend the result on output. Cc: qemu-stable@nongnu.org Signed-off-by: Richard Henderson <richard.henderson@linaro.org> Reviewed-by: Philippe Mathieu-Daudé <f4bug@amsat.org> Tested-by: Laurent Desnogues <laurent.desnogues@gmail.com> Message-id: 20180522175629.24932-1-richard.henderson@linaro.org Reviewed-by: Peter Maydell <peter.maydell@linaro.org> Signed-off-by: Peter Maydell <peter.maydell@linaro.org>
137 lines
4.5 KiB
C
137 lines
4.5 KiB
C
/* Helper file for declaring TCG helper functions.
|
|
Used by other helper files.
|
|
|
|
Targets should use DEF_HELPER_N and DEF_HELPER_FLAGS_N to declare helper
|
|
functions. Names should be specified without the helper_ prefix, and
|
|
the return and argument types specified. 3 basic types are understood
|
|
(i32, i64 and ptr). Additional aliases are provided for convenience and
|
|
to match the types used by the C helper implementation.
|
|
|
|
The target helper.h should be included in all files that use/define
|
|
helper functions. THis will ensure that function prototypes are
|
|
consistent. In addition it should be included an extra two times for
|
|
helper.c, defining:
|
|
GEN_HELPER 1 to produce op generation functions (gen_helper_*)
|
|
GEN_HELPER 2 to do runtime registration helper functions.
|
|
*/
|
|
|
|
#ifndef EXEC_HELPER_HEAD_H
|
|
#define EXEC_HELPER_HEAD_H
|
|
|
|
#define HELPER(name) glue(helper_, name)
|
|
|
|
/* Some types that make sense in C, but not for TCG. */
|
|
#define dh_alias_i32 i32
|
|
#define dh_alias_s32 i32
|
|
#define dh_alias_int i32
|
|
#define dh_alias_i64 i64
|
|
#define dh_alias_s64 i64
|
|
#define dh_alias_f16 i32
|
|
#define dh_alias_f32 i32
|
|
#define dh_alias_f64 i64
|
|
#define dh_alias_ptr ptr
|
|
#define dh_alias_void void
|
|
#define dh_alias_noreturn noreturn
|
|
#define dh_alias(t) glue(dh_alias_, t)
|
|
|
|
#define dh_ctype_i32 uint32_t
|
|
#define dh_ctype_s32 int32_t
|
|
#define dh_ctype_int int
|
|
#define dh_ctype_i64 uint64_t
|
|
#define dh_ctype_s64 int64_t
|
|
#define dh_ctype_f16 uint32_t
|
|
#define dh_ctype_f32 float32
|
|
#define dh_ctype_f64 float64
|
|
#define dh_ctype_ptr void *
|
|
#define dh_ctype_void void
|
|
#define dh_ctype_noreturn void QEMU_NORETURN
|
|
#define dh_ctype(t) dh_ctype_##t
|
|
|
|
#ifdef NEED_CPU_H
|
|
# ifdef TARGET_LONG_BITS
|
|
# if TARGET_LONG_BITS == 32
|
|
# define dh_alias_tl i32
|
|
# else
|
|
# define dh_alias_tl i64
|
|
# endif
|
|
# endif
|
|
# define dh_alias_env ptr
|
|
# define dh_ctype_tl target_ulong
|
|
# define dh_ctype_env CPUArchState *
|
|
#endif
|
|
|
|
/* We can't use glue() here because it falls foul of C preprocessor
|
|
recursive expansion rules. */
|
|
#define dh_retvar_decl0_void void
|
|
#define dh_retvar_decl0_noreturn void
|
|
#define dh_retvar_decl0_i32 TCGv_i32 retval
|
|
#define dh_retvar_decl0_i64 TCGv_i64 retval
|
|
#define dh_retvar_decl0_ptr TCGv_ptr retval
|
|
#define dh_retvar_decl0(t) glue(dh_retvar_decl0_, dh_alias(t))
|
|
|
|
#define dh_retvar_decl_void
|
|
#define dh_retvar_decl_noreturn
|
|
#define dh_retvar_decl_i32 TCGv_i32 retval,
|
|
#define dh_retvar_decl_i64 TCGv_i64 retval,
|
|
#define dh_retvar_decl_ptr TCGv_ptr retval,
|
|
#define dh_retvar_decl(t) glue(dh_retvar_decl_, dh_alias(t))
|
|
|
|
#define dh_retvar_void NULL
|
|
#define dh_retvar_noreturn NULL
|
|
#define dh_retvar_i32 tcgv_i32_temp(retval)
|
|
#define dh_retvar_i64 tcgv_i64_temp(retval)
|
|
#define dh_retvar_ptr tcgv_ptr_temp(retval)
|
|
#define dh_retvar(t) glue(dh_retvar_, dh_alias(t))
|
|
|
|
#define dh_is_64bit_void 0
|
|
#define dh_is_64bit_noreturn 0
|
|
#define dh_is_64bit_i32 0
|
|
#define dh_is_64bit_i64 1
|
|
#define dh_is_64bit_ptr (sizeof(void *) == 8)
|
|
#define dh_is_64bit(t) glue(dh_is_64bit_, dh_alias(t))
|
|
|
|
#define dh_is_signed_void 0
|
|
#define dh_is_signed_noreturn 0
|
|
#define dh_is_signed_i32 0
|
|
#define dh_is_signed_s32 1
|
|
#define dh_is_signed_i64 0
|
|
#define dh_is_signed_s64 1
|
|
#define dh_is_signed_f16 0
|
|
#define dh_is_signed_f32 0
|
|
#define dh_is_signed_f64 0
|
|
#define dh_is_signed_tl 0
|
|
#define dh_is_signed_int 1
|
|
/* ??? This is highly specific to the host cpu. There are even special
|
|
extension instructions that may be required, e.g. ia64's addp4. But
|
|
for now we don't support any 64-bit targets with 32-bit pointers. */
|
|
#define dh_is_signed_ptr 0
|
|
#define dh_is_signed_env dh_is_signed_ptr
|
|
#define dh_is_signed(t) dh_is_signed_##t
|
|
|
|
#define dh_sizemask(t, n) \
|
|
((dh_is_64bit(t) << (n*2)) | (dh_is_signed(t) << (n*2+1)))
|
|
|
|
#define dh_arg(t, n) \
|
|
glue(glue(tcgv_, dh_alias(t)), _temp)(glue(arg, n))
|
|
|
|
#define dh_arg_decl(t, n) glue(TCGv_, dh_alias(t)) glue(arg, n)
|
|
|
|
#define DEF_HELPER_0(name, ret) \
|
|
DEF_HELPER_FLAGS_0(name, 0, ret)
|
|
#define DEF_HELPER_1(name, ret, t1) \
|
|
DEF_HELPER_FLAGS_1(name, 0, ret, t1)
|
|
#define DEF_HELPER_2(name, ret, t1, t2) \
|
|
DEF_HELPER_FLAGS_2(name, 0, ret, t1, t2)
|
|
#define DEF_HELPER_3(name, ret, t1, t2, t3) \
|
|
DEF_HELPER_FLAGS_3(name, 0, ret, t1, t2, t3)
|
|
#define DEF_HELPER_4(name, ret, t1, t2, t3, t4) \
|
|
DEF_HELPER_FLAGS_4(name, 0, ret, t1, t2, t3, t4)
|
|
#define DEF_HELPER_5(name, ret, t1, t2, t3, t4, t5) \
|
|
DEF_HELPER_FLAGS_5(name, 0, ret, t1, t2, t3, t4, t5)
|
|
#define DEF_HELPER_6(name, ret, t1, t2, t3, t4, t5, t6) \
|
|
DEF_HELPER_FLAGS_6(name, 0, ret, t1, t2, t3, t4, t5, t6)
|
|
|
|
/* MAX_OPC_PARAM_IARGS must be set to n if last entry is DEF_HELPER_FLAGS_n. */
|
|
|
|
#endif /* EXEC_HELPER_HEAD_H */
|