Gerd Hoffmann
51a0909914
spice: fix coverity reported defect in display code
Report:
1. Condition surface, taking false branch
406 if (surface && ssd->surface &&
407 surface_width(surface) == pixman_image_get_width(ssd->surface) &&
408 surface_height(surface) == pixman_image_get_height(ssd->surface)) {
409 /* no-resize fast path: just swap backing store */
...
10. alias_transfer: Assigning: ssd->ds = surface.
440 ssd->ds = surface;
11. var_deref_op: Dereferencing null pointer ssd->ds.
CID 1264334 (#1 of 1): Dereference after null check (FORWARD_NULL)
441 ssd->surface = pixman_image_ref(ssd->ds->image);
Fix:
Move code block dereferencing ssd->ds into the already existing
if (ssd->ds) { ... } block.
Cc: Paolo Bonzini <pbonzini@redhat.com>
Signed-off-by: Gerd Hoffmann <kraxel@redhat.com>
2015-01-22 11:18:41 +01:00
..
2014-09-22 11:39:45 +01:00
2015-01-19 13:33:26 +01:00
2015-01-19 13:33:26 +01:00
2014-10-02 09:58:14 +02:00
2014-11-25 17:03:31 +00:00
2014-12-10 10:08:12 +01:00
2014-12-17 12:44:01 +01:00
2015-01-19 13:33:26 +01:00
2015-01-19 13:33:26 +01:00
2014-12-17 12:43:27 +01:00
2014-09-16 08:07:05 +02:00
2015-01-19 13:33:26 +01:00
2015-01-19 13:33:26 +01:00
2015-01-22 11:18:41 +01:00
2015-01-22 11:18:41 +01:00
2014-12-10 10:08:12 +01:00
2014-09-18 08:01:53 +02:00
2015-01-19 13:33:26 +01:00