qemu/target-sparc
Igor Kovalenko 5b0f0bec71 sparc64: fix helper_st_asi little endian case typo
On Sun, Jul 12, 2009 at 12:43 AM, Stuart Brady<sdbrady@ntlworld.com> wrote:
> On Sat, Jul 11, 2009 at 10:22:18PM +0400, Igor Kovalenko wrote:
>> It is clear that intention is to byte-swap value to be written, not
>> the target address.
>
> @@ -1949,13 +1949,13 @@ void helper_st_asi(target_ulong addr, ta
>     case 0x89: // Secondary LE
>         switch(size) {
>         case 2:
> -            addr = bswap16(addr);
> +            addr = bswap16(val);
>             ^^^^
> Shouldn't that be 'val = bswap16(val)' (and likewise for the 32-bit and
> 64-bit cases)?  Also needs a 'signed-off-by:'...
>
> Cheers,
> --
> Stuart Brady
>

Thanks, that part I did not runtime-tested.
Not sure if those asi stores are of any use for user-mode emulator.

Please find attached the corrected version.

Signed-off-by: igor.v.kovalenko@gmail.com

--
Kind regards,
Igor V. Kovalenko
2009-07-12 07:44:11 +00:00
..
cpu.h Hardware convenience library 2009-05-19 16:17:58 +01:00
exec.h qemu: per-arch cpu_has_work (Marcelo Tosatti) 2009-04-24 18:03:20 +00:00
helper.c sparc64: unify mmu tag matching code 2009-07-12 07:41:42 +00:00
helper.h Use dynamical computation for condition codes 2009-05-10 07:19:11 +00:00
machine.c Convert machine registration to use module init functions 2009-05-21 08:47:55 -05:00
op_helper.c sparc64: fix helper_st_asi little endian case typo 2009-07-12 07:44:11 +00:00
TODO Remove unnecessary trailing newlines 2008-12-13 09:32:43 +00:00
translate.c Use correct type for SPARC cpu_cc_op 2009-06-06 02:54:03 +01:00