438c78dab7
Currently tests/acpi-test-data contains data files used by the bios-tables-test, and configure individually symlinks those data files into the build directory using a wildcard. Using a wildcard like this is a bad idea, because if a new data file is added, nothing causes configure to be rerun, and so no symlink is added for the new file. This can cause tests to spuriously fail when they can't find their data. Instead, it's better to symlink an entire directory of data files. We already have such a directory: tests/data. Move the data files from tests/acpi-test-data/ to tests/data/acpi/, and remove the unnecessary symlinking. We can remove entirely the note in rebuild-expected-aml.sh about copying any new data files, because now they will be in the source directory, not the build directory, and no copying is required. (We can't just change the existing tests/acpi-test-data/ to being a symlinked directory, because if we did that and a developer switched git branches from one after that change to one before it then configure would end up trashing all the test files by making them symlinks to themselves. Changing their path avoids this annoyance.) Signed-off-by: Peter Maydell <peter.maydell@linaro.org> Reviewed-by: Michael S. Tsirkin <mst@redhat.com> Signed-off-by: Michael S. Tsirkin <mst@redhat.com>
35 lines
910 B
Bash
Executable File
35 lines
910 B
Bash
Executable File
#! /bin/bash
|
|
|
|
#
|
|
# Rebuild expected AML files for acpi unit-test
|
|
#
|
|
# Copyright (c) 2013 Red Hat Inc.
|
|
#
|
|
# Authors:
|
|
# Marcel Apfelbaum <marcel.a@redhat.com>
|
|
#
|
|
# This work is licensed under the terms of the GNU GPLv2.
|
|
# See the COPYING.LIB file in the top-level directory.
|
|
|
|
qemu=
|
|
|
|
if [ -e x86_64-softmmu/qemu-system-x86_64 ]; then
|
|
qemu="x86_64-softmmu/qemu-system-x86_64"
|
|
elif [ -e i386-softmmu/qemu-system-i386 ]; then
|
|
qemu="i386-softmmu/qemu-system-i386"
|
|
else
|
|
echo "Run 'make' to build the qemu exectutable!"
|
|
echo "Run this script from the build directory."
|
|
exit 1;
|
|
fi
|
|
|
|
if [ ! -e "tests/bios-tables-test" ]; then
|
|
echo "Test: bios-tables-test is required! Run make check before this script."
|
|
echo "Run this script from the build directory."
|
|
exit 1;
|
|
fi
|
|
|
|
TEST_ACPI_REBUILD_AML=y QTEST_QEMU_BINARY=$qemu tests/bios-tables-test
|
|
|
|
echo "The files were rebuilt and can be added to git."
|