Go to file
Peter Xu 43044ac0ee migration: Make from_dst_file accesses thread-safe
Accessing from_dst_file is potentially racy in current code base like below:

  if (s->from_dst_file)
    do_something(s->from_dst_file);

Because from_dst_file can be reset right after the check in another
thread (rp_thread).  One example is migrate_fd_cancel().

Use the same qemu_file_lock to protect it too, just like to_dst_file.

When it's safe to access without lock, comment it.

There's one special reference in migration_thread() that can be replaced by
the newly introduced rp_thread_created flag.

Reported-by: Dr. David Alan Gilbert <dgilbert@redhat.com>
Reviewed-by: Dr. David Alan Gilbert <dgilbert@redhat.com>
Signed-off-by: Peter Xu <peterx@redhat.com>
Reviewed-by: Lukas Straub <lukasstraub2@web.de>
Message-Id: <20210722175841.938739-3-peterx@redhat.com>
Signed-off-by: Dr. David Alan Gilbert <dgilbert@redhat.com>
  with Peter's fixup
2021-07-26 12:44:46 +01:00
.github Update documentation to refer to new location for issues 2021-06-21 05:43:11 +02:00
.gitlab/issue_templates GitLab: Add "Feature Request" issue template. 2021-06-25 10:08:37 +01:00
.gitlab-ci.d gitlab: only let pages be published from default branch 2021-07-23 16:02:56 +02:00
accel accel/tcg: Record singlestep_enabled in tb->cflags 2021-07-21 07:47:05 -10:00
audio modules: add audio module annotations 2021-07-09 18:20:27 +02:00
authz configure, meson: convert pam detection to meson 2021-06-25 10:54:10 +02:00
backends vhost: Add Error parameter to vhost_dev_init() 2021-06-30 13:15:44 +02:00
block iotests: Improve and rename test 291 to qemu-img-bitmap 2021-07-21 14:14:41 -05:00
bsd-user
capstone@f8b1b83301
chardev chardev-spice: add missing module_obj directive 2021-07-22 14:44:47 +02:00
configs hw/tricore: fix inclusion of tricore_testboard 2021-07-20 20:10:21 +02:00
contrib plugins/cache: Added FIFO and LRU eviction policies 2021-07-14 15:54:13 +01:00
crypto crypto: add gnutls pbkdf provider 2021-07-14 14:15:52 +01:00
disas
docs qemu-img: Add --skip-broken-bitmaps for 'convert --bitmaps' 2021-07-21 14:14:41 -05:00
dtc@85e5d83984
dump
ebpf
fpu softfloat: Use _Generic instead of QEMU_GENERIC 2021-06-16 15:03:26 +02:00
fsdev
gdb-xml
hw vga: fixes for qxl and virtio-gpu 2021-07-23 12:16:12 +01:00
include Bugfixes. 2021-07-24 11:04:57 +01:00
io io: use GDateTime for formatting timestamp for websock headers 2021-07-14 14:15:52 +01:00
libdecnumber
linux-headers linux-headers: Update 2021-07-09 11:01:06 +10:00
linux-user qemu/atomic: Add aligned_{int64,uint64}_t types 2021-07-21 07:45:38 -10:00
meson@776acd2a80
migration migration: Make from_dst_file accesses thread-safe 2021-07-26 12:44:46 +01:00
monitor iothread: add aio-max-batch parameter 2021-07-21 13:47:50 +01:00
nbd nbd/client-connection: add option for non-blocking connection attempt 2021-06-18 12:21:22 -05:00
net
pc-bios pseries: Update SLOF firmware image 2021-07-13 10:04:30 +10:00
plugins trace: Fold mem-internal.h into mem.h 2021-07-21 07:45:38 -10:00
po
python python: Configure tox to skip missing interpreters 2021-07-13 15:44:16 -04:00
qapi qapi: introduce forwarding visitor 2021-07-23 18:17:17 +02:00
qga qga-win: Add support of Windows Server 2022 in get-osinfo command 2021-07-12 11:26:47 -05:00
qobject
qom qom: use correct field name when getting/setting alias properties 2021-07-23 18:17:17 +02:00
replay
roms pseries: Update SLOF firmware image 2021-07-13 10:04:30 +10:00
scripts QAPI patches patches for 2021-07-15 2021-07-16 10:56:03 +01:00
scsi
semihosting
slirp@8f43a99191
softmmu vga: fixes for qxl and virtio-gpu 2021-07-23 12:16:12 +01:00
storage-daemon
stubs meson: fix condition for io_uring stubs 2021-07-14 14:31:48 +01:00
subprojects/libvhost-user
target i386: do not call cpudef-only models functions for max, host, base 2021-07-23 15:47:13 +02:00
tcg accel/tcg: Add CF_NO_GOTO_TB and CF_NO_GOTO_PTR 2021-07-21 07:47:04 -10:00
tests tests/qtest/migration-test.c: use 127.0.0.1 instead of 0 2021-07-26 12:17:16 +01:00
tools virtiofsd: Add missing newline in error message 2021-07-09 18:42:46 +02:00
trace trace: Fold mem-internal.h into mem.h 2021-07-21 07:45:38 -10:00
ui crypto: replace 'des-rfb' cipher with 'des' 2021-07-14 14:15:52 +01:00
util Bugfixes. 2021-07-22 18:32:02 +01:00
.cirrus.yml cirrus: delete FreeBSD and macOS jobs 2021-07-14 14:33:53 +01:00
.dir-locals.el
.editorconfig
.exrc
.gdbinit
.gitattributes
.gitignore
.gitlab-ci.yml
.gitmodules
.gitpublish
.mailmap
.patchew.yml scripts/checkpatch: roll diff tweaking into checkpatch itself 2021-06-25 10:08:33 +01:00
.readthedocs.yml
.travis.yml hw/usb/ccid: remove references to NSS 2021-07-14 14:33:53 +01:00
block.c block: Add option to use driver whitelist even in tools 2021-07-20 13:14:45 +02:00
blockdev-nbd.c block/nbd: Use qcrypto_tls_creds_check_endpoint() 2021-06-29 18:29:47 +01:00
blockdev.c block: Make blockdev-reopen stable API 2021-07-09 13:19:11 +02:00
blockjob.c progressmeter: protect with a mutex 2021-06-25 14:24:24 +03:00
configure Bugfixes. 2021-07-22 18:32:02 +01:00
COPYING
COPYING.LIB
cpu.c accel/tcg: Record singlestep_enabled in tb->cflags 2021-07-21 07:47:05 -10:00
cpus-common.c
disas.c
gdbstub.c
gitdm.config
hmp-commands-info.hx monitor/tcg: move tcg hmp commands to accel/tcg, register them dynamically 2021-07-09 18:21:33 +02:00
hmp-commands.hx
iothread.c iothread: add aio-max-batch parameter 2021-07-21 13:47:50 +01:00
job-qmp.c progressmeter: protect with a mutex 2021-06-25 14:24:24 +03:00
job.c progressmeter: protect with a mutex 2021-06-25 14:24:24 +03:00
Kconfig meson: Introduce target-specific Kconfig 2021-07-09 18:21:34 +02:00
Kconfig.host
LICENSE
MAINTAINERS MAINTAINERS: Add memory_mapping.h and memory_mapping.c to "Memory API" 2021-07-23 15:54:37 +02:00
Makefile Makefile: Remove /usr/bin/env wrapper from the SHELL variable 2021-07-05 19:20:46 +02:00
memory_ldst.c.inc
meson_options.txt configure, meson: convert libxml2 detection to meson 2021-07-06 08:33:51 +02:00
meson.build meson: fix dependencies for modinfo #2 2021-07-23 15:45:52 +02:00
module-common.c
os-posix.c
os-win32.c
page-vary-common.c
page-vary.c
qemu-bridge-helper.c
qemu-edid.c
qemu-img-cmds.hx
qemu-img.c qemu-img: Add --skip-broken-bitmaps for 'convert --bitmaps' 2021-07-21 14:14:41 -05:00
qemu-io-cmds.c block: Acquire AioContexts during bdrv_reopen_multiple() 2021-07-09 13:19:11 +02:00
qemu-io.c
qemu-keymap.c
qemu-nbd.c qemu-nbd: Use qcrypto_tls_creds_check_endpoint() 2021-06-29 18:29:49 +01:00
qemu-options.hx iothread: add aio-max-batch parameter 2021-07-21 13:47:50 +01:00
qemu.nsi
qemu.sasl
README.rst Update documentation to refer to new location for issues 2021-06-21 05:43:11 +02:00
replication.c
thunk.c
trace-events cpu: Add breakpoint tracepoints 2021-07-09 21:31:11 -07:00
VERSION Update version for v6.1.0-rc0 release 2021-07-21 17:10:15 +01:00
version.rc

===========
QEMU README
===========

QEMU is a generic and open source machine & userspace emulator and
virtualizer.

QEMU is capable of emulating a complete machine in software without any
need for hardware virtualization support. By using dynamic translation,
it achieves very good performance. QEMU can also integrate with the Xen
and KVM hypervisors to provide emulated hardware while allowing the
hypervisor to manage the CPU. With hypervisor support, QEMU can achieve
near native performance for CPUs. When QEMU emulates CPUs directly it is
capable of running operating systems made for one machine (e.g. an ARMv7
board) on a different machine (e.g. an x86_64 PC board).

QEMU is also capable of providing userspace API virtualization for Linux
and BSD kernel interfaces. This allows binaries compiled against one
architecture ABI (e.g. the Linux PPC64 ABI) to be run on a host using a
different architecture ABI (e.g. the Linux x86_64 ABI). This does not
involve any hardware emulation, simply CPU and syscall emulation.

QEMU aims to fit into a variety of use cases. It can be invoked directly
by users wishing to have full control over its behaviour and settings.
It also aims to facilitate integration into higher level management
layers, by providing a stable command line interface and monitor API.
It is commonly invoked indirectly via the libvirt library when using
open source applications such as oVirt, OpenStack and virt-manager.

QEMU as a whole is released under the GNU General Public License,
version 2. For full licensing details, consult the LICENSE file.


Documentation
=============

Documentation can be found hosted online at
`<https://www.qemu.org/documentation/>`_. The documentation for the
current development version that is available at
`<https://www.qemu.org/docs/master/>`_ is generated from the ``docs/``
folder in the source tree, and is built by `Sphinx
<https://www.sphinx-doc.org/en/master/>_`.


Building
========

QEMU is multi-platform software intended to be buildable on all modern
Linux platforms, OS-X, Win32 (via the Mingw64 toolchain) and a variety
of other UNIX targets. The simple steps to build QEMU are:


.. code-block:: shell

  mkdir build
  cd build
  ../configure
  make

Additional information can also be found online via the QEMU website:

* `<https://qemu.org/Hosts/Linux>`_
* `<https://qemu.org/Hosts/Mac>`_
* `<https://qemu.org/Hosts/W32>`_


Submitting patches
==================

The QEMU source code is maintained under the GIT version control system.

.. code-block:: shell

   git clone https://gitlab.com/qemu-project/qemu.git

When submitting patches, one common approach is to use 'git
format-patch' and/or 'git send-email' to format & send the mail to the
qemu-devel@nongnu.org mailing list. All patches submitted must contain
a 'Signed-off-by' line from the author. Patches should follow the
guidelines set out in the `style section
<https://www.qemu.org/docs/master/devel/style.html>` of
the Developers Guide.

Additional information on submitting patches can be found online via
the QEMU website

* `<https://qemu.org/Contribute/SubmitAPatch>`_
* `<https://qemu.org/Contribute/TrivialPatches>`_

The QEMU website is also maintained under source control.

.. code-block:: shell

  git clone https://gitlab.com/qemu-project/qemu-web.git

* `<https://www.qemu.org/2017/02/04/the-new-qemu-website-is-up/>`_

A 'git-publish' utility was created to make above process less
cumbersome, and is highly recommended for making regular contributions,
or even just for sending consecutive patch series revisions. It also
requires a working 'git send-email' setup, and by default doesn't
automate everything, so you may want to go through the above steps
manually for once.

For installation instructions, please go to

*  `<https://github.com/stefanha/git-publish>`_

The workflow with 'git-publish' is:

.. code-block:: shell

  $ git checkout master -b my-feature
  $ # work on new commits, add your 'Signed-off-by' lines to each
  $ git publish

Your patch series will be sent and tagged as my-feature-v1 if you need to refer
back to it in the future.

Sending v2:

.. code-block:: shell

  $ git checkout my-feature # same topic branch
  $ # making changes to the commits (using 'git rebase', for example)
  $ git publish

Your patch series will be sent with 'v2' tag in the subject and the git tip
will be tagged as my-feature-v2.

Bug reporting
=============

The QEMU project uses GitLab issues to track bugs. Bugs
found when running code built from QEMU git or upstream released sources
should be reported via:

* `<https://gitlab.com/qemu-project/qemu/-/issues>`_

If using QEMU via an operating system vendor pre-built binary package, it
is preferable to report bugs to the vendor's own bug tracker first. If
the bug is also known to affect latest upstream code, it can also be
reported via GitLab.

For additional information on bug reporting consult:

* `<https://qemu.org/Contribute/ReportABug>`_


ChangeLog
=========

For version history and release notes, please visit
`<https://wiki.qemu.org/ChangeLog/>`_ or look at the git history for
more detailed information.


Contact
=======

The QEMU community can be contacted in a number of ways, with the two
main methods being email and IRC

* `<mailto:qemu-devel@nongnu.org>`_
* `<https://lists.nongnu.org/mailman/listinfo/qemu-devel>`_
* #qemu on irc.oftc.net

Information on additional methods of contacting the community can be
found online via the QEMU website:

* `<https://qemu.org/Contribute/StartHere>`_