b0b3db7955
When the vhost notifier is disabled, the userspace handler runs immediately: virtio_pci_set_host_notifier_internal might call virtio_queue_notify_vq. Since the VQ state and the tap backend state aren't recovered yet, this causes "Guest moved used index from XXX to YYY" assertions. The solution is to split out host notifier handling from vhost VQ setup and disable notifiers as our last step when we stop vhost-net. For symmetry enable them first thing on start. Signed-off-by: Michael S. Tsirkin <mst@redhat.com>
53 lines
1.4 KiB
C
53 lines
1.4 KiB
C
#ifndef VHOST_H
|
|
#define VHOST_H
|
|
|
|
#include "hw/hw.h"
|
|
#include "hw/virtio.h"
|
|
|
|
/* Generic structures common for any vhost based device. */
|
|
struct vhost_virtqueue {
|
|
int kick;
|
|
int call;
|
|
void *desc;
|
|
void *avail;
|
|
void *used;
|
|
int num;
|
|
unsigned long long used_phys;
|
|
unsigned used_size;
|
|
void *ring;
|
|
unsigned long long ring_phys;
|
|
unsigned ring_size;
|
|
};
|
|
|
|
typedef unsigned long vhost_log_chunk_t;
|
|
#define VHOST_LOG_PAGE 0x1000
|
|
#define VHOST_LOG_BITS (8 * sizeof(vhost_log_chunk_t))
|
|
#define VHOST_LOG_CHUNK (VHOST_LOG_PAGE * VHOST_LOG_BITS)
|
|
|
|
struct vhost_memory;
|
|
struct vhost_dev {
|
|
CPUPhysMemoryClient client;
|
|
int control;
|
|
struct vhost_memory *mem;
|
|
struct vhost_virtqueue *vqs;
|
|
int nvqs;
|
|
unsigned long long features;
|
|
unsigned long long acked_features;
|
|
unsigned long long backend_features;
|
|
bool started;
|
|
bool log_enabled;
|
|
vhost_log_chunk_t *log;
|
|
unsigned long long log_size;
|
|
bool force;
|
|
};
|
|
|
|
int vhost_dev_init(struct vhost_dev *hdev, int devfd, bool force);
|
|
void vhost_dev_cleanup(struct vhost_dev *hdev);
|
|
bool vhost_dev_query(struct vhost_dev *hdev, VirtIODevice *vdev);
|
|
int vhost_dev_start(struct vhost_dev *hdev, VirtIODevice *vdev);
|
|
void vhost_dev_stop(struct vhost_dev *hdev, VirtIODevice *vdev);
|
|
int vhost_dev_enable_notifiers(struct vhost_dev *hdev, VirtIODevice *vdev);
|
|
void vhost_dev_disable_notifiers(struct vhost_dev *hdev, VirtIODevice *vdev);
|
|
|
|
#endif
|