qemu/target/ppc/translate
Fabiano Rosas 40a3cb9213 target/ppc: Fix lxvx/stxvx facility check
The XT check for the lxvx/stxvx instructions is currently
inverted. This was introduced during the move to decodetree.

>From the ISA:
  Chapter 7. Vector-Scalar Extension Facility
  Load VSX Vector Indexed X-form

  lxvx XT,RA,RB
  if TX=0 & MSR.VSX=0 then VSX_Unavailable()
  if TX=1 & MSR.VEC=0 then Vector_Unavailable()
  ...
  Let XT be the value 32×TX + T.

The code currently does the opposite:

    if (paired || a->rt >= 32) {
        REQUIRE_VSX(ctx);
    } else {
        REQUIRE_VECTOR(ctx);
    }

This was already fixed for lxv/stxv at commit "2cc0e449d1 (target/ppc:
Fix lxv/stxv MSR facility check)", but the indexed forms were missed.

Cc: qemu-stable@nongnu.org
Fixes: 70426b5bb7 ("target/ppc: moved stxvx and lxvx from legacy to decodtree")
Signed-off-by: Fabiano Rosas <farosas@suse.de>
Reviewed-by: Claudio Fontana <cfontana@suse.de>
Acked-by: Ilya Leoshkevich <iii@linux.ibm.com>
Reviewed-by: Fabiano Rosas <farosas@suse.de>
Message-ID: <20240911141651.6914-1-farosas@suse.de>
Signed-off-by: Richard Henderson <richard.henderson@linaro.org>
(cherry picked from commit 8bded2e73e)
Signed-off-by: Michael Tokarev <mjt@tls.msk.ru>
2024-09-28 07:25:08 +03:00
..
branch-impl.c.inc tcg: Rename cpu_env to tcg_env 2023-10-03 08:01:02 -07:00
dfp-impl.c.inc tcg: Rename cpu_env to tcg_env 2023-10-03 08:01:02 -07:00
fixedpoint-impl.c.inc tcg: Rename cpu_env to tcg_env 2023-10-03 08:01:02 -07:00
fp-impl.c.inc tcg: Rename cpu_env to tcg_env 2023-10-03 08:01:02 -07:00
fp-ops.c.inc target/ppc: Move fsqrts to decodetree 2022-09-20 10:54:06 -03:00
processor-ctrl-impl.c.inc tcg: Rename cpu_env to tcg_env 2023-10-03 08:01:02 -07:00
spe-impl.c.inc tcg: Rename cpu_env to tcg_env 2023-10-03 08:01:02 -07:00
spe-ops.c.inc meson: rename included C source files to .c.inc 2020-08-21 06:18:30 -04:00
storage-ctrl-impl.c.inc tcg: Rename cpu_env to tcg_env 2023-10-03 08:01:02 -07:00
vmx-impl.c.inc tcg: Rename cpu_env to tcg_env 2023-10-03 08:01:02 -07:00
vmx-ops.c.inc target/ppc: Move VABSDU[BHW] to decodetree and use gvec 2022-10-28 13:15:22 -03:00
vsx-impl.c.inc target/ppc: Fix lxvx/stxvx facility check 2024-09-28 07:25:08 +03:00
vsx-ops.c.inc target/ppc: Moved XSTSTDC[QDS]P to decodetree 2022-10-28 13:15:22 -03:00