qemu/hw/misc/macio
Markus Armbruster 3d81f594fd macio: Fix to realize "mos6522-cuda" and "mos6522-pmu" devices
cuda_init() creates a "mos6522-cuda" device, but it's never realized.
Affects machines mac99 with via=cuda (default) and g3beige.

pmu_init() creates a "mos6522-pmu" device, but it's never realized.
Affects machine mac99 with via=pmu and via=pmu-adb,

In theory, a device becomes real only on realize.  In practice, the
transition from unreal to real is a fuzzy one.  The work to make a
device real can be spread between realize methods (fine),
instance_init methods (wrong), and board code wiring up the device
(fine as long as it effectively happens on realize).  Depending on
what exactly is done where, a device can work even when we neglect
to realize it.

These two appear to work.  Nevertheless, it's a clear misuse of the
interface.  Even when it works today (more or less by chance), it can
break tomorrow.

Fix by realizing them in cuda_realize() and pmu_realize(),
respectively.

Fixes: 6dca62a000
Cc: Laurent Vivier <laurent@vivier.eu>
Signed-off-by: Markus Armbruster <armbru@redhat.com>
Message-Id: <20200609122339.937862-10-armbru@redhat.com>
2020-06-15 21:36:21 +02:00
..
cuda.c macio: Fix to realize "mos6522-cuda" and "mos6522-pmu" devices 2020-06-15 21:36:21 +02:00
gpio.c qom: Drop parameter @errp of object_property_add() & friends 2020-05-15 07:07:58 +02:00
Kconfig kconfig: introduce kconfig files 2019-03-07 21:45:53 +01:00
mac_dbdma.c Include hw/hw.h exactly where needed 2019-08-16 13:31:52 +02:00
macio.c qom: Drop parameter @errp of object_property_add() & friends 2020-05-15 07:07:58 +02:00
Makefile.objs mac_newworld: add PMU device 2018-06-16 16:32:33 +10:00
pmu.c macio: Fix to realize "mos6522-cuda" and "mos6522-pmu" devices 2020-06-15 21:36:21 +02:00
trace-events trace-events: Delete unused trace points 2019-03-22 16:18:07 +00:00