b66ff2c298
There are many existing qcow2 images that specify a backing file but no format. This has been the source of CVEs in the past, but has become more prominent of a problem now that libvirt has switched to -blockdev. With older -drive, at least the probing was always done by qemu (so the only risk of a changed format between successive boots of a guest was if qemu was upgraded and probed differently). But with newer -blockdev, libvirt must specify a format; if libvirt guesses raw where the image was formatted, this results in data corruption visible to the guest; conversely, if libvirt guesses qcow2 where qemu was using raw, this can result in potential security holes, so modern libvirt instead refuses to use images without explicit backing format. The change in libvirt to reject images without explicit backing format has pointed out that a number of tools have been far too reliant on probing in the past. It's time to set a better example in our own iotests of properly setting this parameter. iotest calls to create, rebase, and convert are all impacted to some degree. It's a bit annoying that we are inconsistent on command line - while all of those accept -o backing_file=...,backing_fmt=..., the shortcuts are different: create and rebase have -b and -F, while convert has -B but no -F. (amend has no shortcuts, but the previous patch just deprecated the use of amend to change backing chains). Signed-off-by: Eric Blake <eblake@redhat.com> Message-Id: <20200706203954.341758-9-eblake@redhat.com> Signed-off-by: Kevin Wolf <kwolf@redhat.com>
182 lines
4.7 KiB
Bash
Executable File
182 lines
4.7 KiB
Bash
Executable File
#!/usr/bin/env bash
|
|
#
|
|
# Test qcow2 lazy refcounts
|
|
#
|
|
# Copyright (C) 2012 Red Hat, Inc.
|
|
# Copyright IBM, Corp. 2010
|
|
#
|
|
# Based on test 038.
|
|
#
|
|
# This program is free software; you can redistribute it and/or modify
|
|
# it under the terms of the GNU General Public License as published by
|
|
# the Free Software Foundation; either version 2 of the License, or
|
|
# (at your option) any later version.
|
|
#
|
|
# This program is distributed in the hope that it will be useful,
|
|
# but WITHOUT ANY WARRANTY; without even the implied warranty of
|
|
# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
|
|
# GNU General Public License for more details.
|
|
#
|
|
# You should have received a copy of the GNU General Public License
|
|
# along with this program. If not, see <http://www.gnu.org/licenses/>.
|
|
#
|
|
|
|
# creator
|
|
owner=stefanha@linux.vnet.ibm.com
|
|
|
|
seq=`basename $0`
|
|
echo "QA output created by $seq"
|
|
|
|
status=1 # failure is the default!
|
|
|
|
_cleanup()
|
|
{
|
|
_cleanup_test_img
|
|
}
|
|
trap "_cleanup; exit \$status" 0 1 2 3 15
|
|
|
|
# get standard environment, filters and checks
|
|
. ./common.rc
|
|
. ./common.filter
|
|
|
|
_supported_fmt qcow2
|
|
_supported_proto file
|
|
_supported_os Linux
|
|
_default_cache_mode writethrough
|
|
_supported_cache_modes writethrough
|
|
# Some of these test cases expect no external data file so that all
|
|
# clusters are part of the qcow2 image and refcounted
|
|
_unsupported_imgopts data_file
|
|
|
|
size=128M
|
|
|
|
echo
|
|
echo "== Checking that image is clean on shutdown =="
|
|
|
|
_make_test_img -o "compat=1.1,lazy_refcounts=on" $size
|
|
|
|
$QEMU_IO -c "write -P 0x5a 0 512" "$TEST_IMG" | _filter_qemu_io
|
|
|
|
# The dirty bit must not be set
|
|
$PYTHON qcow2.py "$TEST_IMG" dump-header | grep incompatible_features
|
|
_check_test_img
|
|
|
|
echo
|
|
echo "== Creating a dirty image file =="
|
|
|
|
_make_test_img -o "compat=1.1,lazy_refcounts=on" $size
|
|
|
|
_NO_VALGRIND \
|
|
$QEMU_IO -c "write -P 0x5a 0 512" \
|
|
-c "sigraise $(kill -l KILL)" "$TEST_IMG" 2>&1 \
|
|
| _filter_qemu_io
|
|
|
|
# The dirty bit must be set
|
|
$PYTHON qcow2.py "$TEST_IMG" dump-header | grep incompatible_features
|
|
_check_test_img
|
|
|
|
echo
|
|
echo "== Read-only access must still work =="
|
|
|
|
$QEMU_IO -r -c "read -P 0x5a 0 512" "$TEST_IMG" | _filter_qemu_io
|
|
|
|
# The dirty bit must be set
|
|
$PYTHON qcow2.py "$TEST_IMG" dump-header | grep incompatible_features
|
|
|
|
echo
|
|
echo "== Repairing the image file must succeed =="
|
|
|
|
_check_test_img -r all
|
|
|
|
# The dirty bit must not be set
|
|
$PYTHON qcow2.py "$TEST_IMG" dump-header | grep incompatible_features
|
|
|
|
echo
|
|
echo "== Data should still be accessible after repair =="
|
|
|
|
$QEMU_IO -c "read -P 0x5a 0 512" "$TEST_IMG" | _filter_qemu_io
|
|
|
|
echo
|
|
echo "== Opening a dirty image read/write should repair it =="
|
|
|
|
_make_test_img -o "compat=1.1,lazy_refcounts=on" $size
|
|
|
|
_NO_VALGRIND \
|
|
$QEMU_IO -c "write -P 0x5a 0 512" \
|
|
-c "sigraise $(kill -l KILL)" "$TEST_IMG" 2>&1 \
|
|
| _filter_qemu_io
|
|
|
|
# The dirty bit must be set
|
|
$PYTHON qcow2.py "$TEST_IMG" dump-header | grep incompatible_features
|
|
|
|
$QEMU_IO -c "write 0 512" "$TEST_IMG" | _filter_qemu_io
|
|
|
|
# The dirty bit must not be set
|
|
$PYTHON qcow2.py "$TEST_IMG" dump-header | grep incompatible_features
|
|
|
|
echo
|
|
echo "== Creating an image file with lazy_refcounts=off =="
|
|
|
|
_make_test_img -o "compat=1.1,lazy_refcounts=off" $size
|
|
|
|
_NO_VALGRIND \
|
|
$QEMU_IO -c "write -P 0x5a 0 512" \
|
|
-c "sigraise $(kill -l KILL)" "$TEST_IMG" 2>&1 \
|
|
| _filter_qemu_io
|
|
|
|
# The dirty bit must not be set since lazy_refcounts=off
|
|
$PYTHON qcow2.py "$TEST_IMG" dump-header | grep incompatible_features
|
|
_check_test_img
|
|
|
|
echo
|
|
echo "== Committing to a backing file with lazy_refcounts=on =="
|
|
|
|
TEST_IMG="$TEST_IMG".base _make_test_img -o "compat=1.1,lazy_refcounts=on" $size
|
|
|
|
_make_test_img -o "compat=1.1,lazy_refcounts=on,backing_file=$TEST_IMG.base" \
|
|
-F $IMGFMT $size
|
|
|
|
$QEMU_IO -c "write 0 512" "$TEST_IMG" | _filter_qemu_io
|
|
$QEMU_IMG commit "$TEST_IMG"
|
|
|
|
# The dirty bit must not be set
|
|
$PYTHON qcow2.py "$TEST_IMG" dump-header | grep incompatible_features
|
|
$PYTHON qcow2.py "$TEST_IMG".base dump-header | grep incompatible_features
|
|
|
|
_check_test_img
|
|
TEST_IMG="$TEST_IMG".base _check_test_img
|
|
|
|
echo
|
|
echo "== Changing lazy_refcounts setting at runtime =="
|
|
|
|
_make_test_img -o "compat=1.1,lazy_refcounts=off" $size
|
|
|
|
_NO_VALGRIND \
|
|
$QEMU_IO -c "reopen -o lazy-refcounts=on" \
|
|
-c "write -P 0x5a 0 512" \
|
|
-c "sigraise $(kill -l KILL)" "$TEST_IMG" 2>&1 \
|
|
| _filter_qemu_io
|
|
|
|
# The dirty bit must be set
|
|
$PYTHON qcow2.py "$TEST_IMG" dump-header | grep incompatible_features
|
|
_check_test_img
|
|
|
|
_make_test_img -o "compat=1.1,lazy_refcounts=on" $size
|
|
|
|
_NO_VALGRIND \
|
|
$QEMU_IO -c "reopen -o lazy-refcounts=off" \
|
|
-c "write -P 0x5a 0 512" \
|
|
-c "sigraise $(kill -l KILL)" "$TEST_IMG" 2>&1 \
|
|
| _filter_qemu_io
|
|
|
|
# The dirty bit must not be set
|
|
$PYTHON qcow2.py "$TEST_IMG" dump-header | grep incompatible_features
|
|
_check_test_img
|
|
|
|
|
|
# success, all done
|
|
echo "*** done"
|
|
rm -f $seq.full
|
|
status=0
|
|
|