effd60c878
monitor_qmp_dispatcher_co() runs in the iohandler AioContext that is not
polled during nested event loops. The coroutine currently reschedules
itself in the main loop's qemu_aio_context AioContext, which is polled
during nested event loops. One known problem is that QMP device-add
calls drain_call_rcu(), which temporarily drops the BQL, leading to all
sorts of havoc like other vCPU threads re-entering device emulation code
while another vCPU thread is waiting in device emulation code with
aio_poll().
Paolo Bonzini suggested running non-coroutine QMP handlers in the
iohandler AioContext. This avoids trouble with nested event loops. His
original idea was to move coroutine rescheduling to
monitor_qmp_dispatch(), but I resorted to moving it to qmp_dispatch()
because we don't know if the QMP handler needs to run in coroutine
context in monitor_qmp_dispatch(). monitor_qmp_dispatch() would have
been nicer since it's associated with the monitor implementation and not
as general as qmp_dispatch(), which is also used by qemu-ga.
A number of qemu-iotests need updated .out files because the order of
QMP events vs QMP responses has changed.
Solves Issue #1933.
Cc: qemu-stable@nongnu.org
Fixes: 7bed89958b ("device_core: use drain_call_rcu in in qmp_device_add")
Buglink: https://bugzilla.redhat.com/show_bug.cgi?id=2215192
Buglink: https://bugzilla.redhat.com/show_bug.cgi?id=2214985
Buglink: https://issues.redhat.com/browse/RHEL-17369
Signed-off-by: Stefan Hajnoczi <stefanha@redhat.com>
Message-ID: <20240118144823.1497953-4-stefanha@redhat.com>
Reviewed-by: Kevin Wolf <kwolf@redhat.com>
Tested-by: Fiona Ebner <f.ebner@proxmox.com>
Signed-off-by: Kevin Wolf <kwolf@redhat.com>
138 lines
4.2 KiB
Bash
Executable File
138 lines
4.2 KiB
Bash
Executable File
#!/usr/bin/env bash
|
|
# group: rw
|
|
#
|
|
# Test writing image headers of other formats into raw images
|
|
#
|
|
# Copyright (C) 2014 Red Hat, Inc.
|
|
#
|
|
# This program is free software; you can redistribute it and/or modify
|
|
# it under the terms of the GNU General Public License as published by
|
|
# the Free Software Foundation; either version 2 of the License, or
|
|
# (at your option) any later version.
|
|
#
|
|
# This program is distributed in the hope that it will be useful,
|
|
# but WITHOUT ANY WARRANTY; without even the implied warranty of
|
|
# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
|
|
# GNU General Public License for more details.
|
|
#
|
|
# You should have received a copy of the GNU General Public License
|
|
# along with this program. If not, see <http://www.gnu.org/licenses/>.
|
|
#
|
|
|
|
# creator
|
|
owner=kwolf@redhat.com
|
|
|
|
seq="$(basename $0)"
|
|
echo "QA output created by $seq"
|
|
|
|
status=1 # failure is the default!
|
|
|
|
_cleanup()
|
|
{
|
|
_cleanup_qemu
|
|
_rm_test_img "$TEST_IMG.src"
|
|
_cleanup_test_img
|
|
}
|
|
trap "_cleanup; exit \$status" 0 1 2 3 15
|
|
|
|
# get standard environment, filters and checks
|
|
. ./common.rc
|
|
. ./common.filter
|
|
. ./common.qemu
|
|
|
|
_supported_fmt raw
|
|
_supported_proto file
|
|
_supported_os Linux
|
|
_require_drivers qcow qcow2 qed vdi vmdk vpc
|
|
|
|
qemu_comm_method=qmp
|
|
|
|
run_qemu()
|
|
{
|
|
local raw_img="$1"
|
|
local source_img="$2"
|
|
local qmp_format="$3"
|
|
local qmp_event="$4"
|
|
|
|
_launch_qemu -drive file="${source_img}",format=raw,cache=${CACHEMODE},aio=${AIOMODE},id=src
|
|
_send_qemu_cmd $QEMU_HANDLE "{ 'execute': 'qmp_capabilities' }" "return"
|
|
|
|
capture_events="$qmp_event" _send_qemu_cmd $QEMU_HANDLE \
|
|
"{'execute':'drive-mirror', 'arguments':{
|
|
'device': 'src', 'target': '$raw_img', $qmp_format
|
|
'mode': 'existing', 'sync': 'full'}}" \
|
|
"return"
|
|
|
|
capture_events="$qmp_event JOB_STATUS_CHANGE" _wait_event $QEMU_HANDLE "$qmp_event"
|
|
if test "$qmp_event" = BLOCK_JOB_ERROR; then
|
|
_send_qemu_cmd $QEMU_HANDLE '' '"status": "null"'
|
|
fi
|
|
_send_qemu_cmd $QEMU_HANDLE '{"execute":"query-block-jobs"}' "return"
|
|
_send_qemu_cmd $QEMU_HANDLE '{"execute":"quit"}' "return"
|
|
wait=1 _cleanup_qemu
|
|
}
|
|
|
|
for fmt in qcow qcow2 qed vdi vmdk vpc; do
|
|
|
|
echo
|
|
echo "=== Writing a $fmt header into raw ==="
|
|
echo
|
|
|
|
TEST_IMG="$TEST_IMG.src" IMGFMT=$fmt _make_test_img 64M
|
|
_make_test_img $(du -b "$TEST_IMG.src" | cut -f1) | _filter_img_create_size
|
|
|
|
# This first test should fail: The image format was probed, we may not
|
|
# write an image header at the start of the image
|
|
run_qemu "$TEST_IMG" "$TEST_IMG.src" "" "BLOCK_JOB_ERROR" |
|
|
_filter_block_job_len
|
|
$QEMU_IO -c 'read -P 0 0 512' "$TEST_IMG" | _filter_qemu_io
|
|
|
|
|
|
# When raw was explicitly specified, the same must succeed
|
|
run_qemu "$TEST_IMG" "$TEST_IMG.src" "'format': 'raw'," "BLOCK_JOB_READY"
|
|
$QEMU_IMG compare -f raw -F raw "$TEST_IMG" "$TEST_IMG.src"
|
|
|
|
done
|
|
|
|
|
|
for sample_img in empty.bochs iotest-dirtylog-10G-4M.vhdx parallels-v1 \
|
|
simple-pattern.cloop; do
|
|
|
|
echo
|
|
echo "=== Copying sample image $sample_img into raw ==="
|
|
echo
|
|
|
|
# Can't use _use_sample_img because that isn't designed to be used multiple
|
|
# times and it overwrites $TEST_IMG (both breaks cleanup)
|
|
bzcat "$SAMPLE_IMG_DIR/$sample_img.bz2" > "$TEST_IMG.src"
|
|
_make_test_img $(du -b "$TEST_IMG.src" | cut -f1) | _filter_img_create_size
|
|
|
|
run_qemu "$TEST_IMG" "$TEST_IMG.src" "" "BLOCK_JOB_ERROR" |
|
|
_filter_block_job_offset | _filter_block_job_len
|
|
$QEMU_IO -c 'read -P 0 0 512' "$TEST_IMG" | _filter_qemu_io
|
|
|
|
run_qemu "$TEST_IMG" "$TEST_IMG.src" "'format': 'raw'," "BLOCK_JOB_READY"
|
|
$QEMU_IMG compare -f raw -F raw "$TEST_IMG" "$TEST_IMG.src"
|
|
done
|
|
|
|
echo
|
|
echo "=== Write legitimate MBR into raw ==="
|
|
echo
|
|
|
|
for sample_img in grub_mbr.raw; do
|
|
bzcat "$SAMPLE_IMG_DIR/$sample_img.bz2" > "$TEST_IMG.src"
|
|
_make_test_img $(du -b "$TEST_IMG.src" | cut -f1) | _filter_img_create_size
|
|
|
|
run_qemu "$TEST_IMG" "$TEST_IMG.src" "" "BLOCK_JOB_READY"
|
|
$QEMU_IMG compare -f raw -F raw "$TEST_IMG" "$TEST_IMG.src"
|
|
|
|
run_qemu "$TEST_IMG" "$TEST_IMG.src" "'format': 'raw'," "BLOCK_JOB_READY"
|
|
$QEMU_IMG compare -f raw -F raw "$TEST_IMG" "$TEST_IMG.src"
|
|
done
|
|
|
|
|
|
# success, all done
|
|
echo '*** done'
|
|
rm -f $seq.full
|
|
status=0
|