mirrors/qemu
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity
36452f12f8
qemu/tests
History
Fam Zheng 36452f12f8 qemu-img: Fix overwriting 'ret' before using 
This patch moves ret assignment after reporting original error.

We were lucky to pass qemu-iotests 048 (qemu-img compare case) but when
I tried to run with TEST_DIR=/tmp (tmpfs), it fails with a "wrong"
mismatch offset. This fixes two bugs.

In the first if branch, setting ret to 1 before using it makes dead code
in the next line: pnum is never added to mismatch offset even if ret was
0.

In the other if branch, currently the output error is always -4:
  strerror(-4) -> Unknown error -4

Added regression test in case 048.

Signed-off-by: Fam Zheng <famz@redhat.com>
Signed-off-by: Amos Kong <akong@redhat.com>
Signed-off-by: Kevin Wolf <kwolf@redhat.com>
Reviewed-by: Eric Blake <eblake@redhat.com>
Reviewed-by: Fam Zheng <famz@redhat.com>
2013-11-15 13:37:48 +01:00
..
libqos libqos: Generalize I/O-mapped fw_cfg 2013-07-18 13:27:47 -05:00
multiboot tests: Multiboot mmap test case 2013-10-28 17:34:42 +01:00
qapi-schema OptsVisitor: introduce unit tests, with test cases for range flattening 2013-08-20 11:52:00 -04:00
qemu-iotests qemu-img: Fix overwriting 'ret' before using 2013-11-15 13:37:48 +01:00
tcg xtensa queue 2013-07-29 2013-08-05 08:06:25 -05:00
.gitignore tests: Fix schema parser test for in-tree build 2013-10-02 22:55:27 +04:00
blockdev-test.c blockdev-test: add test case for drive_add duplicate IDs 2013-11-07 13:58:58 +01:00
boot-order-test.c libqtest: rename qmp() to qmp_discard_response() 2013-11-07 13:58:43 +01:00
check-block.sh Add 'make check-block' 2012-03-12 15:14:07 +01:00
check-qdict.c qapi: move include files to include/qobject/ 2012-12-19 08:31:31 +01:00
check-qfloat.c qapi: move include files to include/qobject/ 2012-12-19 08:31:31 +01:00
check-qint.c qapi: move include files to include/qobject/ 2012-12-19 08:31:31 +01:00
check-qjson.c qjson: to_json() case QTYPE_QSTRING is buggy, rewrite 2013-04-13 19:40:25 +00:00
check-qlist.c qapi: move include files to include/qobject/ 2012-12-19 08:31:31 +01:00
check-qstring.c qapi: move include files to include/qobject/ 2012-12-19 08:31:31 +01:00
endianness-test.c tests: fix 64-bit int literals for 32-bit hosts 2013-11-05 19:59:43 -08:00
fdc-test.c libqtest: rename qmp() to qmp_discard_response() 2013-11-07 13:58:43 +01:00
fw_cfg-test.c libqos: Generalize I/O-mapped fw_cfg 2013-07-18 13:27:47 -05:00
hd-geo-test.c libqtest: New qtest_end() to go with qtest_start() 2013-07-18 11:32:55 -05:00
i440fx-test.c i440fx-test: add test for PAM functionality 2013-04-17 10:27:47 -05:00
ide-test.c libqtest: rename qmp() to qmp_discard_response() 2013-11-07 13:58:43 +01:00
libqtest.c libqtest: add qmp(fmt, ...) -> QDict* function 2013-11-07 13:58:53 +01:00
libqtest.h libqtest: add qmp(fmt, ...) -> QDict* function 2013-11-07 13:58:53 +01:00
m48t59-test.c qtest: Add MMIO support 2013-02-18 08:39:10 -06:00
Makefile qdev-monitor-test: add device_add leak test cases 2013-11-07 13:58:58 +01:00
qdev-monitor-test.c qdev-monitor-test: add device_add leak test cases 2013-11-07 13:58:58 +01:00
qemu-iotests-quick.sh make check: Add qemu-iotests subset 2012-03-12 15:14:07 +01:00
qom-test.c qtest: Prepare QOM machine tests 2013-11-05 17:47:29 +01:00
rtc-test.c hw: move headers to include/ 2013-04-08 18:13:10 +02:00
test-aio.c aio / timers: fix build of test/test-aio.c on non-linux platforms 2013-09-06 15:25:08 +02:00
test-bitops.c tests: fix 64-bit int literals for 32-bit hosts 2013-11-05 19:59:43 -08:00
test-coroutine.c coroutine: fix /perf/nesting coroutine benchmark 2013-09-19 13:21:41 +02:00
test-cutils.c cutils: unsigned int parsing functions 2013-02-04 14:38:33 -06:00
test-hbitmap.c hbitmap: add assertion on hbitmap_iter_init 2013-01-25 18:18:35 +01:00
test-int128.c int128: optimize and add test cases 2013-07-02 08:17:01 +02:00
test-iov.c test-iov: add iov_discard_front/back() testcases 2013-01-02 15:58:09 +01:00
test-mul64.c tests: Add unit tests for mulu64 and muls64 2013-02-17 14:28:58 +00:00
test-opts-visitor.c tests: fix 64-bit int literals for 32-bit hosts 2013-11-05 19:59:43 -08:00
test-qdev-global-props.c qdev: Set globals in instance_post_init function 2013-08-16 18:44:33 +02:00
test-qmp-commands.c misc: move include files to include/qemu/ 2012-12-19 08:32:39 +01:00
test-qmp-input-strict.c qapi: move include files to include/qobject/ 2012-12-19 08:31:31 +01:00
test-qmp-input-visitor.c tests: fix memleak in error path test for input visitor 2013-11-05 19:58:38 -08:00
test-qmp-output-visitor.c misc: Use g_assert_not_reached for code which is expected to be unreachable 2013-07-27 11:22:54 +04:00
test-string-input-visitor.c tests/test-string-input-visitor: Handle errors provoked by fuzz test 2013-02-07 13:22:50 -02:00
test-string-output-visitor.c qapi: move include files to include/qobject/ 2012-12-19 08:31:31 +01:00
test-thread-pool.c aio / timers: Add QEMUTimerListGroup to AioContext 2013-08-22 19:10:27 +02:00
test-throttle.c misc: New spelling fixes in comments 2013-10-26 13:01:57 +04:00
test-visitor-serialization.c misc: Use g_assert_not_reached for code which is expected to be unreachable 2013-07-27 11:22:54 +04:00
test-x86-cpuid.c target-i386: Topology & APIC ID utility functions 2013-01-27 14:34:27 +01:00
test-xbzrle.c Add XBZRLE testing 2013-02-01 08:32:20 +01:00
tmp105-test.c libqos: Relocate I2C files 2013-05-03 12:03:14 -05:00