mirrors/qemu
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity
qemu/block
History
Stefan Hajnoczi 3c5867156e block: fix detect-zeroes= with BDRV_REQ_REGISTERED_BUF 
When a write request is converted into a write zeroes request by the
detect-zeroes= feature, it is no longer associated with an I/O buffer.
The BDRV_REQ_REGISTERED_BUF flag doesn't make sense without an I/O
buffer and must be cleared because bdrv_co_do_pwrite_zeroes() fails with
-EINVAL when it's set.

Fiona Ebner <f.ebner@proxmox.com> bisected and diagnosed this QEMU 7.2
regression where writes containing zeroes to a blockdev with
discard=unmap,detect-zeroes=unmap fail.

Buglink: https://gitlab.com/qemu-project/qemu/-/issues/1404
Fixes: e8b6535533be ("block: add BDRV_REQ_REGISTERED_BUF request flag")
Tested-by: Fiona Ebner <f.ebner@proxmox.com>
Cc: qemu-stable@nongnu.org
Reviewed-by: Eric Blake <eblake@redhat.com>
Reviewed-by: Hanna Czenczek <hreitz@redhat.com>
Signed-off-by: Stefan Hajnoczi <stefanha@redhat.com>
Message-Id: <20230207203719.242926-2-stefanha@redhat.com>
2023-02-09 10:22:30 -05:00
..
export
Fix non-first inclusions of qemu/osdep.h
2023-02-08 07:28:05 +01:00
monitor
Monitor patches for 2023-02-03
2023-02-04 10:19:55 +00:00
accounting.c
…
aio_task.c
…
amend.c
include/block: Untangle inclusion loops
2023-01-20 07:24:28 +01:00
backup.c
include/block: Untangle inclusion loops
2023-01-20 07:24:28 +01:00
blkdebug.c
block: Convert bdrv_debug_event() to co_wrapper_mixed
2023-02-01 16:52:32 +01:00
blkio.c
block: Convert bdrv_get_info() to co_wrapper_mixed
2023-02-01 16:52:32 +01:00
blklogwrites.c
block: Convert bdrv_refresh_total_sectors() to co_wrapper_mixed
2023-02-01 16:52:32 +01:00
blkreplay.c
block: Convert bdrv_refresh_total_sectors() to co_wrapper_mixed
2023-02-01 16:52:32 +01:00
blkverify.c
block: Convert bdrv_refresh_total_sectors() to co_wrapper_mixed
2023-02-01 16:52:32 +01:00
block-backend.c
block: Convert bdrv_lock_medium() to co_wrapper
2023-02-01 16:52:32 +01:00
block-copy.c
include/block: Untangle inclusion loops
2023-01-20 07:24:28 +01:00
block-gen.h
block-coroutine-wrapper.py: support also basic return types
2022-12-15 16:07:43 +01:00
block-ram-registrar.c
…
bochs.c
include/block: Untangle inclusion loops
2023-01-20 07:24:28 +01:00
cloop.c
include/block: Untangle inclusion loops
2023-01-20 07:24:28 +01:00
commit.c
block: Convert bdrv_refresh_total_sectors() to co_wrapper_mixed
2023-02-01 16:52:32 +01:00
copy-before-write.c
include/block: Untangle inclusion loops
2023-01-20 07:24:28 +01:00
copy-before-write.h
…
copy-on-read.c
block: Convert bdrv_lock_medium() to co_wrapper
2023-02-01 16:52:32 +01:00
copy-on-read.h
…
coroutines.h
block: GRAPH_RDLOCK for functions only called by co_wrappers
2022-12-15 16:08:23 +01:00
create.c
…
crypto.c
block: Convert bdrv_get_info() to co_wrapper_mixed
2023-02-01 16:52:32 +01:00
crypto.h
…
curl.c
block: Convert bdrv_refresh_total_sectors() to co_wrapper_mixed
2023-02-01 16:52:32 +01:00
dirty-bitmap.c
include/block: Untangle inclusion loops
2023-01-20 07:24:28 +01:00
dmg-bz2.c
…
dmg-lzfse.c
…
dmg.c
include/block: Untangle inclusion loops
2023-01-20 07:24:28 +01:00
dmg.h
…
file-posix.c
block/file: Add file-specific image info
2023-02-01 16:52:33 +01:00
file-win32.c
block: Convert bdrv_get_allocated_file_size() to co_wrapper
2023-02-01 16:52:32 +01:00
filter-compress.c
block: Convert bdrv_lock_medium() to co_wrapper
2023-02-01 16:52:32 +01:00
gluster.c
block: Convert bdrv_get_allocated_file_size() to co_wrapper
2023-02-01 16:52:32 +01:00
graph-lock.c
graph-lock: TSA annotations for lock/unlock functions
2022-12-15 16:08:23 +01:00
io_uring.c
…
io.c
block: fix detect-zeroes= with BDRV_REQ_REGISTERED_BUF
2023-02-09 10:22:30 -05:00
iscsi-opts.c
…
iscsi.c
block: Convert bdrv_get_info() to co_wrapper_mixed
2023-02-01 16:52:32 +01:00
linux-aio.c
…
meson.build
block: Convert bdrv_refresh_total_sectors() to co_wrapper_mixed
2023-02-01 16:52:32 +01:00
mirror.c
block: Convert bdrv_get_info() to co_wrapper_mixed
2023-02-01 16:52:32 +01:00
nbd.c
block: Convert bdrv_refresh_total_sectors() to co_wrapper_mixed
2023-02-01 16:52:32 +01:00
nfs.c
block: Convert bdrv_get_allocated_file_size() to co_wrapper
2023-02-01 16:52:32 +01:00
null.c
block: Convert bdrv_get_allocated_file_size() to co_wrapper
2023-02-01 16:52:32 +01:00
nvme.c
block: Convert bdrv_refresh_total_sectors() to co_wrapper_mixed
2023-02-01 16:52:32 +01:00
parallels-ext.c
include/block: Untangle inclusion loops
2023-01-20 07:24:28 +01:00
parallels.c
block: bdrv_create_file is a coroutine_fn
2022-12-15 16:07:43 +01:00
parallels.h
…
preallocate.c
block: use bdrv_co_refresh_total_sectors when possible
2023-02-01 16:52:32 +01:00
progress_meter.c
coroutine: Clean up superfluous inclusion of qemu/lockable.h
2023-01-19 10:18:28 +01:00
qapi-sysemu.c
include/block: Untangle inclusion loops
2023-01-20 07:24:28 +01:00
qapi.c
block: Clean up includes
2023-02-08 07:28:05 +01:00
qcow2-bitmap.c
qcow2: Fix theoretical corruption in store_bitmap() error path
2023-01-24 18:26:41 +01:00
qcow2-cache.c
include/block: Untangle inclusion loops
2023-01-20 07:24:28 +01:00
qcow2-cluster.c
include/block: Untangle inclusion loops
2023-01-20 07:24:28 +01:00
qcow2-refcount.c
block: Convert bdrv_get_allocated_file_size() to co_wrapper
2023-02-01 16:52:32 +01:00
qcow2-snapshot.c
qcow2: switch to *_co_* functions
2022-10-27 20:14:11 +02:00
qcow2-threads.c
include/block: Untangle inclusion loops
2023-01-20 07:24:28 +01:00
qcow2.c
block: Rename bdrv_load/save_vmstate() to bdrv_co_load/save_vmstate()
2023-02-01 16:52:32 +01:00
qcow2.h
…
qcow.c
block: Convert bdrv_get_info() to co_wrapper_mixed
2023-02-01 16:52:32 +01:00
qed-check.c
include/block: Untangle inclusion loops
2023-01-20 07:24:28 +01:00
qed-cluster.c
…
qed-l2-cache.c
…
qed-table.c
include/block: Untangle inclusion loops
2023-01-20 07:24:28 +01:00
qed.c
block: Convert bdrv_get_info() to co_wrapper_mixed
2023-02-01 16:52:32 +01:00
qed.h
…
quorum.c
block: Convert bdrv_refresh_total_sectors() to co_wrapper_mixed
2023-02-01 16:52:32 +01:00
raw-format.c
block: Convert bdrv_lock_medium() to co_wrapper
2023-02-01 16:52:32 +01:00
rbd.c
block: Convert bdrv_get_info() to co_wrapper_mixed
2023-02-01 16:52:32 +01:00
replication.c
block: Convert bdrv_refresh_total_sectors() to co_wrapper_mixed
2023-02-01 16:52:32 +01:00
reqlist.c
…
snapshot-access.c
…
snapshot.c
…
ssh.c
block: Convert bdrv_refresh_total_sectors() to co_wrapper_mixed
2023-02-01 16:52:32 +01:00
stream.c
stream: Replace subtree drain with a single node drain
2022-12-15 16:07:42 +01:00
throttle-groups.c
…
throttle.c
block: Convert bdrv_refresh_total_sectors() to co_wrapper_mixed
2023-02-01 16:52:32 +01:00
trace-events
…
trace.h
…
vdi.c
block: Convert bdrv_get_info() to co_wrapper_mixed
2023-02-01 16:52:32 +01:00
vhdx-endian.c
…
vhdx-log.c
include/block: Untangle inclusion loops
2023-01-20 07:24:28 +01:00
vhdx.c
block: Convert bdrv_get_info() to co_wrapper_mixed
2023-02-01 16:52:32 +01:00
vhdx.h
…
vmdk.c
block/vmdk: Change extent info type
2023-02-01 16:52:33 +01:00
vpc.c
block: Convert bdrv_get_info() to co_wrapper_mixed
2023-02-01 16:52:32 +01:00
vvfat.c
include/block: Untangle inclusion loops
2023-01-20 07:24:28 +01:00
win32-aio.c
include/block: Untangle inclusion loops
2023-01-20 07:24:28 +01:00
write-threshold.c
include/block: Untangle inclusion loops
2023-01-20 07:24:28 +01:00