mirrors/qemu
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity
2fe45ec3bf
qemu/hw
History
Greg Kurz 2fe45ec3bf vhost: fix error check in vhost_verify_ring_mappings() 
Since commit f1f9e6c5 "vhost: adapt vhost_verify_ring_mappings() to
virtio 1 ring layout", we check the mapping of each part (descriptor
table, available ring and used ring) of each virtqueue separately.

The checking of a part is done by the vhost_verify_ring_part_mapping()
function: it returns either 0 on success or a negative errno if the
part cannot be mapped at the same place.

Unfortunately, the vhost_verify_ring_mappings() function checks its
return value the other way round. It means that we either:
- only verify the descriptor table of the first virtqueue, and if it
  is valid we ignore all the other mappings
- or ignore all broken mappings until we reach a valid one

ie, we only raise an error if all mappings are broken, and we consider
all mappings are valid otherwise (false success), which is obviously
wrong.

This patch ensures that vhost_verify_ring_mappings() only returns
success if ALL mappings are okay.

Reported-by: Dr. David Alan Gilbert <dgilbert@redhat.com>
Signed-off-by: Greg Kurz <groug@kaod.org>
Reviewed-by: Michael S. Tsirkin <mst@redhat.com>
Signed-off-by: Michael S. Tsirkin <mst@redhat.com>
2017-12-01 19:05:58 +02:00
..
9pfs 9pfs: fix v9fs_mark_fids_unreclaim() return value 2017-11-06 18:05:35 +01:00
acpi * TCG 8-byte atomic accesses bugfix (Andrew) 2017-10-19 15:38:07 +01:00
adc STM32F2xx: Add the ADC device 2016-10-04 13:28:07 +01:00
alpha alpha: use generic cpu_model parsing 2017-10-27 16:03:53 +02:00
arm hw/arm/virt: Add 2.11 machine type 2017-11-24 11:28:56 +00:00
audio pci: Add INTERFACE_CONVENTIONAL_PCI_DEVICE to Conventional PCI devices 2017-10-15 05:54:43 +03:00
block xen: dont try setting max grants multiple times 2017-10-26 14:23:08 -07:00
bt bt: stop the sdp memory allocation craziness 2017-08-01 17:27:33 +02:00
char spapr: Implement bug in spapr-vty device to be compatible with PowerVM 2017-11-22 15:28:37 +11:00
core * TCG 8-byte atomic accesses bugfix (Andrew) 2017-10-19 15:38:07 +01:00
cpu cpu: don't allow negative core id 2017-08-02 18:30:13 -03:00
cris cris: use generic cpu_model parsing 2017-10-27 16:03:54 +02:00
display vga: bugfixes for 2.11 2017-11-13 14:33:29 +00:00
dma sun4m_iommu: remove legacy sparc_iommu_memory_rw() function 2017-10-31 17:25:37 +00:00
gpio hw/gpio/omap_gpio.c: Don't use old_mmio 2017-09-21 16:34:27 +01:00
i2c pci: Add INTERFACE_CONVENTIONAL_PCI_DEVICE to Conventional PCI devices 2017-10-15 05:54:43 +03:00
i386 NUMA: Enable adding NUMA node implicitly 2017-11-16 17:46:53 +02:00
ide ide: avoid referencing NULL dev in rotational rate setting 2017-10-31 18:00:03 -04:00
input ps2: fix scancodes sent for Ctrl+Pause key combination 2017-10-23 10:50:02 +02:00
intc nvic: Fix ARMv7M MPU_RBAR reads 2017-11-20 13:39:48 +00:00
ipack pci: Add INTERFACE_CONVENTIONAL_PCI_DEVICE to Conventional PCI devices 2017-10-15 05:54:43 +03:00
ipmi qom: enforce readonly nature of link's check callback 2017-07-14 12:04:42 +02:00
isa pci: Add INTERFACE_CONVENTIONAL_PCI_DEVICE to Conventional PCI devices 2017-10-15 05:54:43 +03:00
lm32 lm32: lm32_boards: use generic cpu_model parsing 2017-10-27 16:03:54 +02:00
m68k m68k: mcf5208: use generic cpu_model parsing 2017-10-27 16:03:54 +02:00
mem qmp: introduce query-memory-size-summary command 2017-09-14 15:52:10 +01:00
microblaze hw: Use new memory_region_init_{ram, rom, rom_device}() functions 2017-07-14 17:59:42 +01:00
mips mips: r4k: replace cpu_model with cpu_type 2017-10-27 16:04:28 +02:00
misc hw/arm/aspeed: Unlock SCU when running kernel 2017-11-20 13:47:49 +00:00
moxie moxie: use generic cpu_model parsing 2017-10-27 16:03:54 +02:00
net virtio-net: don't touch virtqueue if vm is stopped 2017-11-28 11:54:50 +08:00
nios2 nios2: replace cpu_nios2_init() with cpu_generic_init() 2017-09-01 11:54:24 -03:00
nvram fw_cfg: add write callback 2017-10-15 05:54:40 +03:00
openrisc openrisc: use generic cpu_model parsing 2017-10-27 16:03:54 +02:00
pci pci: Initialize pci_dev->name before use 2017-11-16 17:46:53 +02:00
pci-bridge hw/pcie-pci-bridge: restrict to X86 and ARM 2017-11-16 17:46:53 +02:00
pci-host hw/pci-host: Fix x86 Host Bridges 64bit PCI hole 2017-11-16 17:46:53 +02:00
pcmcia hw: Clean up includes 2016-01-29 15:07:25 +00:00
ppc target/ppc: Move setting of patb_entry on hash table init 2017-11-27 12:20:11 +11:00
s390x s390/kvm_virtio/linux-headers: remove traces of old virtio transport 2017-11-24 10:52:05 +01:00
scsi vhost-user-scsi: add missing virtqueue_size param 2017-11-14 14:31:33 +01:00
sd pci: Add INTERFACE_CONVENTIONAL_PCI_DEVICE to Conventional PCI devices 2017-10-15 05:54:43 +03:00
sh4 sh4: shix: use generic cpu_model parsing 2017-10-27 16:03:54 +02:00
smbios stubs: move smbios stubs to hw/smbios 2017-01-16 17:52:35 +01:00
sparc sparc32_dma: introduce new SPARC32_DMA type container object 2017-10-31 17:25:36 +00:00
sparc64 sparc: sun4u/sun4v/niagara: use generic cpu_model parsing 2017-10-27 16:04:27 +02:00
ssi msf2: Remove dead code reported by Coverity 2017-10-31 11:50:51 +00:00
timer migration: pre_save return int 2017-09-27 11:35:59 +01:00
tpm tpm_tis: Return 0 for every register in case of failure mode 2017-11-15 06:47:35 -05:00
tricore tricore: use generic cpu_model parsing 2017-10-27 16:04:27 +02:00
unicore32 unicore32: use generic cpu_model parsing 2017-10-27 16:04:27 +02:00
usb usb-ccid: remove needless migration state code 2017-10-23 10:05:28 +02:00
vfio s390x: improve error handling for SSCH and RSCH 2017-10-20 13:32:10 +02:00
virtio vhost: fix error check in vhost_verify_ring_mappings() 2017-12-01 19:05:58 +02:00
watchdog pci: Add INTERFACE_CONVENTIONAL_PCI_DEVICE to Conventional PCI devices 2017-10-15 05:54:43 +03:00
xen pci-assign: Remove 2017-11-05 14:52:10 +01:00
xenpv xenfb: remove xen_init_display "temporary" hack 2017-07-07 11:10:03 -07:00
xtensa xtensa: lx60/lx200/ml605/kc705: use generic cpu_model parsing 2017-10-27 16:04:27 +02:00
Makefile.objs 9pfs: fix dependencies 2017-08-30 18:23:25 +02:00