Jason Wang ec1a78cee9 intel_iommu: refine iotlb hash calculation ... Commit 1b2b12376c ("intel-iommu: PASID support") takes PASID into account when calculating iotlb hash like: static guint vtd_iotlb_hash(gconstpointer v) { const struct vtd_iotlb_key *key = v; return key->gfn | ((key->sid) << VTD_IOTLB_SID_SHIFT) | (key->level) << VTD_IOTLB_LVL_SHIFT | (key->pasid) << VTD_IOTLB_PASID_SHIFT; } This turns out to be problematic since: - the shift will lose bits if not converting to uint64_t - level should be off by one in order to fit into 2 bits - VTD_IOTLB_PASID_SHIFT is 30 but PASID is 20 bits which will waste some bits - the hash result is uint64_t so we will lose bits when converting to guint So this patch fixes them by - converting the keys into uint64_t before doing the shift - off level by one to make it fit into two bits - change the sid, lvl and pasid shift to 26, 42 and 44 in order to take the full width of uint64_t - perform an XOR to the top 32bit with the bottom 32bit for the final result to fit guint Fixes: Coverity CID 1508100 Fixes: 1b2b12376c ("intel-iommu: PASID support") Signed-off-by: Jason Wang <jasowang@redhat.com> Message-Id: <20230412073510.7158-1-jasowang@redhat.com> Reviewed-by: Michael S. Tsirkin <mst@redhat.com> Signed-off-by: Michael S. Tsirkin <mst@redhat.com> Reviewed-by: Peter Xu <peterx@redhat.com>		2023-04-24 22:56:55 -04:00
..
kvm
xen
acpi-build.c	hw/acpi: limit warning on acpi table size to pc machines older than version 2.3	2023-04-24 22:56:55 -04:00
acpi-build.h
acpi-common.c
acpi-common.h
acpi-microvm.c
acpi-microvm.h
amd_iommu.c
amd_iommu.h
e820_memory_layout.c
e820_memory_layout.h
fw_cfg.c
fw_cfg.h
generic_event_device_x86.c
intel_iommu_internal.h	intel_iommu: refine iotlb hash calculation	2023-04-24 22:56:55 -04:00
intel_iommu.c	intel_iommu: refine iotlb hash calculation	2023-04-24 22:56:55 -04:00
Kconfig
kvmvapic.c
meson.build
microvm-dt.c
microvm-dt.h
microvm.c
multiboot.c
multiboot.h
pc_piix.c	hw/acpi: limit warning on acpi table size to pc machines older than version 2.3	2023-04-24 22:56:55 -04:00
pc_q35.c
pc_sysfw_ovmf-stubs.c
pc_sysfw_ovmf.c
pc_sysfw.c
pc.c	hw/acpi: limit warning on acpi table size to pc machines older than version 2.3	2023-04-24 22:56:55 -04:00
port92.c
sgx-epc.c
sgx-stub.c
sgx.c
trace-events
trace.h
vmmouse.c
vmport.c
x86-iommu-stub.c
x86-iommu.c
x86.c