qemu/tests/tcg/sh4
Philippe Mathieu-Daudé e88a856efd target/sh4: Fix SUBV opcode
The documentation says:

  SUBV Rm, Rn        Rn - Rm -> Rn, underflow -> T

The overflow / underflow can be calculated as:

  T = ((Rn ^ Rm) & (Result ^ Rn)) >> 31

However we were using the incorrect:

  T = ((Rn ^ Rm) & (Result ^ Rm)) >> 31

Fix by using the Rn register instead of Rm.

Add tests provided by Paul Cercueil.

Cc: qemu-stable@nongnu.org
Fixes: ad8d25a11f ("target-sh4: implement addv and subv using TCG")
Reported-by: Paul Cercueil <paul@crapouillou.net>
Suggested-by: Paul Cercueil <paul@crapouillou.net>
Resolves: https://gitlab.com/qemu-project/qemu/-/issues/2318
Reviewed-by: Richard Henderson <richard.henderson@linaro.org>
Signed-off-by: Philippe Mathieu-Daudé <philmd@linaro.org>
Reviewed-by: Yoshinori Sato <ysato@users.sourceforge.jp>
Message-Id: <20240430163125.77430-3-philmd@linaro.org>
2024-05-03 17:33:26 +02:00
..
Makefile.target target/sh4: Fix SUBV opcode 2024-05-03 17:33:26 +02:00
test-addv.c target/sh4: Fix ADDV opcode 2024-05-03 17:33:26 +02:00
test-macl.c target/sh4: Fix mac.l with saturation enabled 2024-04-09 07:43:31 -10:00
test-macw.c target/sh4: Fix mac.w with saturation enabled 2024-04-09 07:43:31 -10:00
test-subv.c target/sh4: Fix SUBV opcode 2024-05-03 17:33:26 +02:00