24dfdfd0ff
Mirror calculates job len from current I/O progress:
s->common.len = s->common.offset +
(cnt + s->sectors_in_flight) * BDRV_SECTOR_SIZE;
The final "len" of a failed mirror job in iotests 109 depends on the
subtle timing of the completion of read and write issued in the first
mirror iteration. The second iteration may or may not have run when the
I/O error happens, resulting in non-deterministic output of the
BLOCK_JOB_COMPLETED event text.
Similar to what was done in a752e4786, filter out the field to make the
test robust.
Signed-off-by: Fam Zheng <famz@redhat.com>
Reviewed-by: Eric Blake <eblake@redhat.com>
Tested-by: Eric Blake <eblake@redhat.com>
Signed-off-by: Kevin Wolf <kwolf@redhat.com>
136 lines
3.8 KiB
Bash
Executable File
136 lines
3.8 KiB
Bash
Executable File
#!/bin/bash
|
|
#
|
|
# Test writing image headers of other formats into raw images
|
|
#
|
|
# Copyright (C) 2014 Red Hat, Inc.
|
|
#
|
|
# This program is free software; you can redistribute it and/or modify
|
|
# it under the terms of the GNU General Public License as published by
|
|
# the Free Software Foundation; either version 2 of the License, or
|
|
# (at your option) any later version.
|
|
#
|
|
# This program is distributed in the hope that it will be useful,
|
|
# but WITHOUT ANY WARRANTY; without even the implied warranty of
|
|
# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
|
|
# GNU General Public License for more details.
|
|
#
|
|
# You should have received a copy of the GNU General Public License
|
|
# along with this program. If not, see <http://www.gnu.org/licenses/>.
|
|
#
|
|
|
|
# creator
|
|
owner=kwolf@redhat.com
|
|
|
|
seq="$(basename $0)"
|
|
echo "QA output created by $seq"
|
|
|
|
here="$PWD"
|
|
status=1 # failure is the default!
|
|
|
|
_cleanup()
|
|
{
|
|
_cleanup_qemu
|
|
rm -f $TEST_IMG.src
|
|
_cleanup_test_img
|
|
}
|
|
trap "_cleanup; exit \$status" 0 1 2 3 15
|
|
|
|
# get standard environment, filters and checks
|
|
. ./common.rc
|
|
. ./common.filter
|
|
. ./common.qemu
|
|
|
|
_supported_fmt raw
|
|
_supported_proto file
|
|
_supported_os Linux
|
|
|
|
qemu_comm_method=qmp
|
|
|
|
function run_qemu()
|
|
{
|
|
local raw_img="$1"
|
|
local source_img="$2"
|
|
local qmp_format="$3"
|
|
local qmp_event="$4"
|
|
|
|
_launch_qemu -drive file="${source_img}",format=raw,cache=${CACHEMODE},id=src
|
|
_send_qemu_cmd $QEMU_HANDLE "{ 'execute': 'qmp_capabilities' }" "return"
|
|
|
|
_send_qemu_cmd $QEMU_HANDLE \
|
|
"{'execute':'drive-mirror', 'arguments':{
|
|
'device': 'src', 'target': '$raw_img', $qmp_format
|
|
'mode': 'existing', 'sync': 'full'}}" \
|
|
"return"
|
|
|
|
_send_qemu_cmd $QEMU_HANDLE '' "$qmp_event"
|
|
if test "$qmp_event" = BLOCK_JOB_ERROR; then
|
|
_send_qemu_cmd $QEMU_HANDLE '' "BLOCK_JOB_COMPLETED"
|
|
fi
|
|
_send_qemu_cmd $QEMU_HANDLE '{"execute":"query-block-jobs"}' "return"
|
|
_cleanup_qemu
|
|
}
|
|
|
|
for fmt in qcow qcow2 qed vdi vmdk vpc; do
|
|
|
|
echo
|
|
echo "=== Writing a $fmt header into raw ==="
|
|
echo
|
|
|
|
_make_test_img 64M
|
|
TEST_IMG="$TEST_IMG.src" IMGFMT=$fmt _make_test_img 64M
|
|
|
|
# This first test should fail: The image format was probed, we may not
|
|
# write an image header at the start of the image
|
|
run_qemu "$TEST_IMG" "$TEST_IMG.src" "" "BLOCK_JOB_ERROR" |
|
|
_filter_block_job_len
|
|
$QEMU_IO -c 'read -P 0 0 64k' "$TEST_IMG" | _filter_qemu_io
|
|
|
|
|
|
# When raw was explicitly specified, the same must succeed
|
|
run_qemu "$TEST_IMG" "$TEST_IMG.src" "'format': 'raw'," "BLOCK_JOB_READY"
|
|
$QEMU_IMG compare -f raw -F raw "$TEST_IMG" "$TEST_IMG.src"
|
|
|
|
done
|
|
|
|
|
|
for sample_img in empty.bochs iotest-dirtylog-10G-4M.vhdx parallels-v1 \
|
|
simple-pattern.cloop; do
|
|
|
|
echo
|
|
echo "=== Copying sample image $sample_img into raw ==="
|
|
echo
|
|
|
|
# Can't use _use_sample_img because that isn't designed to be used multiple
|
|
# times and it overwrites $TEST_IMG (both breaks cleanup)
|
|
_make_test_img 64M
|
|
bzcat "$SAMPLE_IMG_DIR/$sample_img.bz2" > "$TEST_IMG.src"
|
|
|
|
run_qemu "$TEST_IMG" "$TEST_IMG.src" "" "BLOCK_JOB_ERROR" |
|
|
_filter_block_job_offset | _filter_block_job_len
|
|
$QEMU_IO -c 'read -P 0 0 64k' "$TEST_IMG" | _filter_qemu_io
|
|
|
|
run_qemu "$TEST_IMG" "$TEST_IMG.src" "'format': 'raw'," "BLOCK_JOB_READY"
|
|
$QEMU_IMG compare -f raw -F raw "$TEST_IMG" "$TEST_IMG.src"
|
|
done
|
|
|
|
echo
|
|
echo "=== Write legitimate MBR into raw ==="
|
|
echo
|
|
|
|
for sample_img in grub_mbr.raw; do
|
|
_make_test_img 64M
|
|
bzcat "$SAMPLE_IMG_DIR/$sample_img.bz2" > "$TEST_IMG.src"
|
|
|
|
run_qemu "$TEST_IMG" "$TEST_IMG.src" "" "BLOCK_JOB_READY"
|
|
$QEMU_IMG compare -f raw -F raw "$TEST_IMG" "$TEST_IMG.src"
|
|
|
|
run_qemu "$TEST_IMG" "$TEST_IMG.src" "'format': 'raw'," "BLOCK_JOB_READY"
|
|
$QEMU_IMG compare -f raw -F raw "$TEST_IMG" "$TEST_IMG.src"
|
|
done
|
|
|
|
|
|
# success, all done
|
|
echo '*** done'
|
|
rm -f $seq.full
|
|
status=0
|