qemu/target-s390x
Andreas Färber 14a10fc399 cpu: Partially revert "cpu: Change qemu_init_vcpu() argument to CPUState"
Commit c643bed99 moved qemu_init_vcpu() calls to common CPUState code.
This causes x86 cpu-add to fail with "KVM: setting VAPIC address failed".

The reason for the failure is that CPUClass::kvm_fd is not yet
initialized in the following call graph:
->x86_cpu_realizefn
 ->x86_cpu_apic_realize
  ->qdev_init
   ->device_set_realized
    ->device_reset (hotplugged == 1)
     ->apic_reset_common
      ->vapic_base_update
       ->kvm_apic_vapic_base_update
This causes attempted KVM vCPU ioctls to fail.

By contrast, in the non-hotplug case the APIC is reset much later, when
the vCPU is already initialized.

As a quick and safe solution, move the qemu_init_vcpu() call back into
the targets' realize functions.

Reported-by: Chen Fan <chen.fan.fnst@cn.fujitsu.com>
Acked-by: Igor Mammedov <imammedo@redhat.com> (for i386)
Tested-by: Jia Liu <proljc@gmail.com> (for openrisc)
Signed-off-by: Andreas Färber <afaerber@suse.de>
2013-07-29 15:29:15 +02:00
..
cc_helper.c target-s390: Convert IPM 2013-01-05 12:18:42 -08:00
cpu-qom.h cpu: Introduce CPUClass::gdb_{read,write}_register() 2013-07-27 00:04:17 +02:00
cpu.c cpu: Partially revert "cpu: Change qemu_init_vcpu() argument to CPUState" 2013-07-29 15:29:15 +02:00
cpu.h cpu: Introduce CPUClass::synchronize_from_tb() for cpu_pc_from_tb() 2013-07-23 02:41:32 +02:00
fpu_helper.c target-s390: Implement LOAD/SET FP AND SIGNAL 2013-01-05 12:18:45 -08:00
gdbstub.c cpu: Introduce CPUClass::gdb_{read,write}_register() 2013-07-27 00:04:17 +02:00
helper.c cpu: Turn cpu_get_phys_page_debug() into a CPUClass hook 2013-07-23 02:41:33 +02:00
helper.h target-s390x: Use mulu2 for mlgr insn 2013-02-23 17:25:29 +00:00
insn-data.def target-s390: Perform COMPARE AND SWAP inline 2013-01-05 12:18:46 -08:00
insn-format.def target-s390: Add format based disassassmbly infrastructure 2013-01-05 12:00:27 -08:00
int_helper.c s390x: use CONFIG_INT128 to detect __uint128_t 2013-04-26 11:58:14 +02:00
interrupt.c target-s390x: Clean up cpu_inject_*() signatures 2013-02-01 02:02:20 +01:00
ioinst.c s390/css: Fix subchannel detection 2013-03-08 21:17:46 +01:00
ioinst.h s390: Fix handling of iscs. 2013-02-13 11:56:02 -06:00
kvm.c target-s390x: Fix CPUState rework fallout 2013-07-26 23:05:31 +02:00
Makefile.objs cpu: Introduce CPUClass::gdb_{read,write}_register() 2013-07-27 00:04:17 +02:00
mem_helper.c Remove unnecessary break statements 2013-06-01 14:25:38 +04:00
misc_helper.c s390: Add a hypercall registration interface. 2013-01-18 19:07:47 +01:00
translate.c cpu: Move singlestep_enabled field from CPU_COMMON to CPUState 2013-07-23 02:41:32 +02:00