mirrors/qemu
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity
192cf54ac5
qemu/include/qapi
History
Philippe Mathieu-Daudé 192cf54ac5 qapi/error: Check format string argument in error_*prepend() 
error_propagate_prepend() "behaves like error_prepend()", and
error_prepend() uses "formatting @fmt, ... like printf()".
error_prepend() checks its format string argument, but
error_propagate_prepend() does not. Fix by addint the format
attribute to error_propagate_prepend() and error_vprepend().

This would have caught the bug fixed in the previous commit.

Missed in commit 4b5766488f "error: Fix use of error_prepend() with
&error_fatal, &error_abort".

Inspired-by: Stefan Weil <sw@weilnetz.de>
Suggested-by: Eric Blake <eblake@redhat.com>
Reviewed-by: Stefan Weil <sw@weilnetz.de>
Reviewed-by: Markus Armbruster <armbru@redhat.com>
Signed-off-by: Philippe Mathieu-Daudé <philmd@redhat.com>
Message-Id: <20200723171205.14949-1-philmd@redhat.com>
Reviewed-by: Markus Armbruster <armbru@redhat.com>
[Commit message tweaked]
Signed-off-by: Markus Armbruster <armbru@redhat.com>
2020-07-24 15:03:09 +02:00
..
qmp qobject: Eliminate qdict_iter(), use qdict_first(), qdict_next() 2020-04-30 06:51:15 +02:00
clone-visitor.h qapi: Make visitor functions taking Error ** return bool, not void 2020-07-10 15:18:08 +02:00
dealloc-visitor.h include: Fix typos found by codespell 2017-01-24 23:26:52 +03:00
error.h qapi/error: Check format string argument in error_*prepend() 2020-07-24 15:03:09 +02:00
opts-visitor.h Move include qemu/option.h from qemu-common.h to actual users 2018-02-09 13:52:16 +01:00
qmp-event.h qapi: Eliminate indirection through qmp_event_get_func_emit() 2019-01-24 10:01:05 +01:00
qobject-input-visitor.h Include qapi/qmp/qobject.h exactly where needed 2018-02-09 13:52:15 +01:00
qobject-output-visitor.h Include qapi/qmp/qobject.h exactly where needed 2018-02-09 13:52:15 +01:00
string-input-visitor.h qapi: Rewrite string-input-visitor's integer and list parsing 2018-12-13 19:10:06 +01:00
string-output-visitor.h qapi: Add new visit_complete() function 2016-07-06 10:52:04 +02:00
util.h qapi: Change data type of the FOO_lookup generated for enum FOO 2017-09-04 13:09:13 +02:00
visitor-impl.h qapi: Make visitor functions taking Error ** return bool, not void 2020-07-10 15:18:08 +02:00
visitor.h qapi: Make visitor functions taking Error ** return bool, not void 2020-07-10 15:18:08 +02:00