Go to file
Alberto Garcia 184581fa4d qcow2: Fix removal of list members from BDRVQcow2State.cluster_allocs
When a write request needs to allocate new clusters (or change the L2
bitmap of existing ones) a QCowL2Meta structure is created so the L2
metadata can be later updated and any copy-on-write can be performed
if necessary.

A write request can span a region consisting of an arbitrary
combination of previously unallocated and allocated clusters, and if
the unallocated ones can be put contiguous to the existing ones then
QEMU will do so in order to minimize the number of write operations.

In practice this means that a write request has not just one but a
number of QCowL2Meta structures. All of them are added to the
cluster_allocs list that is stored in BDRVQcow2State and is used to
detect overlapping requests. After the write request finishes all its
associated QCowL2Meta are removed from that list. calculate_l2_meta()
takes care of creating and putting those structures in the list, and
qcow2_handle_l2meta() takes care of removing them.

The problem is that the error path in handle_alloc() also tries to
remove an item in that list, a remnant from the time when this was
handled there (that code would not even be correct anymore because
it only removes one struct and not all the ones from the same write
request).

This can trigger a double removal of the same item from the list,
causing a crash. This is not easy to reproduce in practice because
it requires that do_alloc_cluster_offset() fails after a successful
previous allocation during the same write request, but it can be
reproduced with the included test case.

Signed-off-by: Alberto Garcia <berto@igalia.com>
Message-Id: <3440a1c4d53c4fe48312b478c96accb338cbef7c.1599150873.git.berto@igalia.com>
Signed-off-by: Max Reitz <mreitz@redhat.com>
2020-09-15 11:05:13 +02:00
.github
.gitlab-ci.d
accel Use DECLARE_*CHECKER* macros 2020-09-09 09:27:09 -04:00
audio trace-events: Delete unused trace points 2020-09-09 17:17:02 +01:00
authz
backends Use OBJECT_DECLARE_SIMPLE_TYPE when possible 2020-09-09 09:27:11 -04:00
block qcow2: Fix removal of list members from BDRVQcow2State.cluster_allocs 2020-09-15 11:05:13 +02:00
bsd-user
capstone@22ead3e0bf
chardev Use DECLARE_*CHECKER* macros 2020-09-09 09:27:09 -04:00
contrib plugins: move the more involved plugins to contrib 2020-09-10 10:47:03 +01:00
crypto crypto/gcrypt: Split QCryptoCipherGcrypt into subclasses 2020-09-10 11:02:23 +01:00
default-configs hw/arm: Add two NPCM7xx-based machines 2020-09-14 14:24:58 +01:00
disas configure: move disassembler configuration to meson 2020-09-08 11:43:16 +02:00
docs docs/system: Add Nuvoton machine documentation 2020-09-14 14:24:59 +01:00
dtc@85e5d83984
dump
fpu
fsdev
gdb-xml
hw hw/arm/npcm7xx: add board setup stub for CPU and UART clocks 2020-09-14 14:24:59 +01:00
include hw/arm/npcm7xx: add board setup stub for CPU and UART clocks 2020-09-14 14:24:59 +01:00
io
libdecnumber
linux-headers
linux-user
meson@68ed748f84
migration QOM boilerplate cleanup 2020-09-11 19:26:51 +01:00
monitor configure: do not include dependency flags in QEMU_CFLAGS and LIBS 2020-09-08 11:43:16 +02:00
nbd
net trivial patches pull request 20200911 2020-09-12 14:23:15 +01:00
pc-bios roms: Add virtual Boot ROM for NPCM7xx SoCs 2020-09-14 14:24:59 +01:00
plugins
po
python/qemu
qapi Block layer patches: 2020-09-11 14:47:49 +01:00
qga qga: add command guest-get-devices for reporting VirtIO devices 2020-09-12 20:37:48 -05:00
qobject
qom qom: make object_ref/unref use a void * instead of Object *. 2020-09-08 17:29:18 -04:00
replay
roms roms: Add virtual Boot ROM for NPCM7xx SoCs 2020-09-14 14:24:59 +01:00
scripts decodetree: Improve identifier matching 2020-09-14 14:23:19 +01:00
scsi Use DECLARE_*CHECKER* macros 2020-09-09 09:27:09 -04:00
slirp@ce94eba204
softmmu softmmu: Add missing trace-events file 2020-09-09 17:15:18 +01:00
storage-daemon
stubs
target target/arm: Count PMU events when MDCR.SPME is set 2020-09-14 14:24:15 +01:00
tcg
tests qcow2: Fix removal of list members from BDRVQcow2State.cluster_allocs 2020-09-15 11:05:13 +02:00
tools
trace
ui QOM boilerplate cleanup 2020-09-11 19:26:51 +01:00
util trivial patches pull request 20200911 2020-09-12 14:23:15 +01:00
.cirrus.yml
.dir-locals.el
.editorconfig
.exrc
.gdbinit
.gitignore configure: move disassembler configuration to meson 2020-09-08 11:43:16 +02:00
.gitlab-ci.yml
.gitmodules roms: Add virtual Boot ROM for NPCM7xx SoCs 2020-09-14 14:24:59 +01:00
.gitpublish
.mailmap
.patchew.yml
.readthedocs.yml
.shippable.yml
.travis.yml tests/meson.build: fp tests don't need CONFIG_TCG 2020-09-10 10:43:57 +01:00
block.c
blockdev-nbd.c
blockdev.c
blockjob.c
bootdevice.c
Changelog
CODING_STYLE.rst CODING_STYLE.rst: flesh out our naming conventions. 2020-09-10 10:34:58 +01:00
configure target/arm: Remove KVM support for 32-bit Arm hosts 2020-09-14 14:23:19 +01:00
COPYING
COPYING.LIB
cpus-common.c
device_tree.c
disas.c
dma-helpers.c
exec-vary.c
exec.c target/arm: Move start-powered-off property to generic CPUState 2020-09-08 10:08:42 +10:00
gdbstub.c
gitdm.config
hmp-commands-info.hx
hmp-commands.hx
iothread.c Use DECLARE_*CHECKER* macros 2020-09-09 09:27:09 -04:00
job-qmp.c
job.c
Kconfig
Kconfig.host kconfig: fix comment referring to old Makefiles 2020-09-10 16:20:49 +02:00
LICENSE
MAINTAINERS roms: Add virtual Boot ROM for NPCM7xx SoCs 2020-09-14 14:24:59 +01:00
Makefile Makefile: remove obsolete edk2 exception from "clean" rule 2020-09-13 23:03:14 +02:00
memory_ldst.c.inc
meson_options.txt
meson.build This PR includes multiple fixes and features for RISC-V: 2020-09-13 20:29:35 +01:00
module-common.c
os-posix.c
os-win32.c
qdev-monitor.c
qemu-bridge-helper.c
qemu-edid.c
qemu-img-cmds.hx
qemu-img.c qemu-img: avoid unaligned read requests during convert 2020-09-15 11:05:12 +02:00
qemu-io-cmds.c
qemu-io.c
qemu-keymap.c
qemu-nbd.c
qemu-options-wrapper.h
qemu-options.h
qemu-options.hx
qemu-seccomp.c
qemu.nsi
qemu.sasl
README.rst
replication.c
replication.h
thunk.c linux-user: Add strace support for printing arguments for ioctls used for terminals and serial lines 2020-08-27 12:29:50 +02:00
tpm.c
trace-events trace-events: Fix attribution of trace points to source 2020-09-09 17:17:58 +01:00
VERSION
version.rc
version.texi.in

===========
QEMU README
===========

QEMU is a generic and open source machine & userspace emulator and
virtualizer.

QEMU is capable of emulating a complete machine in software without any
need for hardware virtualization support. By using dynamic translation,
it achieves very good performance. QEMU can also integrate with the Xen
and KVM hypervisors to provide emulated hardware while allowing the
hypervisor to manage the CPU. With hypervisor support, QEMU can achieve
near native performance for CPUs. When QEMU emulates CPUs directly it is
capable of running operating systems made for one machine (e.g. an ARMv7
board) on a different machine (e.g. an x86_64 PC board).

QEMU is also capable of providing userspace API virtualization for Linux
and BSD kernel interfaces. This allows binaries compiled against one
architecture ABI (e.g. the Linux PPC64 ABI) to be run on a host using a
different architecture ABI (e.g. the Linux x86_64 ABI). This does not
involve any hardware emulation, simply CPU and syscall emulation.

QEMU aims to fit into a variety of use cases. It can be invoked directly
by users wishing to have full control over its behaviour and settings.
It also aims to facilitate integration into higher level management
layers, by providing a stable command line interface and monitor API.
It is commonly invoked indirectly via the libvirt library when using
open source applications such as oVirt, OpenStack and virt-manager.

QEMU as a whole is released under the GNU General Public License,
version 2. For full licensing details, consult the LICENSE file.


Building
========

QEMU is multi-platform software intended to be buildable on all modern
Linux platforms, OS-X, Win32 (via the Mingw64 toolchain) and a variety
of other UNIX targets. The simple steps to build QEMU are:


.. code-block:: shell

  mkdir build
  cd build
  ../configure
  make

Additional information can also be found online via the QEMU website:

* `<https://qemu.org/Hosts/Linux>`_
* `<https://qemu.org/Hosts/Mac>`_
* `<https://qemu.org/Hosts/W32>`_


Submitting patches
==================

The QEMU source code is maintained under the GIT version control system.

.. code-block:: shell

   git clone https://git.qemu.org/git/qemu.git

When submitting patches, one common approach is to use 'git
format-patch' and/or 'git send-email' to format & send the mail to the
qemu-devel@nongnu.org mailing list. All patches submitted must contain
a 'Signed-off-by' line from the author. Patches should follow the
guidelines set out in the CODING_STYLE.rst file.

Additional information on submitting patches can be found online via
the QEMU website

* `<https://qemu.org/Contribute/SubmitAPatch>`_
* `<https://qemu.org/Contribute/TrivialPatches>`_

The QEMU website is also maintained under source control.

.. code-block:: shell

  git clone https://git.qemu.org/git/qemu-web.git

* `<https://www.qemu.org/2017/02/04/the-new-qemu-website-is-up/>`_

A 'git-publish' utility was created to make above process less
cumbersome, and is highly recommended for making regular contributions,
or even just for sending consecutive patch series revisions. It also
requires a working 'git send-email' setup, and by default doesn't
automate everything, so you may want to go through the above steps
manually for once.

For installation instructions, please go to

*  `<https://github.com/stefanha/git-publish>`_

The workflow with 'git-publish' is:

.. code-block:: shell

  $ git checkout master -b my-feature
  $ # work on new commits, add your 'Signed-off-by' lines to each
  $ git publish

Your patch series will be sent and tagged as my-feature-v1 if you need to refer
back to it in the future.

Sending v2:

.. code-block:: shell

  $ git checkout my-feature # same topic branch
  $ # making changes to the commits (using 'git rebase', for example)
  $ git publish

Your patch series will be sent with 'v2' tag in the subject and the git tip
will be tagged as my-feature-v2.

Bug reporting
=============

The QEMU project uses Launchpad as its primary upstream bug tracker. Bugs
found when running code built from QEMU git or upstream released sources
should be reported via:

* `<https://bugs.launchpad.net/qemu/>`_

If using QEMU via an operating system vendor pre-built binary package, it
is preferable to report bugs to the vendor's own bug tracker first. If
the bug is also known to affect latest upstream code, it can also be
reported via launchpad.

For additional information on bug reporting consult:

* `<https://qemu.org/Contribute/ReportABug>`_


Contact
=======

The QEMU community can be contacted in a number of ways, with the two
main methods being email and IRC

* `<mailto:qemu-devel@nongnu.org>`_
* `<https://lists.nongnu.org/mailman/listinfo/qemu-devel>`_
* #qemu on irc.oftc.net

Information on additional methods of contacting the community can be
found online via the QEMU website:

* `<https://qemu.org/Contribute/StartHere>`_