mirrors/qemu
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity
qemu/block
History
Kevin Wolf 3a2d501916 block: Fix locking in media change monitor commands 
blk_insert_bs() requires that the caller holds the AioContext lock for
the node to be inserted. Since commit c066e808e11, neglecting to do so
causes a crash when the child has to be moved to a different AioContext
to attach it to the BlockBackend.

This fixes qmp_blockdev_insert_anon_medium(), which is called for the
QMP commands 'blockdev-insert-medium' and 'blockdev-change-medium', to
correctly take the lock.

Cc: qemu-stable@nongnu.org
Fixes: https://issues.redhat.com/browse/RHEL-3922
Fixes: c066e808e11a5c181b625537b6c78e0de27a4801
Signed-off-by: Kevin Wolf <kwolf@redhat.com>
Message-ID: <20231013153302.39234-2-kwolf@redhat.com>
Reviewed-by: Hanna Czenczek <hreitz@redhat.com>
Signed-off-by: Kevin Wolf <kwolf@redhat.com>
(cherry picked from commit fed824501501518b1ad3dc08a39f8f855508190d)
Signed-off-by: Michael Tokarev <mjt@tls.msk.ru>
2023-11-01 12:51:23 +03:00
..
export
vhost-user: fully use new backend/frontend naming
2023-06-26 09:50:00 -04:00
monitor
meson: Replace softmmu_ss -> system_ss
2023-06-20 10:01:30 +02:00
accounting.c
…
aio_task.c
…
amend.c
block: Mark BlockDriver callbacks for amend job GRAPH_RDLOCK
2023-05-10 14:16:54 +02:00
backup.c
…
blkdebug.c
blkdebug: add missing coroutine_fn annotation
2023-04-25 13:17:28 +02:00
blkio.c
block/blkio: add more comments on the fd passing handling
2023-08-03 11:28:43 -04:00
blklogwrites.c
…
blkreplay.c
…
blkverify.c
block: Mark bdrv_recurse_can_replace() and callers GRAPH_RDLOCK
2023-05-10 14:16:54 +02:00
block-backend.c
block: add blk_io_plug_call() API
2023-06-01 07:34:03 -04:00
block-copy.c
…
block-gen.h
…
block-ram-registrar.c
…
bochs.c
bochs: mark more functions as coroutine_fns and GRAPH_RDLOCK
2023-06-28 09:46:24 +02:00
cloop.c
cloop: mark more functions as coroutine_fns and GRAPH_RDLOCK
2023-06-28 09:46:27 +02:00
commit.c
blockjob: Adhere to rate limit even when reentered early
2023-05-19 19:12:12 +02:00
copy-before-write.c
copy-before-write: Fix open with child in iothread
2023-05-30 17:29:35 +02:00
copy-before-write.h
…
copy-on-read.c
block: remove has_variable_length from filters
2023-04-11 16:38:56 +02:00
copy-on-read.h
…
coroutines.h
nbd: Mark nbd_co_do_establish_connection() and callers GRAPH_RDLOCK
2023-05-10 14:16:53 +02:00
create.c
block: Call .bdrv_co_create(_opts) unlocked
2023-05-19 19:12:12 +02:00
crypto.c
block: Call .bdrv_co_create(_opts) unlocked
2023-05-19 19:12:12 +02:00
crypto.h
…
curl.c
aio: remove aio_disable_external() API
2023-05-30 17:37:26 +02:00
dirty-bitmap.c
…
dmg-bz2.c
…
dmg-lzfse.c
…
dmg.c
dmg: mark more functions as coroutine_fns and GRAPH_RDLOCK
2023-06-28 09:46:28 +02:00
dmg.h
block/dmg: Declare a type definition for DMG uncompress function
2023-04-24 13:53:44 -04:00
file-posix.c
file-posix: Simplify raw_co_prw's 'out' zone code
2023-10-03 02:00:54 +03:00
file-win32.c
thread-pool: avoid passing the pool parameter every time
2023-04-25 13:17:28 +02:00
filter-compress.c
block: remove has_variable_length from filters
2023-04-11 16:38:56 +02:00
gluster.c
cutils: Adjust signature of parse_uint[_full]
2023-06-02 12:27:19 -05:00
graph-lock.c
Revert "graph-lock: Disable locking for now"
2023-06-28 08:46:26 +02:00
io_uring.c
block/io_uring: convert to blk_io_plug_call() API
2023-06-01 07:34:03 -04:00
io.c
block: Fix pad_request's request restriction
2023-07-27 09:48:16 -04:00
iscsi-opts.c
…
iscsi.c
aio: remove aio_disable_external() API
2023-05-30 17:37:26 +02:00
linux-aio.c
block/linux-aio: convert to blk_io_plug_call() API
2023-06-01 07:34:03 -04:00
meson.build
meson: Replace softmmu_ss -> system_ss
2023-06-20 10:01:30 +02:00
mirror.c
mirror: Hold main AioContext lock for calling bdrv_open_backing_file()
2023-05-30 17:21:23 +02:00
nbd.c
nbd/client: Simplify cookie vs. index computation
2023-07-19 15:26:13 -05:00
nfs.c
cutils: Adjust signature of parse_uint[_full]
2023-06-02 12:27:19 -05:00
null.c
…
nvme.c
block/nvme: invoke blk_io_plug_call() outside q->lock
2023-07-17 09:17:41 -04:00
parallels-ext.c
…
parallels.c
block: use bdrv_co_getlength in coroutine context
2023-06-28 09:46:33 +02:00
parallels.h
…
plug.c
block: add blk_io_plug_call() API
2023-06-01 07:34:03 -04:00
preallocate.c
block: remove has_variable_length from filters
2023-04-11 16:38:56 +02:00
progress_meter.c
…
qapi-sysemu.c
block: Fix locking in media change monitor commands
2023-11-01 12:51:23 +03:00
qapi.c
block: add accounting for zone append operation
2023-05-15 08:18:10 -04:00
qcow2-bitmap.c
qcow2: mark more functions as coroutine_fns and GRAPH_RDLOCK
2023-06-28 09:46:32 +02:00
qcow2-cache.c
…
qcow2-cluster.c
block: use bdrv_co_debug_event in coroutine context
2023-06-28 09:46:34 +02:00
qcow2-refcount.c
block: use bdrv_co_debug_event in coroutine context
2023-06-28 09:46:34 +02:00
qcow2-snapshot.c
qcow2: mark various functions as coroutine_fn and GRAPH_RDLOCK
2023-04-25 13:17:28 +02:00
qcow2-threads.c
thread-pool: avoid passing the pool parameter every time
2023-04-25 13:17:28 +02:00
qcow2.c
block: use bdrv_co_debug_event in coroutine context
2023-06-28 09:46:34 +02:00
qcow2.h
qcow2: mark more functions as coroutine_fns and GRAPH_RDLOCK
2023-06-28 09:46:32 +02:00
qcow.c
block: use bdrv_co_debug_event in coroutine context
2023-06-28 09:46:34 +02:00
qed-check.c
qed: mark more functions as coroutine_fns and GRAPH_RDLOCK
2023-06-28 09:46:20 +02:00
qed-cluster.c
…
qed-l2-cache.c
…
qed-table.c
block: use bdrv_co_debug_event in coroutine context
2023-06-28 09:46:34 +02:00
qed.c
block: use bdrv_co_debug_event in coroutine context
2023-06-28 09:46:34 +02:00
qed.h
…
quorum.c
block: Mark bdrv_recurse_can_replace() and callers GRAPH_RDLOCK
2023-05-10 14:16:54 +02:00
raw-format.c
block: use bdrv_co_debug_event in coroutine context
2023-06-28 09:46:34 +02:00
rbd.c
…
replication.c
block: remove has_variable_length from filters
2023-04-11 16:38:56 +02:00
reqlist.c
…
snapshot-access.c
…
snapshot.c
…
ssh.c
aio: remove aio_disable_external() API
2023-05-30 17:37:26 +02:00
stream.c
blockjob: Adhere to rate limit even when reentered early
2023-05-19 19:12:12 +02:00
throttle-groups.c
…
throttle.c
…
trace-events
block/io_uring: convert to blk_io_plug_call() API
2023-06-01 07:34:03 -04:00
trace.h
…
vdi.c
block: Call .bdrv_co_create(_opts) unlocked
2023-05-19 19:12:12 +02:00
vhdx-endian.c
…
vhdx-log.c
vhdx: mark more functions as coroutine_fns and GRAPH_RDLOCK
2023-06-28 09:46:30 +02:00
vhdx.c
vhdx: mark more functions as coroutine_fns and GRAPH_RDLOCK
2023-06-28 09:46:30 +02:00
vhdx.h
vhdx: mark more functions as coroutine_fns and GRAPH_RDLOCK
2023-06-28 09:46:30 +02:00
vmdk.c
block: use bdrv_co_debug_event in coroutine context
2023-06-28 09:46:34 +02:00
vpc.c
vpc: mark more functions as coroutine_fns and GRAPH_RDLOCK
2023-06-28 09:46:23 +02:00
vvfat.c
vvfat: mark various functions as coroutine_fn
2023-04-25 13:17:28 +02:00
win32-aio.c
aio: remove aio_disable_external() API
2023-05-30 17:37:26 +02:00
write-threshold.c
…