e90f2a8c3e
cannot_instantiate_with_device_add_yet was introduced by commit
efec3dd631
to replace no_user. It was
supposed to be a temporary measure.
When it was introduced, we had 54
cannot_instantiate_with_device_add_yet=true lines in the code.
Today (3 years later) this number has not shrunk: we now have
57 cannot_instantiate_with_device_add_yet=true lines. I think it
is safe to say it is not a temporary measure, and we won't see
the flag go away soon.
Instead of a long field name that misleads people to believe it
is temporary, replace it a shorter and less misleading field:
user_creatable.
Except for code comments, changes were generated using the
following Coccinelle patch:
@@
expression DC;
@@
(
-DC->cannot_instantiate_with_device_add_yet = false;
+DC->user_creatable = true;
|
-DC->cannot_instantiate_with_device_add_yet = true;
+DC->user_creatable = false;
)
@@
typedef ObjectClass;
expression dc;
identifier class, data;
@@
static void device_class_init(ObjectClass *class, void *data)
{
...
dc->hotpluggable = true;
+dc->user_creatable = true;
...
}
@@
@@
struct DeviceClass {
...
-bool cannot_instantiate_with_device_add_yet;
+bool user_creatable;
...
}
@@
expression DC;
@@
(
-!DC->cannot_instantiate_with_device_add_yet
+DC->user_creatable
|
-DC->cannot_instantiate_with_device_add_yet
+!DC->user_creatable
)
Cc: Alistair Francis <alistair.francis@xilinx.com>
Cc: Laszlo Ersek <lersek@redhat.com>
Cc: Marcel Apfelbaum <marcel@redhat.com>
Cc: Markus Armbruster <armbru@redhat.com>
Cc: Peter Maydell <peter.maydell@linaro.org>
Cc: Thomas Huth <thuth@redhat.com>
Acked-by: Alistair Francis <alistair.francis@xilinx.com>
Reviewed-by: Thomas Huth <thuth@redhat.com>
Reviewed-by: Marcel Apfelbaum <marcel@redhat.com>
Acked-by: Marcel Apfelbaum <marcel@redhat.com>
Signed-off-by: Eduardo Habkost <ehabkost@redhat.com>
Message-Id: <20170503203604.31462-2-ehabkost@redhat.com>
[ehabkost: kept "TODO remove once we're there" comment]
Reviewed-by: Markus Armbruster <armbru@redhat.com>
Signed-off-by: Eduardo Habkost <ehabkost@redhat.com>
305 lines
7.9 KiB
C
305 lines
7.9 KiB
C
/*
|
|
* QEMU VMMouse emulation
|
|
*
|
|
* Copyright (C) 2007 Anthony Liguori <anthony@codemonkey.ws>
|
|
*
|
|
* Permission is hereby granted, free of charge, to any person obtaining a copy
|
|
* of this software and associated documentation files (the "Software"), to deal
|
|
* in the Software without restriction, including without limitation the rights
|
|
* to use, copy, modify, merge, publish, distribute, sublicense, and/or sell
|
|
* copies of the Software, and to permit persons to whom the Software is
|
|
* furnished to do so, subject to the following conditions:
|
|
*
|
|
* The above copyright notice and this permission notice shall be included in
|
|
* all copies or substantial portions of the Software.
|
|
*
|
|
* THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR
|
|
* IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY,
|
|
* FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT SHALL
|
|
* THE AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER
|
|
* LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING FROM,
|
|
* OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN
|
|
* THE SOFTWARE.
|
|
*/
|
|
#include "qemu/osdep.h"
|
|
#include "hw/hw.h"
|
|
#include "ui/console.h"
|
|
#include "hw/input/ps2.h"
|
|
#include "hw/i386/pc.h"
|
|
#include "hw/qdev.h"
|
|
|
|
/* debug only vmmouse */
|
|
//#define DEBUG_VMMOUSE
|
|
|
|
/* VMMouse Commands */
|
|
#define VMMOUSE_GETVERSION 10
|
|
#define VMMOUSE_DATA 39
|
|
#define VMMOUSE_STATUS 40
|
|
#define VMMOUSE_COMMAND 41
|
|
|
|
#define VMMOUSE_READ_ID 0x45414552
|
|
#define VMMOUSE_DISABLE 0x000000f5
|
|
#define VMMOUSE_REQUEST_RELATIVE 0x4c455252
|
|
#define VMMOUSE_REQUEST_ABSOLUTE 0x53424152
|
|
|
|
#define VMMOUSE_QUEUE_SIZE 1024
|
|
|
|
#define VMMOUSE_VERSION 0x3442554a
|
|
|
|
#ifdef DEBUG_VMMOUSE
|
|
#define DPRINTF(fmt, ...) printf(fmt, ## __VA_ARGS__)
|
|
#else
|
|
#define DPRINTF(fmt, ...) do { } while (0)
|
|
#endif
|
|
|
|
#define TYPE_VMMOUSE "vmmouse"
|
|
#define VMMOUSE(obj) OBJECT_CHECK(VMMouseState, (obj), TYPE_VMMOUSE)
|
|
|
|
typedef struct VMMouseState
|
|
{
|
|
ISADevice parent_obj;
|
|
|
|
uint32_t queue[VMMOUSE_QUEUE_SIZE];
|
|
int32_t queue_size;
|
|
uint16_t nb_queue;
|
|
uint16_t status;
|
|
uint8_t absolute;
|
|
QEMUPutMouseEntry *entry;
|
|
void *ps2_mouse;
|
|
} VMMouseState;
|
|
|
|
static uint32_t vmmouse_get_status(VMMouseState *s)
|
|
{
|
|
DPRINTF("vmmouse_get_status()\n");
|
|
return (s->status << 16) | s->nb_queue;
|
|
}
|
|
|
|
static void vmmouse_mouse_event(void *opaque, int x, int y, int dz, int buttons_state)
|
|
{
|
|
VMMouseState *s = opaque;
|
|
int buttons = 0;
|
|
|
|
if (s->nb_queue > (VMMOUSE_QUEUE_SIZE - 4))
|
|
return;
|
|
|
|
DPRINTF("vmmouse_mouse_event(%d, %d, %d, %d)\n",
|
|
x, y, dz, buttons_state);
|
|
|
|
if ((buttons_state & MOUSE_EVENT_LBUTTON))
|
|
buttons |= 0x20;
|
|
if ((buttons_state & MOUSE_EVENT_RBUTTON))
|
|
buttons |= 0x10;
|
|
if ((buttons_state & MOUSE_EVENT_MBUTTON))
|
|
buttons |= 0x08;
|
|
|
|
if (s->absolute) {
|
|
x <<= 1;
|
|
y <<= 1;
|
|
}
|
|
|
|
s->queue[s->nb_queue++] = buttons;
|
|
s->queue[s->nb_queue++] = x;
|
|
s->queue[s->nb_queue++] = y;
|
|
s->queue[s->nb_queue++] = dz;
|
|
|
|
/* need to still generate PS2 events to notify driver to
|
|
read from queue */
|
|
i8042_isa_mouse_fake_event(s->ps2_mouse);
|
|
}
|
|
|
|
static void vmmouse_remove_handler(VMMouseState *s)
|
|
{
|
|
if (s->entry) {
|
|
qemu_remove_mouse_event_handler(s->entry);
|
|
s->entry = NULL;
|
|
}
|
|
}
|
|
|
|
static void vmmouse_update_handler(VMMouseState *s, int absolute)
|
|
{
|
|
if (s->status != 0) {
|
|
return;
|
|
}
|
|
if (s->absolute != absolute) {
|
|
s->absolute = absolute;
|
|
vmmouse_remove_handler(s);
|
|
}
|
|
if (s->entry == NULL) {
|
|
s->entry = qemu_add_mouse_event_handler(vmmouse_mouse_event,
|
|
s, s->absolute,
|
|
"vmmouse");
|
|
qemu_activate_mouse_event_handler(s->entry);
|
|
}
|
|
}
|
|
|
|
static void vmmouse_read_id(VMMouseState *s)
|
|
{
|
|
DPRINTF("vmmouse_read_id()\n");
|
|
|
|
if (s->nb_queue == VMMOUSE_QUEUE_SIZE)
|
|
return;
|
|
|
|
s->queue[s->nb_queue++] = VMMOUSE_VERSION;
|
|
s->status = 0;
|
|
}
|
|
|
|
static void vmmouse_request_relative(VMMouseState *s)
|
|
{
|
|
DPRINTF("vmmouse_request_relative()\n");
|
|
vmmouse_update_handler(s, 0);
|
|
}
|
|
|
|
static void vmmouse_request_absolute(VMMouseState *s)
|
|
{
|
|
DPRINTF("vmmouse_request_absolute()\n");
|
|
vmmouse_update_handler(s, 1);
|
|
}
|
|
|
|
static void vmmouse_disable(VMMouseState *s)
|
|
{
|
|
DPRINTF("vmmouse_disable()\n");
|
|
s->status = 0xffff;
|
|
vmmouse_remove_handler(s);
|
|
}
|
|
|
|
static void vmmouse_data(VMMouseState *s, uint32_t *data, uint32_t size)
|
|
{
|
|
int i;
|
|
|
|
DPRINTF("vmmouse_data(%d)\n", size);
|
|
|
|
if (size == 0 || size > 6 || size > s->nb_queue) {
|
|
printf("vmmouse: driver requested too much data %d\n", size);
|
|
s->status = 0xffff;
|
|
vmmouse_remove_handler(s);
|
|
return;
|
|
}
|
|
|
|
for (i = 0; i < size; i++)
|
|
data[i] = s->queue[i];
|
|
|
|
s->nb_queue -= size;
|
|
if (s->nb_queue)
|
|
memmove(s->queue, &s->queue[size], sizeof(s->queue[0]) * s->nb_queue);
|
|
}
|
|
|
|
static uint32_t vmmouse_ioport_read(void *opaque, uint32_t addr)
|
|
{
|
|
VMMouseState *s = opaque;
|
|
uint32_t data[6];
|
|
uint16_t command;
|
|
|
|
vmmouse_get_data(data);
|
|
|
|
command = data[2] & 0xFFFF;
|
|
|
|
switch (command) {
|
|
case VMMOUSE_STATUS:
|
|
data[0] = vmmouse_get_status(s);
|
|
break;
|
|
case VMMOUSE_COMMAND:
|
|
switch (data[1]) {
|
|
case VMMOUSE_DISABLE:
|
|
vmmouse_disable(s);
|
|
break;
|
|
case VMMOUSE_READ_ID:
|
|
vmmouse_read_id(s);
|
|
break;
|
|
case VMMOUSE_REQUEST_RELATIVE:
|
|
vmmouse_request_relative(s);
|
|
break;
|
|
case VMMOUSE_REQUEST_ABSOLUTE:
|
|
vmmouse_request_absolute(s);
|
|
break;
|
|
default:
|
|
printf("vmmouse: unknown command %x\n", data[1]);
|
|
break;
|
|
}
|
|
break;
|
|
case VMMOUSE_DATA:
|
|
vmmouse_data(s, data, data[1]);
|
|
break;
|
|
default:
|
|
printf("vmmouse: unknown command %x\n", command);
|
|
break;
|
|
}
|
|
|
|
vmmouse_set_data(data);
|
|
return data[0];
|
|
}
|
|
|
|
static int vmmouse_post_load(void *opaque, int version_id)
|
|
{
|
|
VMMouseState *s = opaque;
|
|
|
|
vmmouse_remove_handler(s);
|
|
vmmouse_update_handler(s, s->absolute);
|
|
return 0;
|
|
}
|
|
|
|
static const VMStateDescription vmstate_vmmouse = {
|
|
.name = "vmmouse",
|
|
.version_id = 0,
|
|
.minimum_version_id = 0,
|
|
.post_load = vmmouse_post_load,
|
|
.fields = (VMStateField[]) {
|
|
VMSTATE_INT32_EQUAL(queue_size, VMMouseState),
|
|
VMSTATE_UINT32_ARRAY(queue, VMMouseState, VMMOUSE_QUEUE_SIZE),
|
|
VMSTATE_UINT16(nb_queue, VMMouseState),
|
|
VMSTATE_UINT16(status, VMMouseState),
|
|
VMSTATE_UINT8(absolute, VMMouseState),
|
|
VMSTATE_END_OF_LIST()
|
|
}
|
|
};
|
|
|
|
static void vmmouse_reset(DeviceState *d)
|
|
{
|
|
VMMouseState *s = VMMOUSE(d);
|
|
|
|
s->queue_size = VMMOUSE_QUEUE_SIZE;
|
|
|
|
vmmouse_disable(s);
|
|
}
|
|
|
|
static void vmmouse_realizefn(DeviceState *dev, Error **errp)
|
|
{
|
|
VMMouseState *s = VMMOUSE(dev);
|
|
|
|
DPRINTF("vmmouse_init\n");
|
|
|
|
vmport_register(VMMOUSE_STATUS, vmmouse_ioport_read, s);
|
|
vmport_register(VMMOUSE_COMMAND, vmmouse_ioport_read, s);
|
|
vmport_register(VMMOUSE_DATA, vmmouse_ioport_read, s);
|
|
}
|
|
|
|
static Property vmmouse_properties[] = {
|
|
DEFINE_PROP_PTR("ps2_mouse", VMMouseState, ps2_mouse),
|
|
DEFINE_PROP_END_OF_LIST(),
|
|
};
|
|
|
|
static void vmmouse_class_initfn(ObjectClass *klass, void *data)
|
|
{
|
|
DeviceClass *dc = DEVICE_CLASS(klass);
|
|
|
|
dc->realize = vmmouse_realizefn;
|
|
dc->reset = vmmouse_reset;
|
|
dc->vmsd = &vmstate_vmmouse;
|
|
dc->props = vmmouse_properties;
|
|
/* Reason: pointer property "ps2_mouse" */
|
|
dc->user_creatable = false;
|
|
}
|
|
|
|
static const TypeInfo vmmouse_info = {
|
|
.name = TYPE_VMMOUSE,
|
|
.parent = TYPE_ISA_DEVICE,
|
|
.instance_size = sizeof(VMMouseState),
|
|
.class_init = vmmouse_class_initfn,
|
|
};
|
|
|
|
static void vmmouse_register_types(void)
|
|
{
|
|
type_register_static(&vmmouse_info);
|
|
}
|
|
|
|
type_init(vmmouse_register_types)
|