ec150c7e09
Back in 2016, we discussed[1] rules for headers, and these were
generally liked:
1. Have a carefully curated header that's included everywhere first. We
got that already thanks to Peter: osdep.h.
2. Headers should normally include everything they need beyond osdep.h.
If exceptions are needed for some reason, they must be documented in
the header. If all that's needed from a header is typedefs, put
those into qemu/typedefs.h instead of including the header.
3. Cyclic inclusion is forbidden.
This patch gets include/ closer to obeying 2.
It's actually extracted from my "[RFC] Baby steps towards saner
headers" series[2], which demonstrates a possible path towards
checking 2 automatically. It passes the RFC test there.
[1] Message-ID: <87h9g8j57d.fsf@blackfin.pond.sub.org>
https://lists.nongnu.org/archive/html/qemu-devel/2016-03/msg03345.html
[2] Message-Id: <20190711122827.18970-1-armbru@redhat.com>
https://lists.nongnu.org/archive/html/qemu-devel/2019-07/msg02715.html
Signed-off-by: Markus Armbruster <armbru@redhat.com>
Reviewed-by: Alistair Francis <alistair.francis@wdc.com>
Message-Id: <20190812052359.30071-2-armbru@redhat.com>
Tested-by: Philippe Mathieu-Daudé <philmd@redhat.com>
74 lines
1.9 KiB
C
74 lines
1.9 KiB
C
/*
|
|
* QEMU PowerPC PowerNV CPU Core model
|
|
*
|
|
* Copyright (c) 2016, IBM Corporation.
|
|
*
|
|
* This library is free software; you can redistribute it and/or
|
|
* modify it under the terms of the GNU Lesser General Public License
|
|
* as published by the Free Software Foundation; either version 2 of
|
|
* the License, or (at your option) any later version.
|
|
*
|
|
* This library is distributed in the hope that it will be useful, but
|
|
* WITHOUT ANY WARRANTY; without even the implied warranty of
|
|
* MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU
|
|
* Lesser General Public License for more details.
|
|
*
|
|
* You should have received a copy of the GNU Lesser General Public
|
|
* License along with this library; if not, see <http://www.gnu.org/licenses/>.
|
|
*/
|
|
|
|
#ifndef PPC_PNV_CORE_H
|
|
#define PPC_PNV_CORE_H
|
|
|
|
#include "hw/cpu/core.h"
|
|
#include "target/ppc/cpu.h"
|
|
|
|
#define TYPE_PNV_CORE "powernv-cpu-core"
|
|
#define PNV_CORE(obj) \
|
|
OBJECT_CHECK(PnvCore, (obj), TYPE_PNV_CORE)
|
|
#define PNV_CORE_CLASS(klass) \
|
|
OBJECT_CLASS_CHECK(PnvCoreClass, (klass), TYPE_PNV_CORE)
|
|
#define PNV_CORE_GET_CLASS(obj) \
|
|
OBJECT_GET_CLASS(PnvCoreClass, (obj), TYPE_PNV_CORE)
|
|
|
|
typedef struct PnvCore {
|
|
/*< private >*/
|
|
CPUCore parent_obj;
|
|
|
|
/*< public >*/
|
|
PowerPCCPU **threads;
|
|
uint32_t pir;
|
|
|
|
MemoryRegion xscom_regs;
|
|
} PnvCore;
|
|
|
|
typedef struct PnvCoreClass {
|
|
DeviceClass parent_class;
|
|
|
|
const MemoryRegionOps *xscom_ops;
|
|
} PnvCoreClass;
|
|
|
|
#define PNV_CORE_TYPE_SUFFIX "-" TYPE_PNV_CORE
|
|
#define PNV_CORE_TYPE_NAME(cpu_model) cpu_model PNV_CORE_TYPE_SUFFIX
|
|
|
|
typedef struct PnvCPUState {
|
|
Object *intc;
|
|
} PnvCPUState;
|
|
|
|
static inline PnvCPUState *pnv_cpu_state(PowerPCCPU *cpu)
|
|
{
|
|
return (PnvCPUState *)cpu->machine_data;
|
|
}
|
|
|
|
#define TYPE_PNV_QUAD "powernv-cpu-quad"
|
|
#define PNV_QUAD(obj) \
|
|
OBJECT_CHECK(PnvQuad, (obj), TYPE_PNV_QUAD)
|
|
|
|
typedef struct PnvQuad {
|
|
DeviceState parent_obj;
|
|
|
|
uint32_t id;
|
|
MemoryRegion xscom_regs;
|
|
} PnvQuad;
|
|
#endif /* PPC_PNV_CORE_H */
|